Arch Linux User Repository

@Aaron Not sure what you are asking.

If you are asking if the autoreconf in prepare() is needed then yes.

If you are asking if you need autoreconf installed (via the autoconf package) then the answer is yes as the assumption is that you have base-devel (which includes autoconf in deps) installed when using makepkg.

If you are asking if the autoconf package should be included in makedeps then then the answer is no.

https://wiki.archlinux.org/title/PKGBUILD#makedepends

The package base-devel is assumed to be already installed when building with makepkg. Dependencies of this package should not be included in makedepends array.

need autoreconf?

Thanks for the diff, but personally I am not too interested in adding it to the patch, but I don't really have a very strong opinion on this.

The keybindings that you list should mostly already be part of upstream htop, I don't know if there is much value in changing the bar.

Also need to keep in mind the other "modes" in htop. When you go to the search mode, it will be showing F3 and S-F3 and not a / as that wouldn't work there (and should be n and N but that's beside the point). It will feel a bit random showing F3. Also F1 is a keybind in Vim, even if it doesn't feel much like it.

The real Vim way would be to hide this bar altogether by default. What is this, nano? We don't need reminders of keybinds!

This package could be improved by changing the bindings in the bar at the bottom to use non-function key bindings. Here is a patch, if you're interested in updating the package, or for anyone else who may wish to apply it themselves, if you choose to leave as is. @dawidpotocki

--- a/FunctionBar.c 2024-10-22 01:18:10.531451673 -0500
+++ b/FunctionBar.c 2024-10-22 01:17:54.991451998 -0500
@@ -18,7 +18,7 @@
 #include "XUtils.h"


-static const char* const FunctionBar_FKeys[] = {"F1", "F2", "F3", "F4", "F5", "F6", "F7", "F8", "F9", "F10", NULL};
+static const char* const FunctionBar_FKeys[] = {"?", "C", "/", "\\", "t", ".", "]", "[", "x", "q", NULL};

 static const char* const FunctionBar_FLabels[] = {"      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", "      ", NULL};

I noticed it, it's just that I started writing before you sent it :).

By the way, thanks removing the need to remember which function key does what in htop.

What do you mean?

@dawidpotocki Thanks, yeah it was a false alarm. I added an "EDIT: ..." message to the original post, but ironically the bold text makes it easier to miss.

By the way, thanks removing the need to remember which function key does what in htop.

Hi @mattalxndr,

autoreconf is part of autoconf package; you can see this for yourself with sudo pacman -Fy autoreconf.

autoconf is part of base-devel which is the minimum set of packages required to build AUR packages.

https://wiki.archlinux.org/title/Arch_User_Repository#Prerequisites

So just sudo pacman -S base-devel and it should build just fine.

=== EDIT: Please disregard. PEBKAC ===

@dawidpotocki I don't have autoreconf installed:

==> Starting prepare()...
patching file Action.c
patching file CategoriesPanel.c
patching file MainPanel.c
patching file MainPanel.h
patching file Panel.c
patching file ScreenManager.c
patching file htop.1.in
/home/matt/.cache/yay/htop-vim/PKGBUILD: line 29: autoreconf: command not found
==> ERROR: A failure occurred in prepare().
Aborting...
-> error making: htop-vim-exit status 4
removing untracked AUR files from cache...
:: Cleaning (1/1): /home/matt/.cache/yay/htop-vim
Removing htop-3.3.0.tar.gz
-> Failed to install the following packages. Manual intervention is required:
htop-vim - exit status 4

Not sure, is it actually part of the standard install utilities for AUR packages?