Arch Linux User Repository

Versioned makedepends: go/go-pie I understand. For the others, the versions are coming from the project's own requirements. And it's totally possible for users to get older versions (they haven't updated for a while, downgraded, etc...). So I half agree. Removed them for now, but I don't think it should be a general principle, as it's an extra clarity what tools you need, and it's an effective cross-check.

Dependencies: it is known upstream, if I read e.g. the later discussion of this issue https://github.com/ipfs/ipget/issues/48 For now, I've added this dependencies, but since they have a lot of other dependencies in turn, those has to be go get. Too bad that go get cannot be versioned.

I've added git to makedepends. The weird thing is that go provides go get, but it doesn't list git even as optdepends, hence didn't think of that. Anyways....

Skipping Makefile for now, and splitting the process into prepare and build. Do not use linking there yet, will have to look into that more.

It does seem to work with go-pie (just about 30% larger file is the result). Added it to optdepends.

Don't use versioned makedepends, we're a rolling release so it is impossible for users to get older versions. Also it prevents satisfying go via the go-pie package.

Did you report the missing deps as an upstream bug? Meanwhile it would make sense to download the github.com/repo/project/archive/${_project_commit_hash}.tar.gz in source=() then symlink them like you do with the ipget sources, rather than cloning unknown revisions. Oh, then too, git is not listed as a makedepends even though you decided to clone sources using go get.

> github.com/libp2p/go-floodsub
go: missing Git command. See https://golang.org/s/gogetcmd
package github.com/libp2p/go-floodsub: exec: "git": executable file not found in $PATH

There's no need to patch out the Makefile, it just runs

bin/gx-$ver --verbose install --global
go build

You could do that much yourself, with gx instead of bin/gx-$ver, since their Makefile is both dead simple and wrong.

Or use make gx_bin=/usr/bin/gx gx-go_bin=/usr/bin/gx-go build

Note: the go packaging guidelines are being rewritten, see https://wiki.archlinux.org/index.php/User:Foxboron/Go_packaging_guidelines

You should link sources in prepare() and it would probably make sense to export GOPATH then use that instead of ${srcdir} in many places.

You should test to see if go-pie can be used instead of go.

@frakspace, thanks for hunting down the issue! :D

@imrehg Ah, I figured out the problem. Your version-3 pkgrel works for me, but ONLY if I replace "gcc-go" (which is what I originally had installed) with "go". If I tamper with the specified version number so that the PKGBUILD accepts gcc-go, the same failure occurs. So, that was what was wrong, gcc-go is simply broken and not an acceptable substitute. Thanks!

@imrehg I'm not really sure. It spends a considerable amount of time downloading something. Whether it's succeeding, I don't really know, but if the following diagnostics are useful to you, here are some find commands I tried while in the directory where I tried to build it:

[ipget]$ find . -iname *flood*
./src/src/github.com/libp2p/go-floodsub
./src/src/github.com/libp2p/go-floodsub/floodsub_test.go
./src/src/github.com/libp2p/go-floodsub/floodsub.go
[ipget]$ find . -iname *libp2p*
./src/src/github.com/libp2p
./src/src/github.com/libp2p/go-libp2p-protocol
./src/src/github.com/libp2p/go-libp2p-peer
./src/src/github.com/libp2p/go-libp2p-net
./src/src/github.com/libp2p/go-libp2p-host
./src/src/github.com/libp2p/go-libp2p-crypto
./src/src/github.com/libp2p/go-libp2p-transport
./src/src/github.com/libp2p/go-libp2p-interface-connmgr
./src/src/github.com/libp2p/go-libp2p-peerstore
./src/src/github.com/libp2p/go-libp2p-interface-conn
[ipget]$ find . -iname *ultiadd*
./src/src/github.com/multiformats/go-multiaddr-net
./src/src/github.com/multiformats/go-multiaddr-net/multiaddr
./src/src/github.com/multiformats/go-multiaddr-net/multiaddr/multiaddr.go
./src/src/github.com/multiformats/go-multiaddr
./src/src/github.com/multiformats/go-multiaddr/multiaddr_test.go
./src/src/github.com/multiformats/go-multiaddr/multiaddr.go
[ipget]$ find . -iname *ultipar*
[ipget]$ find . -iname tar-utils
[ipget]$ find . -iname tar*
[ipget]$ find . -iname *utils

So I'm not positive what that means, but assuming I'm not a whole lot less competent at using find than I think I am, it looks like the deps from "whyrusleeping" don't exist anywhere. Or they're named something funny. Or I don't understand what's going on even more than I think. I hope it's of some use, anyway.

@frankspace that's weird, seems like go get fails for you? Looks like textflag.h should be used properly, since it's supplied by the go package.... Not sure I have a guess at this point...

@Eschwartz well, how deep people go into a package and change how it is built? Here for example that means patching out part of the Makefile to work differently... Anyway it's done in pkgver 3, let me know if there's any outstanding "damn don't do it this way" remains.

This isn't working for me. Here's what happens:

==> Extracting sources...
  -> Extracting v0.3.0.tar.gz with bsdtar
==> Starting build()...
==> Installing extra dependencies
> github.com/libp2p/go-floodsub
# github.com/minio/blake2b-simd
src/github.com/minio/blake2b-simd/compress_amd64.go:21:5: error: reference to undefined name ‘avx2’
  if avx2 {
     ^
src/github.com/minio/blake2b-simd/compress_amd64.go:23:12: error: reference to undefined name ‘avx’
  } else if avx {
            ^
src/github.com/minio/blake2b-simd/compress_amd64.go:25:12: error: reference to undefined name ‘ssse3’
  } else if ssse3 {
            ^
# github.com/minio/sha256-simd
src/github.com/minio/sha256-simd/sha256blockAvx2_amd64.s:35:10: fatal error: textflag.h: No such file or directory
 #include "textflag.h"
          ^~~~~~~~~~~~
compilation terminated.

Thanks, but we've got perfectly serviceable packages for gx, and gx-go, which you can use instead of downloading prebuilt versions in make build that don't even do checksum verification.

Also the previous maintainer was an upstream dev who uploaded three non -bin packages (gx and gx-go as well) which all distributed his prebuilt binaries. -bin packages are not automatically bad though, don' worry. :)

Done, built from source.