Package Details: kbdmod 2.1.4-33

Git Clone URL: https://aur.archlinux.org/kbdmod.git (read-only, click to copy)
Package Base: kbdmod
Description: modify your keyboard functionality with multi functions per key
Upstream URL: https://gitlab.com/calvinreu/kbdmod
Keywords: keyboard, oryx qmk,
Licenses: MIT
Submitter: cre243
Maintainer: cre243
Last Packager: cre243
Votes: 1
Popularity: 0.000385
First Submitted: 2022-08-21 14:33 (UTC)
Last Updated: 2023-07-11 20:43 (UTC)

Latest Comments

cre243 commented on 2023-05-27 16:37 (UTC) (edited on 2023-05-27 21:01 (UTC) by cre243)

I have addressed all the mentioned issues I will add some more examples in the future. And yes I use an arch based system, but I did not test the aur installer before.

m040601 commented on 2023-05-27 16:02 (UTC) (edited on 2023-05-27 16:28 (UTC) by m040601)

This PKGBUILD needs revision as it's currently out of date, and installing itself into "/" root.

Does the current PKGBUILD maintainer actually uses this tool on Archlinux ? Does the current PKGBUILD maintainer actually tests and checks what the PKGBUILD is doing before publishing into the AUR ?

I tried this PKGBUILD and this is what landed on my system,

Let's list everything that got installed ,

$ pacman -Ql kbdmod"

`` kbdmod /kbdmod ````

file /kbdmod

/kbdmod: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=bedb833cd7e1519c2a28de8a7b005585460b09a4, for GNU/Linux 4.4.0, stripped

As you can see it installed itself into "root". This is inadmissable.

This needs to be changed,

package() {
    cd "$pkgname-v$pkgver/build"
    cp kbdmod.bin "$pkgdir/kbdmod"
}

Dont use "cp xyz abc". User something like

    install -Dm 755 xyz "$pkgdir/usr/bin/xyz"

Read the Arch Wiki and guidelines about PKGBUILD's.

In addition it also needs to ship and install the needed LICENCE, README and all supporting needed documentation. They already exist in the gitlab repo. They should end in the user computer in something like

/usr/share/licenses/kbdmod/LICENCE
/usr/share/doc/kbdmod/README
/usr/share/doc/kbdmod/examples/examples.md
/usr/share/doc/kbdmod/examples/example-xyz-???.yaml
/usr/share/doc/kbdmod/examples/example-xyz-etc-interception-???
... etc

The documentation is confusing, the README needs polishing and more examples are needed of what exactly needs to go into '/etc/interception/kbdmod/...."

... There are two parts to be configured: kbdmod and udevmon, which launches kbdmod.
... This yaml file resides in `/etc/interception/udevmon.d/some_name.yaml`

... This yaml file conventionally resides in `/etc/interception/kbdmod`.

These same examples need to be shipped to the users computer in "/usr/share/doc/kbdmod/examples/this-and-that"