Package Details: lenovolegionlinux-dkms-git r255.ae96a82-0

Git Clone URL: https://aur.archlinux.org/lenovolegionlinux-dkms-git.git (read-only, click to copy)
Package Base: lenovolegionlinux-dkms-git
Description: LenovoLegionLinux (LLL) DKMS module
Upstream URL: https://github.com/johnfanv2/LenovoLegionLinux
Licenses: GPL
Submitter: MrDuartePT
Maintainer: MrDuartePT (XenHat)
Last Packager: MrDuartePT
Votes: 8
Popularity: 0.005633
First Submitted: 2023-04-28 00:06 (UTC)
Last Updated: 2025-02-04 16:39 (UTC)

Required by (1)

Sources (1)

Latest Comments

« First ‹ Previous 1 2 3

MrDuartePT commented on 2023-04-28 12:25 (UTC)

@yochananmarqos i made the changes you point out except: The architecture is 'any' as there are no ELF files Do not use Pip, use Build and Install, see Python package guidelines

Im confuse why i need a ELF file because the AUR package build have the arch variable set to (x86_64) and this package is stated its only to be use in Lenovo Legion Laptop. The pip part need to be change upstream I need to see with maintainer how to the change (because using python setup.py install dosent install the python package corretly), if possible i will change the pkgbuild.

yochananmarqos commented on 2023-04-28 03:13 (UTC) (edited on 2023-04-28 03:21 (UTC) by yochananmarqos)

There are many things wrong with the PKGBUILD

  • The architecture is 'any' as there are no ELF files
  • Do not add base-devel to makedepends, it is assumed installed
  • Do not add linux-headers to makedepends, it's only optional dependency of dkms for a reason. See DKMS package guidelines
  • Dependencies are missing
  • Use a pkgver function to generate the pkgver, see VCS package guidlines
  • Do not use Pip, use Build and Install, see Python package guidelines
  • There is no reason to disable any makepkg.conf build options at all
  • Do not dump the whole repo into /usr/src/, only install or copy the needed files and folders
  • Do not install files in /usr/local/, see Arch package guidelines
  • The desktop file should be edited to only use the binary name and image name as they will be found in the proper locations
  • Desktop files, images, etc. should have 0644 permissions, they are not executable
  • Single icons belong in /usr/share/pixmaps/. Do not install them directly into /usr/share/icons/. Sized icons belong in /usr/share/icons/hicolor/${size}x${size}/apps
  • The ${pkgdir} variable must be quoted
  • Use install -d to create a folder with 0755 permissions, not mkdir -p. Using install -D creates the leading directory

« First ‹ Previous 1 2 3