Arch Linux User Repository

@dreick, you're just disabling LTO with that flag, so there is no reason to do that. options=("!lto") already does what -fno-lto does.

To make this build with LTO, I had to add the following at the beginning of build():

  export CFLAGS="${CFLAGS} -fno-lto"
  export CXXFLAGS="${CXXFLAGS} -fno-lto"

After it, it did build for me, before I had the error
Error: invalid attempt to declare external version name as default in symbol `xmp_set_player@@XMP_4.4'.

Please consider adding it to the PKGBUILD.

Regards!

The way you guys disable LTO right now causes it to fail to compile on a system that auto does LTO

==> Starting build()...
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking for gcc... gcc
checking whether the C compiler works... no
configure: error: in `/home/hurricane/.cache/paru/clone/libxmp/src/libxmp-4.5.0':
configure: error: C compiler cannot create executables
See `config.log' for more details
==> ERROR: A failure occurred in build().
    Aborting...

Here is a patch to properly disable LTO

diff --git a/PKGBUILD b/PKGBUILD
index f372cb9..8d735ae 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -8,7 +8,7 @@ arch=('i686' 'x86_64')
 url="http://xmp.sourceforge.net/"
 license=('GPL')
 depends=('glibc')
-options=(!emptydirs)
+options=(!emptydirs !lto)
 source=("http://download.sourceforge.net/project/xmp/$pkgname/$pkgver/$pkgname-$pkgver.tar.gz")
 sha256sums=('7847d262112d14e8442f44e5ac6ed9ddbca54c251284720b563c852b31f26e75')

@@ -16,7 +16,6 @@ sha256sums=('7847d262112d14e8442f44e5ac6ed9ddbca54c251284720b563c852b31f26e75')

 build() {
   cd $pkgname-$pkgver
-  CFLAGS="$CFLAGS -fno-lto"
   ./configure --prefix=/usr
   make
 }

@grimi: thanks for adding an attempted fix for the LTO bug.

However, the fix only works if the CFLAGS variable is set inside the build() function.

Setting it outside adds the -flto flag after the -fno-lto flag, which reenables it. Doing it directly in the configure command or before the configure command (see patch) has the same effect.

Patch:

diff --git a/PKGBUILD b/PKGBUILD
index d5c225a..ca8eab4 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -12,10 +12,9 @@ options=(!emptydirs)
 source=("http://download.sourceforge.net/project/xmp/$pkgname/$pkgver/$pkgname-$pkgver.tar.gz")
 sha256sums=('7847d262112d14e8442f44e5ac6ed9ddbca54c251284720b563c852b31f26e75')

-CFLAGS="$CFLAGS -fno-lto"
-
 build() {
   cd $pkgname-$pkgver
+  CFLAGS="$CFLAGS -fno-lto"
   ./configure --prefix=/usr
   make
 }

libxmp doesn't compile with LTO due to symbol versioning problems:

/tmp/cc0Gt2nX.s: Error: invalid attempt to declare external version name as default in symbol `xmp_set_player@@XMP_4.4'

PKGBUILD fix:

diff --git a/PKGBUILD b/PKGBUILD
index 0531628..5590079 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -14,7 +14,7 @@ sha256sums=('7847d262112d14e8442f44e5ac6ed9ddbca54c251284720b563c852b31f26e75')

 build() {
   cd $pkgname-$pkgver
-  ./configure --prefix=/usr
+  ./configure --prefix=/usr CFLAGS="$CFLAGS -fno-lto"
   make
 }