Arch Linux User Repository

build failure with gcc15, but works with gcc14

diff miraclecast-git/PKGBUILD PKGBUILD
4c4
< pkgver=326.f3debd5
---
> pkgver=339.937747f
10c10
< depends=(git "systemd>=221" "python3" "glib2")
---
> depends=(git "gcc14" "systemd>=221" "python3" "glib2" "gstreamer" "wpa_supplicant")
17a18
>   export CC=gcc-14

https://github.com/albfan/miraclecast/issues/532

Just an information for those interested in a variant working on systems without systemd:

I have made a package ↗ miraclecast-nosystemd-git.

Regards!

Upstream's COPYING file says that the license is LGPL. But in your PKGBUILD you say it is GPL.

This are different licenses.

If several licenses apply, you could put all of them in an array, and for clarification install the license terms into /usr/share/licenses/${pkgname}/.

Please fix. Thanks for maintaining!

With namcap, I get the following complaints about missing dependencies:

miraclecast-nosystemd-git E: Dependency gobject-introspection-runtime detected and not included (python modules ['gi.repository.GObject', 'gi.repository.GLib'] needed in files ['usr/bin/gstplayer'])
miraclecast-nosystemd-git E: Dependency gst-plugins-base-libs detected and not included (python modules ['gi.repository.GstVideo'] needed in files ['usr/bin/gstplayer'])
miraclecast-nosystemd-git E: Dependency gstreamer detected and not included (python modules ['gi.repository.Gst'] needed in files ['usr/bin/gstplayer'])
miraclecast-nosystemd-git E: Dependency gtk3 detected and not included (python modules ['gi.repository.Gtk', 'gi.repository.Gdk', 'gi.repository.GdkX11'] needed in files ['usr/bin/gstplayer'])
miraclecast-nosystemd-git E: Dependency python-gobject detected and not included (python modules ['gi.repository.Gtk', 'gi.repository.Gdk', 'gi.repository.GObject', 'gi.repository.Gst', 'gi.repository.GstVideo', 'gi.repository.GdkX11', 'gi.repository.GLib', 'gi'] needed in files ['usr/bin/gstplayer'])

→ gstreamer, gtk3, gst-plugins-base-libs and python-gobject need to be added to the depends array. (gobject-introspection-runtime would then be satisfied by python-gobject.)

Also, readline is needed, but also implicitly satisfied.

Thanks for maintaining!

Gstreamer is a dependency according to upstream's README.md. If it really is, it needs to be added to the depends array. wpa_supplicant as well.

I see that upstream provides "real" version numbers, currently 1.0.

So I propose also retrieving this in $kgver(), and then you can even add =${pkgver} to the provides entry.

A pkgver() could look like:

pkgver() {
  cd "${srcdir}/${_name}"

  _ver="$(git describe --tags | sed -E -e 's|^[vV]||' -e 's|\-g[0-9a-f]*$||' | tr '-' '+')"
  _rev="$(git rev-list --count HEAD)"
  _date="$(git log -1 --date=format:"%Y%m%d" --format="%ad")"
  _hash="$(git rev-parse --short HEAD)"

  if [ -z "${_ver}" ]; then
    error "Could not determine version."
    return 1
  else
    printf '%s' "${_ver}.r${_rev}.${_date}.${_hash}"
  fi
}

which currently yields 1.0+139.r327.20230216.850a1c6.

Regards!

Dependency python3 should be changed to python>=3, or if you need it more restrictive, python>=3 python<4. Thanks for maintaining!

Dependency git should be moved to makedepends.

No, elogind is optional and no the default

It looks like the latest version of the package requires libelogind as a dependency