Package Details: nbdkit 1.42.1-1

Git Clone URL: https://aur.archlinux.org/nbdkit.git (read-only, click to copy)
Package Base: nbdkit
Description: NBD server toolkit
Upstream URL: https://gitlab.com/nbdkit/nbdkit/
Licenses: BSD-3-Clause
Submitter: t-8ch
Maintainer: t-8ch (rwmjones)
Last Packager: t-8ch
Votes: 5
Popularity: 0.000088
First Submitted: 2019-02-22 14:36 (UTC)
Last Updated: 2025-03-04 21:55 (UTC)

Latest Comments

1 2 3 4 5 6 .. 13 Next › Last »

rwmjones commented on 2025-03-05 12:38 (UTC)

Got it! I was sure we had already fixed this, and I've found what I think is the commit which fixes this: https://gitlab.com/nbdkit/nbdkit/-/commit/a2fe619c45a97fd89063cc8d9106264c5adf6018

rwmjones commented on 2025-03-05 12:00 (UTC)

So with current Rust in Fedora I get a different error. I proposed a fix for that one here: https://gitlab.com/nbdkit/nbdkit/-/merge_requests/81

However I can't reproduce the error about "creating a shared reference to mutable static is discouraged". Still keen to know the exact version of Rust / cargo being used.

rwmjones commented on 2025-03-05 11:40 (UTC)

@rwmjones IMO the clippy warnings should not fail the testsuite for a regular release build. Instead it should only do so during development. Maybe tie it to --enable-gcc-warnings?

Propsed here: https://gitlab.com/nbdkit/nbdkit/-/merge_requests/80

t-8ch commented on 2025-03-05 07:38 (UTC)

@rwmjones IMO the clippy warnings should not fail the testsuite for a regular release build. Instead it should only do so during development. Maybe tie it to --enable-gcc-warnings?

rwmjones commented on 2025-03-04 22:15 (UTC)

What's the version of rust? We generally try to keep things up to date with the latest Rust in Fedora Rawhide (Fedora's rolling release). It might be that Rust in Fedora is slightly behind the latest, or that we've somehow broken things for an earlier version of Rust. Unfortunately this is just the general situation with Rust that can't be helped much, but we'll try our best.

t-8ch commented on 2025-03-04 21:59 (UTC) (edited on 2025-03-04 21:59 (UTC) by t-8ch)

Which version of cargo/rust are you using?

dreieck commented on 2025-03-04 21:56 (UTC)

Some tests fail in check():

[...]
Making check in rust
make[2]: Entering directory '/var/cache/makepkg/build/nbdkit/src/nbdkit-1.40.4/plugins/rust'
make  check-TESTS
make[3]: Entering directory '/var/cache/makepkg/build/nbdkit/src/nbdkit-1.40.4/plugins/rust'
make[4]: Entering directory '/var/cache/makepkg/build/nbdkit/src/nbdkit-1.40.4/plugins/rust'
PASS: test-ramdisk.sh
FAIL: cargo-tests.sh
FAIL: clippy.sh
============================================================================
Testsuite summary for nbdkit 1.40.4
============================================================================
# TOTAL: 3
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See plugins/rust/test-suite.log for debugging.
============================================================================
make[4]: *** [Makefile:789: test-suite.log] Error 1
make[4]: Leaving directory '/var/cache/makepkg/build/nbdkit/src/nbdkit-1.40.4/plugins/rust'
make[3]: *** [Makefile:924: check-TESTS] Error 2
make[3]: Leaving directory '/var/cache/makepkg/build/nbdkit/src/nbdkit-1.40.4/plugins/rust'
make[2]: *** [Makefile:1009: check-am] Error 2
make[2]: Leaving directory '/var/cache/makepkg/build/nbdkit/src/nbdkit-1.40.4/plugins/rust'
make[1]: *** [Makefile:540: check-recursive] Error 1
make[1]: Leaving directory '/var/cache/makepkg/build/nbdkit/src/nbdkit-1.40.4/plugins'
make: *** [Makefile:739: check-recursive] Error 1
==> ERROR: A failure occurred in check().

plugins/rust/test-suite.log contains:

[...]
error: creating a shared reference to mutable static is discouraged
    --> src/lib.rs:1025:30
     |
1025 |             .map(|_| unsafe {CONFIG_HELP.as_ptr()} as *const c_char)
     |                              ^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static
     |
     = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html>
     = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives
     = note: `-D static-mut-refs` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(static_mut_refs)]`
[...]

↗ full content of plugins/rust/test-suite.log.

Regards!

dreieck commented on 2025-03-04 21:44 (UTC)

custom:BSD is not a valid license identifier anymore. SPDX license identifiers should be used.

Regards and thanks for the package!

aaruni96 commented on 2024-10-17 10:42 (UTC)

No, I don't think I have SELinux/Apparmor/seccomp enabled at all. (Its vanilla arch, not manjaro or endeavor or whatever, and I assume those things are not enabled if I didn't explicitly set those up.)

rwmjones commented on 2024-10-17 10:40 (UTC)

Could it be a SELinux / Apparmor / seccomp type of thing going on? That's the only thing I can think of that would stop nbdkit from opening an unused port.

Anyway tests that use pick_unused_port can all be skipped safely.