Search Criteria
Package Details: nchat 4.41-1
Package Actions
Git Clone URL: | https://aur.archlinux.org/nchat.git (read-only, click to copy) |
---|---|
Package Base: | nchat |
Description: | console-based chat client with support for Telegram |
Upstream URL: | https://github.com/d99kris/nchat |
Licenses: | MIT |
Conflicts: | nchat-git |
Submitter: | doclai |
Maintainer: | xiota |
Last Packager: | doclai |
Votes: | 2 |
Popularity: | 0.036211 |
First Submitted: | 2023-10-11 00:33 (UTC) |
Last Updated: | 2024-04-03 02:47 (UTC) |
Dependencies (8)
- file (file-gitAUR)
- ncurses (ncurses-gitAUR)
- openssl (openssl-gitAUR, openssl-staticAUR)
- sqlite (sqlite-fossilAUR)
- zlib (zlib-ng-compat-gitAUR, zlib-gitAUR, zlib-ng-compatAUR)
- cmake (cmake-gitAUR) (make)
- go (go-gitAUR, gcc-go-gitAUR, gcc-go) (make)
- gperf (gperf-gitAUR) (make)
Latest Comments
gesh commented on 2024-04-03 12:59 (UTC) (edited on 2024-04-03 12:59 (UTC) by gesh)
Right, cf my qualifier that it's not an urgent matter given that it doesn't practically make a difference.
Checking the data confuses me even more -- cf the data points I posted on the PKGBUILD Talk page, with
glibc
andgcc-libs
in the triple digits of occurrences independs
.file
does appear, pulled in bysubversion
,util-linux
,xdg-utils
, andzathura
. On the other hand, I'd thinkcoreutils
,filesystem
,tar
,util-linux
,bzip2
andxz
would at least be in many packages' implicitmakedepends
, raising the question of where the dividing line is.All in all, consider my objection dropped until a clearer policy statement is given. I'm sorry about the wasted time, this seemed so obvious and trivial that I didn't expect it to drag on this much.
gesh commented on 2024-04-03 12:16 (UTC)
In fact, I actually don't see the
base
exemption documented anywhere, annoyingly enough.gesh commented on 2024-04-03 12:10 (UTC) (edited on 2024-04-03 12:11 (UTC) by gesh)
My mistake in re the guidelines, but
pacman -Qi base
does listfile
as one of the direct dependencies ofbase
. It is true that it is a common dependency withbase-devel
, but so arearchlinux-keyring
,findutils
,gawk
,gettext
,grep
,gzip
,pacman
andsed
.gesh commented on 2024-04-03 11:16 (UTC)
Just went through the new commit, thanks! I forgot to remove
file
fromdepends
in my patch -- it's unnecessary, given that it's inbase
. No rush for that, though, it's not harmful.A stylistic point, though -- I notice you moved the
url
andlicense
to be near thesource
-- any reason for that? I generally like to have my PKGBUILDs followPKGBUILD.proto
guideline of having the metadata being in increasing order of specificity to thisPKGBUILD
(sopkgname, pkgver, ...
are near the top,depends
are in the middle, andinstall, source, *sums
are at the bottom), but perhaps you have a different style? It doesn't matter that much though, so feel free to ignore this point.gesh commented on 2024-03-26 13:38 (UTC) (edited on 2024-03-26 19:37 (UTC) by gesh)
The following should address my concerns: EDIT: After discussing the matter with the packager for
nchat-git
, I've edited the below to be more in line with that package (in particular, I invokecmake
directly, instead of relying on upstream's flakymake.sh
)gesh commented on 2024-03-26 12:16 (UTC) (edited on 2024-03-26 12:24 (UTC) by gesh)
v4.41 was released a couple of days ago. Some critiques of the package:
arch
is definitely notany
-- the package built is platform-specific, and needs to be rebuilt for any new architectureNo need for
_pkgname
when it is equal topkgname
No need for
$pkgname
inprovides
andconflicts
Given that this isn't a VCS package, setting
*sums=('SKIP')
is unacceptable. Also, prefer SHA to MD5 for checksums (though the attack vector here is sufficiently unrealistic that it's not a big deal)Pet peeve, but please don't mix hard-tabs and spaces
Also, comparing to the
-git
package, I find several unnecessary differencesThe
-git
package's description more closely approximatesman PKGBUILD
's guidelines for what a goodpkgdesc
isIt would help for comparison if the layout (variable order, dependency order) were shared between the packages
go
,gperf
are madedepends
here, where the-git
package correctly sees them asmakedepends
@Freso's correct questioning of the addition of
ccache
tomakedepends
-- it should be a Wiki suggestion, with tradeoffs clearly markedhelp2man
is unnecessary -- it's just used inbash ./make.sh doc
, which appears to be an upstream release engineering step and unnecessary for us.Missing
-DCMAKE_BUILD_TYPE
and-DCMAKE_INSTALL_{PREFIX,MANDIR}
recommended by https://wiki.archlinux.org/title/CMake_package_guidelinesFreso commented on 2023-12-31 18:58 (UTC)
Why does this depend on
ccache
andcmake
rather than makedepend? Also, why forceccache
? Shouldn’t that be up to users whether they decide to use it or not?