Package Details: nordtray-bin 0.1.1-3

Git Clone URL: https://aur.archlinux.org/nordtray-bin.git (read-only, click to copy)
Package Base: nordtray-bin
Description: Nordvpn tray icon
Upstream URL: https://github.com/zoli/nordtray/
Licenses: custom: public domain
Conflicts: nordtray
Provides: nordtray
Submitter: zoli
Maintainer: zoli
Last Packager: zoli
Votes: 2
Popularity: 0.000000
First Submitted: 2022-11-30 13:55 (UTC)
Last Updated: 2022-11-30 14:12 (UTC)

Latest Comments

1 2 Next › Last »

zoli commented on 2022-11-30 14:00 (UTC)

@deieck Made the changes you mentioned and created https://aur.archlinux.org/packages/nordtray-bin. Also made a request to merge this to nordtray-bin.

Thanks.

zoli commented on 2022-11-06 22:04 (UTC)

@derieck very much thanks for your comments and also for the diff. I'll make the changes you mentioned.

dreieck commented on 2022-11-06 11:08 (UTC)

And another remark: Please provide checksum for your second source file.

dreieck commented on 2022-11-06 11:05 (UTC) (edited on 2022-11-06 11:07 (UTC) by dreieck)

  • Please change nordvpn-bin dependency to norvpn. So the users are not forced to the -bin-variant but can use any package that provides nordvpn.
  • You download a precompiled binary. According to the Arch Linux packaging guidelines, you need to append -bin to your $pkgname then, i.e. name your package nordtray-bin, and add provides=("nordtray=${pkgver}"), conflicts=("nordtray").
    As an alternative, you can move to download the versioned sources and make the package build by the PKGBUILD. This is recommended, by the way!
  • Please remove go from the depends-array. You download a precompiled binary.
  • If you decide to compile locally, go is needed for compilation only, then it must go to the makedepends array and not to the depends array.
  • There are dependency issues! A namcap run reports:
    nordtray E: Dependency at-spi2-core detected and not included (libraries ['usr/lib/libatk-1.0.so.0'] needed in files ['usr/lib/nordtray/nordtray'])
    nordtray E: Dependency libappindicator-gtk3 detected and not included (libraries ['usr/lib/libappindicator3.so.1'] needed in files ['usr/lib/nordtray/nordtray'])
    So please add those to the depends array.
  • There is a license issue: You have not provided the license=()-statement. Please add a proper license; if it is a custom license (not within /usr/share/licenses/common/), you must install license file(s) into "/usr/share/licenses/${pkgname}/". This can even be a small file just saying "public domain" or "all rights reserved to <author>". But it is needed. Please add.
  • As a suggestion: Add nordtray-executable-symlink-latest to the optdepends-array.

Here a diff of your current PKGBUILD and with the things I mentioned above applied:

--- PKGBUILD.org    2022-11-06 11:49:36.739877263 +0100
+++ PKGBUILD    2022-11-06 12:05:08.749848109 +0100
@@ -4 +4,3 @@
-pkgname=nordtray
+_pkgname="nordtray"
+pkgname="${_pkgname}-bin"
+license=("custom: unknown")
@@ -6,2 +8,5 @@
-pkgrel=1
-depends=('go' 'nordvpn-bin')
+pkgrel=2
+depends=('at-spi2-core' 'libappindicator-gtk3' 'nordvpn')
+optdepends=("nordtray-executable-symlink-latest: To make 'nordtray' executable available in '/usr/bin'.")
+provides=("${_pkgname}=${pkgver}")
+conflicts=("${_pkgname}")
@@ -13,2 +18,2 @@
-   install -D -m644 "$srcdir/$pkgname-$pkgver/assets/nordtray.desktop" "$pkgdir/usr/share/applications/NordTray.desktop"
-   install -D -m644 "$srcdir/$pkgname-$pkgver/assets/nord-active.png" "$pkgdir/usr/share/icons/hicolor/48x48/apps/NordTray.png"
+   install -D -m644 "$srcdir/$_pkgname-$pkgver/assets/nordtray.desktop" "$pkgdir/usr/share/applications/NordTray.desktop"
+   install -D -m644 "$srcdir/$_pkgname-$pkgver/assets/nord-active.png" "$pkgdir/usr/share/icons/hicolor/48x48/apps/NordTray.png"
@@ -15,0 +21,2 @@
+   
+   # install -D m644 <PLEASE COPY LICENSE FILE INTO "${pkgdir}/usr/share/licenses/${pkgname}/" !!!

Thanks for maintaining!

dreieck commented on 2022-11-04 12:04 (UTC) (edited on 2022-11-04 12:04 (UTC) by dreieck)

OK, I made a package for it: → nordtray-executable-symlink-latest.

zoli commented on 2022-09-03 10:53 (UTC)

@dreieck Its possible but I don't like populating binaries and make this change which effects everyone and there is no use for most of them. You can do it your self and use it.

dreieck commented on 2022-09-03 09:49 (UTC)

Can you symlink /usr/lib/nordtray/nordtray to /usr/bin/nordtray, please, for easy command line and script unsage?

Thanks!

zoli commented on 2022-04-01 10:54 (UTC)

@KavalirOS I don't know how to add a dependency for specific WMs so that others wont install it unnecessarily.

KavalirOS commented on 2021-03-11 12:13 (UTC)

For use with XFCE please add libappindicator-gtk3 dependency.

zoli commented on 2021-02-09 06:21 (UTC)

Yes it will be good to have customizable color. You are welcome to create a feature request issue in github repo.