Package Details: odoo-nightly 17.0-14

Git Clone URL: https://aur.archlinux.org/odoo-nightly.git (read-only, click to copy)
Package Base: odoo-nightly
Description: Odoo. Open Source Apps To Grow Your Business.
Upstream URL: https://odoo.com/
Licenses: LGPL-3.0-only
Conflicts: odoo, odoo-17, openerp
Replaces: odoo, odoo-17, openerp
Submitter: HLFH
Maintainer: HLFH
Last Packager: HLFH
Votes: 2
Popularity: 1.20
First Submitted: 2024-05-12 10:04 (UTC)
Last Updated: 2024-05-14 07:43 (UTC)

Latest Comments

1 2 Next › Last »

SamWhited commented on 2024-05-14 13:08 (UTC)

Thanks!

I asked about this here: https://wiki.archlinux.org/title/Talk:Python_package_guidelines#Handling_unmet_python_dependencies

HLFH commented on 2024-05-14 07:48 (UTC) (edited on 2024-05-14 07:48 (UTC) by HLFH)

And giving my two cents: now we have completed the python virtual environment installation method, we may consider adding it there.

HLFH commented on 2024-05-14 07:45 (UTC) (edited on 2024-05-14 07:46 (UTC) by HLFH)

@SamWhited Fixed, and I removed the logrotate file.
I added you as contributor.
Regarding systemd stop odoo, I had some issue like "unable to import module odoo".
But the current package now fully works thanks to you.

SamWhited commented on 2024-05-13 20:57 (UTC)

It works fine for me without it (I did make sure to call daemon-reload before I tried too); this is a simple service so it shouldn't require calling anything in the path to stop odoo, it's just sending a sigint or something to the process that it started originally. Maybe there's some other difference?

HLFH commented on 2024-05-13 20:37 (UTC) (edited on 2024-05-13 20:38 (UTC) by HLFH)

@SamWhited Fixed + other stuff. I changed the line to:

Environment="PATH=/var/lib/odoo/.venv/bin:/usr/bin"

Try systemctl stop odoo without this Environment line? Does it work well for you? Not for me :)

SamWhited commented on 2024-05-13 16:27 (UTC)

Thanks again for all the fixes; sorry to keep sporadically noticing other issues:

You've got the environment being set in the services file Environment="PATH=/var/lib/odoo/.venv/bin:$PATH", however, this is not executed in a shell, so there will be no variable expansion. The environment is literally being set to include the string "$PATH". This makes it unable to find wkhtmltopdf so invoices and quotes can't be generated.

This line isn't needed since it's not calling anything in the virtual environment anyways, as far as I know?

HLFH commented on 2024-05-13 15:55 (UTC)

fixed

SamWhited commented on 2024-05-13 14:16 (UTC) (edited on 2024-05-13 14:17 (UTC) by SamWhited)

Oh! Sorry, and another little bug I found:

The __pycache__ directory is being bundled with the package since we're using the venv, but we probably don't want that. We should probably remove .venv/bin/__pycache__ just before copying the venv over so that we have a nice fresh environment with no pre-built files.

SamWhited commented on 2024-05-13 14:11 (UTC) (edited on 2024-05-13 15:15 (UTC) by SamWhited)

Another suggestion: the logfile is currently set in both the config and the service. However, most arch packages use journald for logging. If we leave the log file off, odoo will log to stderr which systemd will automatically wire up to the journal. This may better match Arch user expectations (and they can always add it back to the log file if they need it, and it probably doesn't need to be hardcoded in the service file at all).

Thanks again for making this package; it's really saving me a ton of time and effort!

EDIT: or even better, I just noticed that it has syslog support. If you add syslog = true to the config file and remove the log files it will log with proper levels (and then journalctl can filter on eg. debug vs. info vs. warn)

HLFH commented on 2024-05-13 02:38 (UTC)

I also updated the .venv path with: virtualenv-tools3. This odoo-nightly is now fully working.