I don't think this package's PKGBUILD
is acceptable according to the Arch package guidelines and how to write PKGBUILD
s.
Some of the reasons I think this is are:
license
field doesn't contain a SPDX license identifier (https://wiki.archlinux.org/title/PKGBUILD#license)- Comments in the
PKGBUILD
are not written in english install
's use-o
and-g
flags, which are not usually used- python's virtual environments are used for installation instead of depending on system packages; this is non-standard and bad practice
- a lengthy, non-trivial, in-line bash script is used for starting
pgadmin4
instead of starting it directly. additionally, the script translates strings with what seems to be google translate before runningpgadmin4
, I consider this bad taste due to not respecting the user's privacy! - etc.
I strongly suggest you to read about packaging software for Arch Linux (i.e. start with the links above) , adhere to these guidelines, and, after following the guidelines with a new version of the PKGBUILD
, get your package reviewed on the forum to avoid these (and other) mistakes in the future and to improve this PKGBUILD
ASAP: https://bbs.archlinux.org/viewforum.php?id=4
Pinned Comments
dakataca commented on 2023-11-27 04:34 (UTC) (edited on 2023-11-29 22:30 (UTC) by dakataca)
Executable
pgadmin4
should only be run from an emulator or terminal multiplexer.Initial Setup
This package includes the initial configuration of
postgresql
on localhost.Complete Uninstall
If you want to completely uninstall
pgadmin
andpostgresql
you should also delete the directories generated in the initial setup: