Arch Linux User Repository

namcap should be happy now. Thank you for your help with improving the PKGBUILD and pointing to some areas the Makefile could improve.

Thanks, that helped, now /usr/lib/libsvoxpico.so is now with full relro and /usr/bin/pico-tts only has partial relro. I think it's because there isn't ${LDFLAGS} added to pico-tts target. I added it there after $(CFLAGS) and now it works.

You can check if it works yourself, build package and then run namcap on it https://wiki.archlinux.org/title/Namcap

@micwoj92 let me know if that works for you. I changed the Makefile of the upstream package to recognize environment CFLAGS, etc, so it should hopefully support your settings.

Thanks. FYI there are still some namcap warnings for this package.

pico-tts W: ELF file ('usr/bin/pico-tts') lacks FULL RELRO, check LDFLAGS.
pico-tts W: ELF file ('usr/lib/libsvoxpico.so') lacks FULL RELRO, check LDFLAGS.

It seems like it doesn't pick up LDFLAGS from /etc/makepkg.conf

pico-tts W: ELF file ('usr/bin/pico-tts') lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK.
pico-tts W: ELF file ('usr/lib/libsvoxpico.so') lacks GNU_PROPERTY_X86_FEATURE_1_SHSTK.
pico-tts W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/bin/pico-tts')

For GNU_PROPERTY_X86_FEATURE_1_SHSTK it needs to add -Wl,-z,shstk to LDFLAGS, unused library could likely by resolved with passing --as-needed.

Please see

--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,23 +1,21 @@
 # Maintainer: Michael Clark <iiridayn@gmail.com>
 pkgname=pico-tts
 pkgver=0.1
-pkgrel=1
+pkgrel=2
 pkgdesc="lib and unix binary for text-to-speech engine from Android"
 arch=('x86_64')
 url="https://github.com/Iiridayn/pico-tts"
 license=('MIT')
-makedepends=('binutils' 'git')
-provides=('libsvoxpico.so')
-
+depends=('glibc')
+makedepends=('git')
+source=("git+$url.git#tag=$pkgver"
+       "git+https://android.googlesource.com/platform/external/svox")
+sha256sums=("SKIP" "SKIP")
 prepare() {
-       if [ -d "$pkgname" ]; then
-               git -C "$pkgname" fetch
-       else
-               git clone --recurse-submodules "https://github.com/Iiridayn/pico-tts.git"
-       fi
        cd "$pkgname"
-       git checkout tags/"$pkgver"
-       git submodule update
+       git submodule init
+       git config submodule.svox.url "${srcdir}/svox"
+       git submodule--helper update
 }

 build() {
@@ -28,4 +26,5 @@ build() {
 package() {
        cd "$pkgname"
        make DESTDIR="$pkgdir/" install
+       install -Dm 644 LICENSE -t "${pkgdir}/usr/share/licenses/${pkgname}"
 }

@MarsSeed I admit I'm a bit confused. Mind showing me what you'd like the PKGBUILD to look like, and if it still builds I can update it? I'm not sure either what you mean by "fixed version" vs "VCS type" packages. 4 years ago I had a problem, I fixed the problem, and I figured out just enough of the packaging system to distribute the fix. I'm rather confused why suddenly there's a problem with the solution, when everything still seems to work fine.

I'm not persuaded it's worth more than the time I've already spent to figure this out again when everything still works. What you're suggesting seems like a lot of work just to acquire context (which you already have, so please feel free to share the solution to the problem you've reported) to solve a problem I don't seem to have. Could you be having an X-Y problem, and hope if I solve Y then X will disappear?

And also you have to pin the main source to a specific commit or tag, not just declare the repo or a branch of it. As this package is a fixed-version one, not a VCS type.

Populating the source=() array is mandatory.

If you need to use Git submodules, please see the relevant section of the Arch VCS guidelines.

@MarsSeed I'm a bit confused about what you're asking - spent half an hour digging into the AUR and PKGBUILD documentation, and as far as I can tell I've not violated any spec and the package still builds fine. Mind making a pull request or giving some examples of what you'd like to see? I'll remove the flag in the meantime.

Please declare the source repos in the PKGBUILD source=() array.