Package Details: pycharm-professional 2024.1.1-1

Git Clone URL: https://aur.archlinux.org/pycharm-professional.git (read-only, click to copy)
Package Base: pycharm-professional
Description: Python IDE for Professional Developers. Professional Edition
Upstream URL: https://www.jetbrains.com/pycharm/
Keywords: development editor ide jetbrains python
Licenses: custom
Submitter: hippojazz
Maintainer: Xavier (37h4n)
Last Packager: Xavier
Votes: 286
Popularity: 0.91
First Submitted: 2013-09-25 03:56 (UTC)
Last Updated: 2024-05-01 20:08 (UTC)

Dependencies (19)

Required by (0)

Sources (4)

Pinned Comments

Latest Comments

« First ‹ Previous 1 .. 14 15 16 17 18 19 20 21 22 23 24 .. 43 Next › Last »

sanerb commented on 2020-04-23 09:41 (UTC) (edited on 2020-04-23 10:06 (UTC) by sanerb)

@XavierCLL -

@donny is very much correct when he says "Please don't touch the official distribution if such change doesn't fix broken functionality in Arch Linux".

Making changes from upstream that are not simply to fix bugs is simply NOT the Arch Way. Note the very first one, "Simplicity":

"Arch Linux defines simplicity as without unnecessary additions or modifications. It ships software as released by the original developers (upstream) with minimal distribution-specific (downstream) changes: patches not accepted by upstream are avoided, and Arch's downstream patches consist almost entirely of backported bug fixes that are obsoleted by the project's next release."

If you believe that your modifications are superior to how JetBrains intended to distribute their product, you are welcome to suggest upstream to them. Users installing this package expect the package to operate as JetBrains distributes it. Alternatively, if you insist on packaging them for the AUR, they should be done so as a separate AUR package (e.g. "pycharm-professional-nofonts").

Please rectify this and remove your deletion of the JetBrains-bundled fonts in this package, otherwise further action may be taken by this package's users. I can confirm breakage as my system fonts are not even populated in the editor, and now none of my lines line up properly. Further, my custom guides are gone. In a language that is entirely whitespace-driven such a python, this is a big deal. With multiple users confirming breakage for them with your change, "works for me" is absolutely not a justified response. This is why you do not make unnecessary changes from upstream, even if you deem them "improvements".

Further, this modification in a packaging context of a proprietary-licensed product may or may not constitute breach of license. I'd recommend consulting with JetBrains on this. However, it's quite clear that your users disagree with your modifications.

Xavier commented on 2020-04-22 17:16 (UTC) (edited on 2020-04-22 17:43 (UTC) by Xavier)

@donny that was because you were using fonts in pycharm that wasn't installed on your system, and use the system font is better, or otherwise if you or someone else can describe that pycharm is unstable with this change in more details, I'll reverse that change. I've tested and all works perfectly. ("and nobody will pay me for this" me neither)

donny commented on 2020-04-22 08:51 (UTC)

As for the latest change - "remove internal fonts, instead use system fonts". PyCharm on my machine become slow and some fonts are messed up. I needed to rebuild the package without removing the built-in fonts, then everything is ok again. Please don't touch the official distribution if such change doesn't fix broken functionality in Arch Linux. I am supposed to work now, but I must solve package issue instead, and nobody will pay me for this.

Xavier commented on 2020-04-21 20:59 (UTC)

Thanks @donny, fixed!

donny commented on 2020-04-21 17:52 (UTC) (edited on 2020-04-21 17:53 (UTC) by donny)

There is also no need to use the -f parameter within the rm call. Please remove it together with the sudo.

While you are updating the PKGBUILD, please make sure to use quotation marks when using a variable in a string parameters. Missing that causes a package build to fail when the build path contains a space character.

Example:

bad: install -dm 755 $pkgdir/opt/$pkgname

good: install -dm 755 "$pkgdir/opt/$pkgname" (this variant is used in /usr/share/pacman/PKGBUILD.proto)

also good: install -dm 755 "$pkgdir"/opt/"$pkgname"

Xavier commented on 2020-04-21 17:38 (UTC)

Thank for the report @hottea, that was a silly mistake, fixed

hottea commented on 2020-04-21 06:02 (UTC)

We usually don't use sudo in PKGBUILD, could you update this line?

Xavier commented on 2020-04-20 20:38 (UTC)

Hi folks, thanks for your comments, I've removed the speedup debugging for python2 and I've realized that the Pycharm has some internal fonts, I've removed it with the purpose that Pycharm use the system font, always better, official fonts keep more updates and patches specific for Arch. Regarding the above ttf-font is needed for the UI, jetbrain mono fonts as optdepends.

Dunky13 commented on 2020-04-20 08:51 (UTC)

@k4M81c the package is for 2020.1, why mark it as out-of-date?

lybin commented on 2020-04-09 17:46 (UTC)

Can to add checks, if exists then build. ttf-font dependency is necessary now after they add Mono font in-build?