Package Details: python-fangfrisch 1.9.0-3

Git Clone URL: https://aur.archlinux.org/python-fangfrisch.git (read-only, click to copy)
Package Base: python-fangfrisch
Description: Freshclam like utility that allows downloading unofficial virus definition files
Upstream URL: https://rseichter.github.io/fangfrisch/
Licenses: GPL
Conflicts: clamav-unofficial-sigs
Provides: clamav-unofficial-sigs
Submitter: amish
Maintainer: amish (Morbius)
Last Packager: amish
Votes: 27
Popularity: 1.61
First Submitted: 2020-02-22 16:48 (UTC)
Last Updated: 2024-03-13 14:02 (UTC)

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 Next › Last »

amish commented on 2024-03-12 01:23 (UTC) (edited on 2024-03-12 01:25 (UTC) by amish)

We can possibly remove -g clamav if @Morbius confirms that normal user wont be able to do anything unexpected / unwanted. That line in PKGBUILD was added recently by @Morbius himself.

Normally scripts / executables are supposed to go in /usr/bin and not /etc.

Also fangfrisch needs clamav because it expects clamdscan file to be there and executes it. And it also needs /var/lib/clamav directory. Hence clamav dependency is correct.

bsdice commented on 2024-03-11 23:54 (UTC) (edited on 2024-03-11 23:56 (UTC) by bsdice)

Then

install -Dm0755 -t "${pkgdir}/etc/fangfrisch" "${srcdir}/fangfrisch-has-news.sh"

might be more suitable, because it contains nothing security sensitive. Also imho not necessary to restrict it to root execution only.

If you look in /etc/fangfrisch everything is owned by root there anyway. As it should be. Only /var/lib/clamav should be owned by clamav so non-uid-0 user clamav can modifiy files there as it pleases. For /etc/ I like root:root owner because settings set by human admin cannot be modified from the daemon.

Morbius commented on 2024-03-11 23:46 (UTC)

Thinking of requirements: Fangfrisch is designed as a companion application for ClamAV, but does not technically require ClamAV. For example, Fangfrisch can run on a different machine and will not be worse off for it. Fangfrisch certainly does not require ClamAV during the build process. The first reference is made in the form of the "clamav" user/group, at install time. That user account is all that matters, from a technical perspective.

bsdice commented on 2024-03-11 23:35 (UTC)

You need package "clamav" in makedepends imho, so the user is around during build time.

Morbius commented on 2024-03-11 21:39 (UTC)

@Taijian ClamAV is listed as a requirement of Fangfrisch, so the user "clamav" is expected to exist. Perhaps @amish can comment on this issue?

Taijian commented on 2024-03-11 21:27 (UTC)

@Morbius: I do not think that user exists.

extra/clamav does install 'clamav.sysusers' to '/usr/lib/sysusers.d/clamav.conf', but I do not think that that file is being sourced in a build chroot.

Morbius commented on 2024-03-11 18:33 (UTC)

@Taijian What group does the user "clamav" belong to in your chroot environment?

Taijian commented on 2024-03-11 13:10 (UTC)

The build currently (1.9.0-2) fails in a clean chroot with the error message:

    ==> Entering fakeroot environment...
    ==> Starting package()...
    install: invalid group 'clamav'
    ==> ERROR: A failure occurred in package().

I believe this is because of the following line:

install -Dm0750 -g clamav -t "${pkgdir}/etc/fangfrisch" "${srcdir}/fangfrisch-has-news.sh"

The clean chroot does not have a 'clamav' group.

Morbius commented on 2024-03-09 20:58 (UTC)

@bearbee I mean the revised package version (note the "-2" suffix). The library you mentioned has the same problem python-fangfrisch has, but that's not an issue I am going to fix. 😉

bearbee commented on 2024-03-09 20:24 (UTC)

which fix? do you mean removing python-protonvpn-nm-lib ?

« First ‹ Previous 1 2 3 4 5 6 7 8 Next › Last »