Package Details: python-flake8-polyfill 1.0.2.r18.gb98e6f4-2

Git Clone URL: https://aur.archlinux.org/python-flake8-polyfill.git (read-only, click to copy)
Package Base: python-flake8-polyfill
Description: Polyfill package for Flake8 plugins
Upstream URL: https://github.com/PyCQA/flake8-polyfill
Licenses: LicenseRef-MIT
Submitter: SpotlightKid
Maintainer: gesh
Last Packager: gesh
Votes: 6
Popularity: 0.48
First Submitted: 2016-10-21 14:19 (UTC)
Last Updated: 2024-04-30 16:56 (UTC)

Pinned Comments

gesh commented on 2024-03-27 12:35 (UTC)

Pushed the update, however it broke the build, so I backported a few of the fixes from the Github repo. To ease future maintenance, the last commit effectively turns this into a -git package to pull in the automatic fixes published by Github. This isn't necessary for most usecases -- if the PKGBUILD looks intimidatingly complex to you, you can always git checkout master^ to use the conceptually-simpler backport.

Latest Comments

« First ‹ Previous 1 2 3 Next › Last »

gesh commented on 2024-03-28 16:04 (UTC)

I don't know -- I'm literally flying in the dark here. I don't know what pamac is doing, nor do I know how to reproduce your configuration exactly enough to try and diagnose this in-depth. Have you asked in the Manjaro Matrix channel? They would know better than me what pamac is tripping over.

petaramesh commented on 2024-03-28 15:57 (UTC)

Well I don't have no custom makepkg.conf and I would assume that my system's makepkg.cponf is correct as I have litterally dozens of AUR packages on my system, that pamac updates on a regular basis, and currently have no issue with any of them - and every time I had, the issue was in the AUR package...

I understand from my logs that the build is tryin to get the checksum of a python-flake8-polyfill file that it cannot find :

==> Validating source files with sha256sums...
    python-flake8-polyfill ... NOT FOUND
    fix-tests.patch ... Passed
    version.sh ... Passed

Here are the diff of the sample makepkg.conf file that you link to compared to the one on my system, I don't believe the differences have any impact on the way the files are checksummed...

❯ diff /tmp/makepkg.conf /etc/makepkg.conf
44,46c44,45
<         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security \
<         -fstack-clash-protection -fcf-protection \
<         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer"
---
>         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security \
>         -fstack-clash-protection -fcf-protection"
48,49c47
< LDFLAGS="-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now \
<          -Wl,-z,pack-relative-relocs"
---
> LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now"
51c49
< RUSTFLAGS="-Cforce-frame-pointers=yes"
---
> RUSTFLAGS=""
53c51
< #MAKEFLAGS="-j2"
---
> MAKEFLAGS="-j2"
86c84
< # Makepkg defaults: OPTIONS=(!strip docs libtool staticlibs emptydirs !zipman !purge !debug !lto !autodeps)
---
> # Makepkg defaults: OPTIONS=(!strip docs libtool staticlibs emptydirs !zipman !purge !debug !lto)
98d95
< #-- autodeps:   Automatically add depends/provides
100c97
< OPTIONS=(strip docs !libtool !staticlibs emptydirs zipman purge debug lto)
---
> OPTIONS=(strip docs !libtool !staticlibs emptydirs zipman purge !debug lto)
118,119d114
< #-- Prefix and directories for library autodeps
< LIB_DIRS=('lib:usr/lib' 'lib32:usr/lib32')
167a163
> 

gesh commented on 2024-03-28 15:38 (UTC) (edited on 2024-03-28 15:51 (UTC) by gesh)

My only remaining hypothesis is that perhaps our makepkg.conf differ -- do you have a file in $XDG_CONFIG_HOME/pacman/makepkg.conf or ~/.makepkg.conf? Does your /etc/makepkg.conf match https://gitlab.archlinux.org/archlinux/packaging/packages/pacman/-/raw/main/makepkg.conf?ref_type=heads&inline=false ?

I asked re Manjaro because it is internally different enough from Arch that I have no idea if something they've changed is breaking things -- for all I know, they might eg have forked makepkg in a way that breaks support for this PKGBUILD

Eg just checking https://gitlab.manjaro.org/packages/core/pacman/-/raw/master/makepkg.conf, I see manjaro uses different MAKEFLAGS and OPTIONS. I have no idea what else could be different, and would strongly recommend you contact the Manjaro Matrix channel first.

petaramesh commented on 2024-03-28 15:25 (UTC)

I get the same results when doing it manually per your instructions, as when having pamac doing it for me (yes I'm on Manjaro, love it <3 )

❯ git clone https://aur.archlinux.org/python-flake8-polyfill.git
Cloning into 'python-flake8-polyfill'...
remote: Enumerating objects: 41, done.
remote: Counting objects: 100% (41/41), done.
remote: Compressing objects: 100% (38/38), done.
remote: Total 41 (delta 2), reused 40 (delta 2), pack-reused 0 (from 0)
Receiving objects: 100% (41/41), 13.45 KiB | 6.73 MiB/s, done.
Resolving deltas: 100% (2/2), done.

/var/tmp/pamac-build-myself 
❯ cd python-flake8-polyfill/

python-flake8-polyfill on  master 
❯ ls -A
.SRCINFO  .git  .gitattributes  PKGBUILD  fix-tests.patch  version.sh

python-flake8-polyfill on  master 
❯ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

python-flake8-polyfill on  master 
❯ makepkg
==> Making package: python-flake8-polyfill 1.0.2.r18.gb98e6f4-1 (Thu Mar 28 16:23:14 2024)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Cloning python-flake8-polyfill git repo...
Cloning into bare repository '/var/tmp/pamac-build-michel/python-flake8-polyfill/python-flake8-polyfill'...
remote: Enumerating objects: 192, done.
remote: Counting objects: 100% (44/44), done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 192 (delta 39), reused 33 (delta 32), pack-reused 148
Receiving objects: 100% (192/192), 59.18 KiB | 1.31 MiB/s, done.
Resolving deltas: 100% (81/81), done.
  -> Found fix-tests.patch
  -> Found version.sh
==> Validating source files with sha256sums...
    python-flake8-polyfill ... NOT FOUND
    fix-tests.patch ... Passed
    version.sh ... Passed
==> ERROR: One or more files did not pass the validity check!

python-flake8-polyfill on  master [?] 
[🔴 ERROR] ❯

petaramesh commented on 2024-03-28 15:04 (UTC)

git log gives the same as yours.

gesh commented on 2024-03-28 15:02 (UTC) (edited on 2024-03-28 15:04 (UTC) by gesh)

Wait, are you on Manjaro? I don't know about pamac, the standard build method for AUR packages that I know of is in this case

git clone https://aur.archlinux.org/python-flake8-polyfill.git
makepkg -D python-flake8-polyfill

See https://wiki.archlinux.org/title/Arch_User_Repository#Installing_and_upgrading_packages

I have no idea what pamac is doing behind the scenes, so I'm having difficulty guessing what might be going wrong. Checking on my own system, these are the results I'm seeing:

$ cd /tmp
$ git clone https://aur.archlinux.org/python-flake8-polyfill.git
Cloning into 'python-flake8-polyfill'...
remote: Enumerating objects: 41, done.
remote: Counting objects: 100% (41/41), done.
remote: Compressing objects: 100% (38/38), done.
remote: Total 41 (delta 2), reused 40 (delta 2), pack-reused 0 (from 0)
Receiving objects: 100% (41/41), 13.45 KiB | 4.48 MiB/s, done.
Resolving deltas: 100% (2/2), done.
$ cd python-flake8-polyfill/
$ ls -A
‘fix-tests.patch’  ‘.git’  ‘.gitattributes’  ‘PKGBUILD’  ‘.SRCINFO’  ‘version.sh’
$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
$ makepkg
==> Making package: python-flake8-polyfill 1.0.2.r18.gb98e6f4-1 (Thu 28 Mar 2024 17:00:22)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Cloning python-flake8-polyfill git repo...
Cloning into bare repository '/tmp/python-flake8-polyfill/python-flake8-polyfill'...
remote: Enumerating objects: 192, done.
remote: Counting objects: 100% (44/44), done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 192 (delta 39), reused 33 (delta 32), pack-reused 148
Receiving objects: 100% (192/192), 59.18 KiB | 388.00 KiB/s, done.
Resolving deltas: 100% (81/81), done.
  -> Found fix-tests.patch
  -> Found version.sh
==> Validating source files with sha256sums...
    python-flake8-polyfill ... Passed
    fix-tests.patch ... Passed
    version.sh ... Passed
==> Extracting sources...
  -> Creating working copy of python-flake8-polyfill git repo...
Cloning into 'python-flake8-polyfill'...
done.
Switched to a new branch 'makepkg'
==> Starting prepare()...
patching file tests/test_stdin.py
==> Starting pkgver()...
==> Starting build()...
* Getting build dependencies for wheel...
running egg_info
creating src/flake8_polyfill.egg-info
writing src/flake8_polyfill.egg-info/PKG-INFO
writing dependency_links to src/flake8_polyfill.egg-info/dependency_links.txt
writing requirements to src/flake8_polyfill.egg-info/requires.txt
writing top-level names to src/flake8_polyfill.egg-info/top_level.txt
writing manifest file 'src/flake8_polyfill.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'CONTRIBUTORS.txt'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no files found matching '*.rst' under directory 'docs'
warning: no files found matching '*.py' under directory 'docs'
warning: no files found matching '*.ini' under directory 'tests'
warning: no files found matching '*.rst' under directory 'tests'
warning: no files found matching '*_diff' under directory 'tests'
no previously-included directories found matching 'docs/build/'
adding license file 'LICENSE'
writing manifest file 'src/flake8_polyfill.egg-info/SOURCES.txt'
* Building wheel...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/flake8_polyfill
copying src/flake8_polyfill/__init__.py -> build/lib/flake8_polyfill
copying src/flake8_polyfill/options.py -> build/lib/flake8_polyfill
copying src/flake8_polyfill/stdin.py -> build/lib/flake8_polyfill
copying src/flake8_polyfill/version.py -> build/lib/flake8_polyfill
installing to build/bdist.linux-x86_64/wheel
running install
running install_lib
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/wheel
creating build/bdist.linux-x86_64/wheel/flake8_polyfill
copying build/lib/flake8_polyfill/__init__.py -> build/bdist.linux-x86_64/wheel/flake8_polyfill
copying build/lib/flake8_polyfill/options.py -> build/bdist.linux-x86_64/wheel/flake8_polyfill
copying build/lib/flake8_polyfill/stdin.py -> build/bdist.linux-x86_64/wheel/flake8_polyfill
copying build/lib/flake8_polyfill/version.py -> build/bdist.linux-x86_64/wheel/flake8_polyfill
running install_egg_info
running egg_info
writing src/flake8_polyfill.egg-info/PKG-INFO
writing dependency_links to src/flake8_polyfill.egg-info/dependency_links.txt
writing requirements to src/flake8_polyfill.egg-info/requires.txt
writing top-level names to src/flake8_polyfill.egg-info/top_level.txt
reading manifest template 'MANIFEST.in'
warning: no files found matching 'CONTRIBUTORS.txt'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no files found matching '*.rst' under directory 'docs'
warning: no files found matching '*.py' under directory 'docs'
warning: no files found matching '*.ini' under directory 'tests'
warning: no files found matching '*.rst' under directory 'tests'
warning: no files found matching '*_diff' under directory 'tests'
no previously-included directories found matching 'docs/build/'
adding license file 'LICENSE'
writing manifest file 'src/flake8_polyfill.egg-info/SOURCES.txt'
Copying src/flake8_polyfill.egg-info to build/bdist.linux-x86_64/wheel/flake8_polyfill-1.0.2-py3.11.egg-info
running install_scripts
creating build/bdist.linux-x86_64/wheel/flake8_polyfill-1.0.2.dist-info/WHEEL
creating '/tmp/python-flake8-polyfill/src/python-flake8-polyfill/dist/.tmp-9s0g65n3/flake8_polyfill-1.0.2-py2.py3-none-any.whl' and adding 'build/bdist.linux-x86_64/wheel' to it
adding 'flake8_polyfill/__init__.py'
adding 'flake8_polyfill/options.py'
adding 'flake8_polyfill/stdin.py'
adding 'flake8_polyfill/version.py'
adding 'flake8_polyfill-1.0.2.dist-info/LICENSE'
adding 'flake8_polyfill-1.0.2.dist-info/METADATA'
adding 'flake8_polyfill-1.0.2.dist-info/WHEEL'
adding 'flake8_polyfill-1.0.2.dist-info/top_level.txt'
adding 'flake8_polyfill-1.0.2.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Successfully built flake8_polyfill-1.0.2-py2.py3-none-any.whl
==> Starting check()...
========================================== test session starts ===========================================
platform linux -- Python 3.11.8, pytest-8.1.1, pluggy-1.4.0
rootdir: /tmp/python-flake8-polyfill/src/python-flake8-polyfill
configfile: setup.cfg
plugins: cov-4.1.0, hypothesis-6.99.11, asyncio-0.23.6, anyio-4.3.0, papis-0.13
asyncio: mode=Mode.STRICT
collected 25 items                                                                                       

tests/test_options.py ....................                                                         [ 80%]
tests/test_stdin.py sssss                                                                          [100%]

===================================== 20 passed, 5 skipped in 0.54s ======================================
==> Entering fakeroot environment...
==> Starting package()...
==> Tidying install...
  -> Removing libtool files...
  -> Purging unwanted files...
  -> Removing static library files...
  -> Stripping unneeded symbols from binaries and libraries...
  -> Compressing man and info pages...
==> Checking for packaging issues...
==> Creating package "python-flake8-polyfill"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
==> Leaving fakeroot environment.
==> Finished making: python-flake8-polyfill 1.0.2.r18.gb98e6f4-1 (Thu 28 Mar 2024 17:00:29)
$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
    pkg/
    python-flake8-polyfill-1.0.2.r18.gb98e6f4-1-any.pkg.tar.zst
    python-flake8-polyfill/
    src/

nothing added to commit but untracked files present (use "git add" to track)
$ for i in . python-flake8-polyfill src/python-flake8-polyfill/; do git -C "$i" remote -v; done
origin  https://aur.archlinux.org/python-flake8-polyfill.git (fetch)
origin  https://aur.archlinux.org/python-flake8-polyfill.git (push)
origin  https://github.com/PyCQA/flake8-polyfill (fetch)
origin  https://github.com/PyCQA/flake8-polyfill (push)
origin  /tmp/python-flake8-polyfill/python-flake8-polyfill (fetch)
origin  /tmp/python-flake8-polyfill/python-flake8-polyfill (push)

Do you see any significant differences on your computer? If makepkg -si works on your computer, then I'd refer the problem to the pamac developers.

petaramesh commented on 2024-03-28 14:42 (UTC)

I was first trying to build using pamac automation. Per your request I went to the /var/tmp/pamac-build-myself/python-flake8-polyfill directory populated by pamac and ran your commands. Doing the git clone I got an error stating that the python-flake8-polyfill directory already existed, so I rm -rf it and retried ; got the output I gave you.

From here, deleting both src and python-flake8-polyfill and running your commands, getting same result.

From here :

❯ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        python-flake8-polyfill/

nothing added to commit but untracked files present (use "git add" to track)

python-flake8-polyfill on  master [?] 
❯ cd python-flake8-polyfill

python-flake8-polyfill on  main via 🐍 v3.11.8 
❯ git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

gesh commented on 2024-03-28 14:33 (UTC)

Also, are you cloning into an empty directory, or inside the package directory? If the latter, what does git status show? Have you tried deleting src first?

gesh commented on 2024-03-28 14:28 (UTC)

Very odd. If you run git log --oneline, what commits do you get? On my computer, that repo shows:

b98e6f4 (HEAD -> main, origin/main, origin/HEAD) Merge pull request #20 from PyCQA/pre-commit-ci-update-config
821f15d [pre-commit.ci] pre-commit autoupdate
5321277 Merge pull request #19 from PyCQA/pre-commit-ci-update-config
6569662 [pre-commit.ci] pre-commit autoupdate
3c0c718 Merge pull request #18 from PyCQA/pre-commit-ci-update-config
230db6e [pre-commit.ci] pre-commit autoupdate
5e8be4b Merge pull request #17 from PyCQA/pre-commit-ci-update-config
eedcd91 [pre-commit.ci] pre-commit autoupdate
3b9104a Merge pull request #16 from PyCQA/pre-commit-ci-update-config
d2ebbf8 [pre-commit.ci] pre-commit autoupdate
33284ce Merge pull request #15 from PyCQA/pre-commit-ci-update-config
dec4be8 [pre-commit.ci] pre-commit autoupdate
c938da9 Merge pull request #13 from PyCQA/pre-commit-ci-update-config
8f90bd5 [pre-commit.ci] pre-commit autoupdate
c6c2daf Merge pull request #12 from PyCQA/pre-commit-ci-update-config
f82bd67 [pre-commit.ci] pre-commit autoupdate
3cf4143 Skip unnecessary tests on Flake8 4.x+
af4aa8a Remove old CI, add GitHub Actions
8664f8e Merge branch 'release-1.0.2' into 'master'
21bbb4f Merge branch 'fix-lint-i202' into 'master'
f2f01e4 Bump version and add notes / contributors for 1.0.2
1413e27 Fix lint (I202)
8550810 Merge branch 'handle-defaults' into 'master'
32433af Fix lint
e656d60 Fix handling default values when processing 3.x params in Flake8 2.x
0406867 Merge branch 'correct-link' of https://gitlab.com/xZise/flake8-polyfill
f952244 Use correct link in setup.py
f4660f0 (tag: 1.0.1) Bump version and add notes for 1.0.1
c76832d Add setup.cfg and MANIFEST.in
0f0d651 (tag: 1.0.0) Add README note about version comparison
7fa4d0a Add changelog with 1.0 release notes
26ab030 Remove doc related Travis test environments
3f2c16f Add stdin and version submodules
280be6f Expand our testing against Flake8 versions
674e36b Add dev-requirements.txt file
e00c60c Add pep8, pycodestyle to tox dependencies
284c5ff Force override action to callback
3af032b Add travis config for mirroring on GitHub
fee0de8 Add missing pylintrc file
258f57b Start adding content and tests
0adbc2b Add a placeholder test for now
a1b157f Setup structure for project

petaramesh commented on 2024-03-28 14:19 (UTC)

python-flake8-polyfill on  master ❯ read -r target repo commit < <(sed -n '/source.git/{s/source = (.)::git+(.)#commit=(.)/\1\t\2\t\3/;p}' .SRCINFO)

python-flake8-polyfill on  master ❯ git clone "$repo" "$target" Cloning into 'python-flake8-polyfill'... remote: Enumerating objects: 181, done. remote: Counting objects: 100% (40/40), done. remote: Compressing objects: 100% (11/11), done. remote: Total 181 (delta 36), reused 30 (delta 29), pack-reused 141 Receiving objects: 100% (181/181), 57.09 KiB | 1.21 MiB/s, done. Resolving deltas: 100% (75/75), done.

python-flake8-polyfill on  master [?] ❯ git show "$commit" fatal: bad object b98e6f4f6cc90334f4d7040745aee91b4021cc42