Arch Linux User Repository

Tests often fail when a search provider is unavailable.

Build with makepkg --nocheck to skip tests.

If using an AUR helper like yay, it's yay -S --mflags --nocheck.

Note -- given that we're not building with the python-setuptools backend, the python-wheel makedep is unnecessary.

Tests often fail when a search provider is unavailable.

Build with makepkg --nocheck to skip tests.

If using an AUR helper like yay, it's yay -S --mflags --nocheck.

I can not install it

tests.py .....F..                                                                                                [100%]

======================================================= FAILURES =======================================================
_____________________________________________________ test_genius ______________________________________________________

    def test_genius():
>       _test_provider("Genius")

tests.py:42:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

provider = 'Genius', kwargs = {}, lrc = None, @py_assert3 = False
@py_format5 = 'assert False\n{False = isinstance(None, str)\n}'

    def _test_provider(provider: str, **kwargs):
        lrc = syncedlyrics.search(search_term=q, providers=[provider], **kwargs)
        logging.debug(lrc)
>       assert isinstance(lrc, str)
E       assert False
E        +  where False = isinstance(None, str)

tests.py:15: AssertionError
=============================================== short test summary info ================================================
FAILED tests.py::test_genius - assert False

@gesh That's correct. The pypi version does not ship with the tests.py file.

@pekkarr I was not aware of this RFC. Thanks for showing it to me. I will undo the changes shortly.

I mean, --nocheck is there in case the test failures are bogus. (as is the case rn, raised upstream: https://github.com/moehmeni/syncedlyrics/issues/25)

@txtsd PyPI shouldn't be used as a source for python packages, see Arch Linux RFC 20. It's better to get the source archive from the github repo, and this makes it possible to run the tests too. Also using the GitHub repo in the url variable would make more sense than the PyPI url.

Any reason the tests were removed in this last commit? Does the pypi version not ship with the tests?

@Typology I can't reproduce the error, please post the whole check output. You can also build in a clean chroot or disable tests with --nocheck makepkg option.

File "/usr/lib/python3.11/site-packages/pytest_asyncio/plugin.py", line 501, in <module>
    @pytest.hookimpl(specname="pytest_pycollect_makeitem", tryfirst=True)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: HookimplMarker.__call__() got an unexpected keyword argument 'specname'
==> ERROR: A failure occurred in check().
    Aborting...
error: failed to build 'python-syncedlyrics-0.8.0-1':

any idea what's the problem here?