Package Details: python-syncedlyrics 0.9.0-1

Git Clone URL: https://aur.archlinux.org/python-syncedlyrics.git (read-only, click to copy)
Package Base: python-syncedlyrics
Description: Get an LRC format (synchronized) lyrics for your music
Upstream URL: https://github.com/moehmeni/syncedlyrics
Keywords: lrc lyrics lyrics-fetcher lyrics-finder lyrics-search music music-bot music-player synced-lyrics synchronization
Licenses: MIT
Submitter: txtsd
Maintainer: txtsd (pekkarr)
Last Packager: txtsd
Votes: 4
Popularity: 0.84
First Submitted: 2023-03-15 19:06 (UTC)
Last Updated: 2024-03-23 04:09 (UTC)

Latest Comments

1 2 3 Next › Last »

txtsd commented on 2024-03-07 12:29 (UTC)

@gesh That's correct. The pypi version does not ship with the tests.py file.

@pekkarr I was not aware of this RFC. Thanks for showing it to me. I will undo the changes shortly.

gesh commented on 2024-03-07 12:27 (UTC)

I mean, --nocheck is there in case the test failures are bogus. (as is the case rn, raised upstream: https://github.com/moehmeni/syncedlyrics/issues/25)

pekkarr commented on 2024-03-07 12:26 (UTC) (edited on 2024-03-07 12:28 (UTC) by pekkarr)

@txtsd PyPI shouldn't be used as a source for python packages, see Arch Linux RFC 20. It's better to get the source archive from the github repo, and this makes it possible to run the tests too. Also using the GitHub repo in the url variable would make more sense than the PyPI url.

gesh commented on 2024-03-07 12:16 (UTC)

Any reason the tests were removed in this last commit? Does the pypi version not ship with the tests?

pekkarr commented on 2024-01-26 14:22 (UTC)

@Typology I can't reproduce the error, please post the whole check output. You can also build in a clean chroot or disable tests with --nocheck makepkg option.

Typology commented on 2024-01-26 12:58 (UTC)

File "/usr/lib/python3.11/site-packages/pytest_asyncio/plugin.py", line 501, in <module>
    @pytest.hookimpl(specname="pytest_pycollect_makeitem", tryfirst=True)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: HookimplMarker.__call__() got an unexpected keyword argument 'specname'
==> ERROR: A failure occurred in check().
    Aborting...
error: failed to build 'python-syncedlyrics-0.8.0-1':

any idea what's the problem here?

aminvakil commented on 2023-10-20 13:54 (UTC)

@pekkarr Sorry for late response, oddly tests run OK for me as well now :|

Anyway I will continue on running this package without running checks, as this is only needed for python-spotdl dependency in my testing environment, and this has gone too far for me.

This was the failing test at the time: https://github.com/aminvakil/aur/actions/runs/6555075825/job/17803026288#step:6:2166

Unfortunately I do not have failed tests which I ran locally then.

pekkarr commented on 2023-10-18 13:23 (UTC)

@aminvakil The tests run successfully for me. What's the failed test output you got? Upstream disabled Netease tests on their CI so if it's related to that then that specific test could be disabled in the PKGBUILD as well.

aminvakil commented on 2023-10-18 12:05 (UTC) (edited on 2023-10-18 12:05 (UTC) by aminvakil)

Tests are failing again, most probably it's related to upstream, I've disabled running tests on python-spotdl before makepkg commands.

pekkarr commented on 2023-09-28 16:50 (UTC)

@gesh thanks fox noticing, the tests are fixed in 0.6.1-2