Package Details: spotdl 4.2.5-5

Git Clone URL: https://aur.archlinux.org/spotdl.git (read-only, click to copy)
Package Base: spotdl
Description: Download your Spotify playlists and songs along with album art and metadata (from YouTube if a match is found).
Upstream URL: https://github.com/spotDL/spotify-downloader
Keywords: download-music mp3 music playlists song song-lyrics spotify youtube-music
Licenses: MIT
Conflicts: python-spotdl
Provides: python-spotdl
Replaces: python-spotdl
Submitter: zoorat
Maintainer: zoorat (pekkarr, aminvakil)
Last Packager: pekkarr
Votes: 20
Popularity: 1.32
First Submitted: 2024-03-31 19:44 (UTC)
Last Updated: 2024-04-27 11:57 (UTC)

Latest Comments

1 2 3 4 5 6 .. 9 Next › Last »

pekkarr commented on 2024-04-27 12:28 (UTC)

@dr460nf1r3 Python 3.12 was just released into the stable repos, which means that you need to rebuild all python packages installed from AUR.

dr460nf1r3 commented on 2024-04-27 12:12 (UTC)

Tests seem to be broken however:

==> Starting check()...
ImportError while loading conftest '/home/nico/spotdl/src/spotify-downloader-4.2.5/tests/conftest.py'.
tests/conftest.py:7: in <module>
from spotdl.download.downloader import Downloader
spotdl/__init__.py:13: in <module>
from spotdl.console import console_entry_point
spotdl/console/__init__.py:5: in <module>
from spotdl.console.entry_point import console_entry_point
spotdl/console/entry_point.py:10: in <module>
from spotdl.console.download import download
spotdl/console/download.py:7: in <module>
from spotdl.download.downloader import Downloader
spotdl/download/downloader.py:20: in <module>
from spotdl.download.progress_handler import ProgressHandler
spotdl/download/progress_handler.py:23: in <module>
from spotdl.types.song import Song
spotdl/types/song.py:11: in <module>
from spotdl.utils.spotify import SpotifyClient
spotdl/utils/spotify.py:16: in <module>
from spotipy import Spotify
E   ModuleNotFoundError: No module named 'spotipy'
Tests failed!

pekkarr commented on 2024-04-27 12:00 (UTC)

@dr460nf1r3 thanks for reporting, it's now fixed in 00f2bfde.

dr460nf1r3 commented on 2024-04-27 11:41 (UTC)

I think this needs an update: 

:: installing python-typing_extensions (4.11.0-1) breaks dependency 'python-typing-extensions' required by spotdl

pekkarr commented on 2024-04-15 17:58 (UTC)

@gesh Commit 7201f310 updated the checksum only in the PKGBUILD, thanks for reporting it. It's fixed in b664a0a8.

gesh commented on 2024-04-15 16:29 (UTC)

Just spotted that building in a clean chroot changed the checksum in .SRCINFO:

$ git diff
diff --git a/.SRCINFO b/.SRCINFO
index 9b9167d..6546eb4 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -38,6 +38,6 @@ pkgbase = spotdl
        conflicts = python-spotdl
        replaces = python-spotdl
        source = spotdl-4.2.5.tar.gz::https://github.com/spotDL/spotify-downloader/archive/v4.2.5.tar.gz
-       b2sums = e7b1ba0c7bebceb0d78ea0b4974b7a2a46612f03a3b3e457f8f996d68b9b23df0c199448956ad5f4398effbe5d59d51c43c310f998a8d4798d07bb89f6c51a5d
+       b2sums = cb45720745936cb4e14fb121e34871614e5be4bdc10f0c23058f979dfd788dd7da06ceb3cc633c93fb7bf799080256f718e29f8ff30fba275be9c6c3f9eae2ca

 pkgname = spotdl

Did you perhaps forget to update the .SRCINFO after updating checksums?

gesh commented on 2024-04-01 13:31 (UTC) (edited on 2024-04-01 14:25 (UTC) by gesh)

Retried building, works in clean chroot. Judging by errors, am guessing the tests aren't XDG-adapted, pinging this upstream. EDIT: Confirmed by playing around with the tests: https://github.com/spotDL/spotify-downloader/issues/2058. Workaround for now: any of

  • Ignore the test failure
  • Disable this particular test using pytest -v not test_config
  • Build in a clean chroot
  • Move $XDG_DATA_HOME/spotdl out of the way during build

In re masking test errors, sure, it's up to the user to do the right thing, but given --nocheck exists, I'd rather just targetedly disable the known-failing test, eg as pytest -v 'not test_config'.

Decision re git history is up to you.

zoorat commented on 2024-04-01 11:08 (UTC)

@gesh please check your env because i built and tested every package before publishing. and I don't think its necessary to keep the history.

xiota commented on 2024-04-01 10:53 (UTC) (edited on 2024-04-01 11:17 (UTC) by xiota)

@gesh All tests pass when I built this.

|| echo ... to allow packaging to complete is acceptable. User responsibility to review output.

gesh commented on 2024-04-01 10:39 (UTC) (edited on 2024-04-01 10:41 (UTC) by gesh)

tests/utils/test_config.py tests fail. Also, by running them with || echo, you're masking the test failures, so the package installs despite test failures.

Finally, it's a shame that this package loses the git history of python-spotdl. If you feel like recovering that history, add a python-spotdl branch pointing to the old python-spotdl/master and git merge --allow-unrelated-histories -Xours python-spotdl to merge them.

1 2 3 4 5 6 .. 9 Next › Last »