Package Details: re3-git 1.0.r294.g3233ffe-1

Git Clone URL: https://aur.archlinux.org/re3-git.git (read-only, click to copy)
Package Base: re3-git
Description: Grand Theft Auto III reverse engineered
Upstream URL: https://github.com/GTAmodding/re3
Keywords: gta
Licenses: LicenseRef-None
Conflicts: re3
Provides: re3
Submitter: hazelnot
Maintainer: eugene
Last Packager: eugene
Votes: 9
Popularity: 0.000000
First Submitted: 2020-10-16 15:27 (UTC)
Last Updated: 2024-03-13 23:12 (UTC)

Pinned Comments

Latest Comments

« First ‹ Previous 1 2 3 4 5 Next › Last »

bpierre commented on 2021-02-15 18:43 (UTC) (edited on 2021-02-15 20:50 (UTC) by bpierre)

OK, I've taken temporary ownership of the package and pushed some fixes, including a basic launcher: re3-launcher will look in ~/.re3/Grand Theft Auto 3, ~/.local/share/Steam/steamapps/common/Grand Theft Auto 3, and the current directory in that order and run re3 from the first one found.

The re3 package also contains some updated game data (patched menu strings, dedicated configuration for proper controller support, ...), and re3-launcher will detect if those are missing and ask before updating the necessary files. (Can be forced with --patch.)

I'll wait for a few days, to fix any obvious issues before disowning, or if you want to take ownership, tell me and I'll disown immediately.

hazelnot commented on 2021-02-15 16:06 (UTC) (edited on 2021-02-15 16:07 (UTC) by hazelnot)

I have no idea how to fix this, I'll disown it and someone who actually knows how to make AUR packages can take over.

Sorry :(

PedroHLC commented on 2021-02-15 16:05 (UTC)

@hazelnot, please adopt a packaging function like https://aur.archlinux.org/cgit/aur.git/tree/?h=revc-git where we have a launch script that cd into a user-directory and execute a system-wide process from there

bpierre commented on 2021-02-15 01:38 (UTC)

The compilation should be done in the build phase, not the package one. It should be done with -j1 to prevent issues (I think that's what you're seeing @Tom_b, I got the same error with my default flags using -j5). Why is the PKGBUILD writing to the home directory?! Additionally, I'm not sure there's a good reason for using the embedded premake5Linux binary (instead of the one provided by the premake package available in community), and cmake is not needed.

 PKGBUILD | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git c/PKGBUILD w/PKGBUILD
index 2c98f9b..707503d 100644
--- c/PKGBUILD
+++ w/PKGBUILD
@@ -7,7 +7,7 @@ arch=('x86_64')
 url="https://github.com/GTAmodding/re3"
 license=('unknown')
 depends=('openal' 'glew' 'glfw' 'libsndfile' 'mpg123')
-makedepends=('git' 'cmake')
+makedepends=('git' 'premake')
 provides=("${pkgname%-git}")
 conflicts=("${pkgname%-git}")
 source=("re3::git+https://github.com/GTAmodding/re3")
@@ -19,15 +19,13 @@ pkgver() {
 }

 build() {
-   export GTA_III_RE_DIR="~/.re3"
-   mkdir "$HOME/.re3"
    cd "$srcdir/${pkgname%-git}"
    git submodule update --init --recursive
-   ./premake5Linux --with-librw gmake2
+   premake5 --with-librw gmake2
+   cd "$srcdir/${pkgname%-git}/build"
+   make config=release_linux-amd64-librw_gl3_glfw-oal -j1
 }

 package() {
-   cd "$srcdir/${pkgname%-git}/build"
-   make config=release_linux-amd64-librw_gl3_glfw-oal
-   cp  "$srcdir/${pkgname%-git}/bin/linux-amd64-librw_gl3_glfw-oal/Release/re3" "$HOME/.re3"
+   install -D -m755 "$srcdir/${pkgname%-git}/bin/linux-amd64-librw_gl3_glfw-oal/Release/re3" "$pkgdir/usr/bin/re3"
 }

Tom_B commented on 2021-02-13 20:06 (UTC)

I'm getting the following issue compiling this:

Linking librw
==== Building re3 (release_linux-amd64-librw_gl3_glfw-oal) ====
Creating obj/linux-amd64-librw_gl3_glfw-oal/Release/re3
make[1]: *** No rule to make target '../src/extras/GitSHA1.cpp', needed by 'obj/linux-amd64-librw_gl3_glfw-oal/Release/re3/GitSHA1.o'.  Stop.
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:78: re3] Error 2
==> ERROR: A failure occurred in package().
    Aborting...
Error making: re3-git

Am I missing something? I installed glfw-x11 as prompted (as I'm on xorg).

parkerlreed commented on 2020-10-28 19:44 (UTC)

re3 binary to /usr/share/games/re3/re3

Tell users to copy gamedata to /usr/share/games/re3 (Most source ports of games support this location)

Script at /usr/bin/re3 that cd's to that folder and runs ./re3

Seems like that would be a good workaround.

hazelnot commented on 2020-10-28 15:19 (UTC)

Oh damn haha thanks a lot!

thaewrapt commented on 2020-10-28 15:18 (UTC)

No worries, I will try to come up with an updated PKGBUILD. In the meantime, I encourage you to check both package guidelines and the link I already mentioned on Arch Wiki.

hazelnot commented on 2020-10-28 15:09 (UTC) (edited on 2020-10-28 15:10 (UTC) by hazelnot)

Unfortunately this is my first AUR package and I don't really know how to fix it :(

It doesn't even install on my PC when using a helper despite it working locally. The developers are working on actual XDG integration but I can't really help since I'm just a designer, not a programmer.

If anyone can actually get this working properly I'm more than willing to relinquish maintainership (is that even a real word?) of this package.

thaewrapt commented on 2020-10-28 15:06 (UTC)

Actually, it's a bad practice to have it copying into homedir in package(), not to mention if would fail if trying to build in chroot https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_clean_chroot (which I have just encountered).

More probably we need a script to do all the necessary steps after the actual installation (i.e., not in PKGBUILD) and a post-install warning for user to run it once.