Arch Linux User Repository

Just as a reminder, this is a VCS (ends in -git) package meaning that every time you build this package, it actually pulls the latest code from git. The version number on AUR and in the PKGBUILD is only representative of the last time the PKGBUILD file was itself touched.

Citation: https://wiki.archlinux.org/index.php/Arch_User_Repository#Flagging_packages_out-of-date

Note: VCS packages are not considered out-of-date when the pkgver changes and are not to be flagged in this case.

@pauper It looks like this may be an upstream issue - https://github.com/briansmith/ring/issues/1444

I'm not able to personally reproduce the issue, but you can test and confirm whether this is the issue by adding options=('!lto') to the PKGBUILD.

Fails to build for me (using aurutils with systemd-nspawn):

          ring.ca715781-cgu.0:   (.text._ZN4ring10arithmetic6bigint13Elem$LT$M$GT$20from_be_bytes_padded17hc5ba4a2520c37f19E+0x167): undefined reference to `LIMBS_less_than'
          /usr/bin/ld: /build/rescrobbled-git/src/rescrobbled/target/release/deps/rescrobbled-e0c651c891b2c318: hidden symbol `GFp_ia32cap_P' isn't defined
          /usr/bin/ld: final link failed: bad value
          collect2: error: ld returned 1 exit status

  = help: some `extern` functions couldn't be found; some native libraries  may need to be installed or have their path specified
  = note: use the `-l` flag to specify native libraries to link
  = note: use the `cargo:rustc-link-lib` directive to specify the native  libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference /build-scripts.html#cargorustc-link-libkindname)

error: could not compile `rescrobbled` due to previous error
==> ERROR: A failure occurred in build().
    Aborting...

@bryec Well thank you for your lightspeed update. I was a little too quick when checking the PKGBUILD then (:

@mgr Thanks for the heads-up! This package is actually supposed to be using its own systemd unit file but the refactor I did recently accidentally switched to using the project's own (incorrect) unit file. I'll push the fixed PKGBUILD shortly.

Thanks again.

The PKGBUILD makes use of the systemd service file provided in the project’s repository. It assumes however that rescrobbled has been installed via cargo and uses the following binary path: ExecStart=%h/.cargo/bin/rescrobbled although it should be /usr/bin/rescrobbled for this package. So just installing this package and enabling the service won’t work in most cases. Maybe this can be patched to the correct path instead?

Hey, first of all thank you for maintaining this package.

I ran into a problem which is more related to Rust than to this program specifically, but could you set

export TMPDIR=$XDG_RUNTIME_DIR

at the beginning of the build() section in the PKGBUILD?

Otherwise the tests fail if /tmp is mounted with noexec (which it should be security wise and is if you use systemd's tmp.mount (# systemctl mask tmp.mount)):

 Running unittests (target/release/deps/rescrobbled-a1d59d1723f4e26d)

running 1 test test filter::tests::test_filter_script ... FAILED

failures:

---- filter::tests::test_filter_script stdout ---- thread 'filter::tests::test_filter_script' panicked at 'assertion failed: (left == right) left: Err("Failed to run filter script: Permission denied (os error 13)"), right: Ok(Filtered(Track { artist: "Artist=lorem", title: "Title=ipsum", album: "Album=dolor" }))', src/filter.rs:97:9 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

failures: filter::tests::test_filter_script

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; > finished in 0.00s

error: test failed, to rerun pass '--bin rescrobbled' ==> ERROR: A failure occurred in check(). Aborting... error making: rescrobbled-git

You can reproduce and test this with
# mount -o remount,noexec /tmp
and
# mount -o remount,exec /tmp

References:
https://github.com/rust-lang/cargo/issues/4350
https://github.com/rust-lang/cargo/issues/4350#issuecomment-340215811

Just as a reminder, this is a VCS (ends in -git) package meaning that every time you build this package, it actually pulls the latest code from git. The version number on AUR and in the PKGBUILD is only representative of the last time the PKGBUILD file was itself touched.

Citation: https://wiki.archlinux.org/index.php/Arch_User_Repository#Flagging_packages_out-of-date

Note: VCS packages are not considered out-of-date when the pkgver changes and are not to be flagged in this case.