Arch Linux User Repository

puts on Trusted User hat

Suddenly using rustup and installing a toolchain to the user's $HOME is not okay, moreso when the need for doing so is only if you're using your own unsupported helper which breaks this.

If users use rustup, that's their problem, and I guess they shouldn't use toolchains that install themselves to $HOME in order to build packages. This very program was supposedly supposed to prevent issues like this -- it's ironic that the only way to build this PKGBUILD in a sane manner, is to use the program you haven't built yet to do it!

Morganamilo: I guess it's kinda controversal then. From my point of view, requiring anything at all from $HOME when building packages is not nice. Had this story with some PKGBUILDs before, was never happy when such constraint breaks. Especially because I build packages from a separate user. Let's leave it as-is then, for now.

I'll say that AUR helpers are not supported.

If this package fails to build because of a specific helper then it should be on the helper to make it work, not the pkgbuild. (even if this pkgbuild is for that helper).

But that's just what I think. If you do care about having a good pkgbuild you should probably ask on the forums/mailing list/irc to see what they come up with.

Morganamilo: another thing about rustup and RUA. The latter currently isolates your $HOME directory, unless you whitelist some paths in ~/.config/rua/wrap_args.sh. So if you e.g. build RUA inside stock RUA, the PKGBUILD script will have empty $HOME and will not be able to work without a rustup command. I understand that it soulds like unneeded complexity, but naturally, I do want this PKGBUILD to be buildable in a clean environment.

Put it another way. If the environment is shared and properly configured, then these configuration lines will never be "hit". Thoughts?

If a user decides to use rustup it should be their responsibility to manage it. I think it's a bad idea for a pkgbuild to start installing something.

To rephrase what I said. Why not just depend on there already being a valid rust environment already set up like other packages do?

Morganamilo: the package does in fact depend on cargo, which is provided by both rust and rustup. So if you have rust installed, everything will work just fine for you.

If, however, you decide to go with rustup, you NEED to also download&install the stable version using rustup itself. This is a rustup limitation, not mine.

EDIT: in other words, users that decide to use rustup cannot just install it via pacman and be ready to build.:( The missing steps are ensured by this PKGBUILD.

Whats up with the rustup calls? Why not just depend on rust? I don't see any reason a pkgbuild should trigger an update/install of something. Especially something not managed by pacman.