@rumpelsepp: You didn't bother me at all, I just wanted to make my position clear, that's all. No need to apologise, either, criticism is a vital part of a thriving development community and should you get it to work right, you'll have been right. For me it's just that I've already put a lot of time into packaging Seafile, so I'm just happy that it works (and I don't have to use proprietary services anymore); if I came across to harsh, I apologise. In any case, give the word, if/when you have something you want me to include.
Search Criteria
Package Details: seafile 9.0.13-1
Package Actions
Git Clone URL: | https://aur.archlinux.org/seafile.git (read-only, click to copy) |
---|---|
Package Base: | seafile |
Description: | An online file storage and collaboration tool |
Upstream URL: | https://github.com/haiwen/seafile |
Licenses: | GPL2 |
Conflicts: | seafile-server |
Provides: | seafile-client-cli |
Submitter: | eolianoe |
Maintainer: | Joffrey |
Last Packager: | Joffrey |
Votes: | 110 |
Popularity: | 0.000000 |
First Submitted: | 2016-08-11 16:38 (UTC) |
Last Updated: | 2025-04-04 12:14 (UTC) |
Dependencies (8)
- argon2 (argon2-gitAUR)
- fuse (fuse2)
- libevent (libevent-gitAUR)
- libsearpcAUR
- libwebsockets
- sqlite (sqlite-fossilAUR)
- intltool (make)
- vala (vala-gitAUR) (make)
Required by (2)
Sources (2)
Latest Comments
« First ‹ Previous 1 .. 31 32 33 34 35 36 37 38 39 40 41 .. 47 Next › Last »
<deleted-account> commented on 2014-06-25 17:09 (UTC)
rumpelsepp commented on 2014-06-25 15:31 (UTC)
@calrama
I didn't want to bother you and I might have chosen the wrong words, I'm sorry! :) I will workout an improved version of the PKGBUILD(s), but this will take a while as I have to read through the docs in detail.
<deleted-account> commented on 2014-06-25 15:21 (UTC)
@rumpelsepp: I am aware of the Arch way, I was not debating whether it's good/conforming to the standard, but whether it's weird and "mixing things up" - imho quite a different thing. But that discussion won't lead us anywhere productive, so I'm leaving it at that, as well.
Back to the actual topic, you are welcome to post a version without virtualenv - should that be feasible - and if you can vouch that you have tested it, I will include it.
rumpelsepp commented on 2014-06-25 10:10 (UTC)
@calrama:
It's simple, you install a dependency somewhere on the system using a virtualenv and so it's not tracked by pacman. Either install everything in a virtualenv or provide a global package including its dependencies. Mixing things up just to fix problems never is a good idea and it does not actually follow KISS. [1]
But I will stop grumbling and will help with fixing this. :)
[1]: https://wiki.archlinux.org/index.php/The_Arch_Way
kiven commented on 2014-06-25 09:53 (UTC)
@calrama : Yes, I did it each time I upgrade the package (I did it only for french, but i could be nice for each language).
<deleted-account> commented on 2014-06-25 09:46 (UTC)
@rumpelsepp: I don't really see what's "weird" about virtualenv, but I'm always happy to reduce the dependencies, should you get seafile-server to work without it, Otherwise, I got the email notifications regarding the other packages, I will reupload them later today (whyever could they not just run a script that adds dummy .AURINFO to all the AUR packages...)
rumpelsepp commented on 2014-06-25 09:20 (UTC)
@calrama
I have looked at the scripts:
- the virtualenv is only used to install django < 1.6 and djangorestframwork which could eventually be fixed with the instructions from google groups
- the configure script takes PYTHON=/usr/bin/python2, this should be fine
- with a shebang-patch we could get rid of these confusing sed calls which are in the wrong function (should be prepare).
- we have to patch these shebangs:
$ grep /usr/bin/env python -r .
./tools/seafile-admin:#!/usr/bin/env python
./tests/test-transfer.py:#!/usr/bin/env python
./tests/test-share.py:#!/usr/bin/env python
./setupwin.py:#!/usr/bin/env python
./scripts/upgrade/db_update_1.3_1.4.py:#!/usr/bin/env python
./scripts/sqlite2mysql.py:#!/usr/bin/env python
./scripts/build/gen-deb-src.py:#!/usr/bin/env python
./scripts/build/build-server.py:#!/usr/bin/env python
./scripts/build/build-server-src.py:#!/usr/bin/env python
./scripts/build/build-msi.py:#!/usr/bin/env python
./scripts/build/build-deb.py:#!/usr/bin/env python
./scripts/build/build-cli.py:#!/usr/bin/env python
./app/seaf-cli:#!/usr/bin/env python
So I think it should be possible to remove this weird virtualenv hack. I will have a deeper look and create a patch later. But I think we have to test it and play around a bit, so I suggest doing this on github or something similar. :)
Furthermore I have posted comments to some seafile-server dependencies which do not have .AURINFO files. And at last I have sent a message to aur-info [1] about django-pipeline which is outdated and maybe has the wrong package name. I will adopt it or create a new package instead; I will let you know when I get news.
[1]: https://mailman.archlinux.org/pipermail/aur-general/2014-June/028966.html
<deleted-account> commented on 2014-06-25 07:56 (UTC)
@rumpelsepp: Archlinux "python" is Python 3. Seafile explicitly gets the "python" binary (or at least, it did at the time the virtualenv was introduced, which was not done by me, by the way, but by the previous maintainer), expects it to be Python 2, and runs its scripts with it, so the only way to get it to work was to run it in an environment where "python" corresponds to Python 2 (which is what virtualenv does) and I see nothing in your link that addresses this issue (correct me if I'm wrong, of course).
If you want to create a patch for seafile-server to run without virtualenv you're welcome to do so; should it work well, I could include it, but personally I don't consider the little benefit of not using virtualenv worth the amount of code-delving necessary to get it to work.
rumpelsepp commented on 2014-06-25 06:10 (UTC)
What is the purpose of this virtualenv thing in seafile-server.install? You could create a patch, see here: https://groups.google.com/d/msg/seafile/bwbcBQ5ASfE/WmVErc_cjXsJ
<deleted-account> commented on 2014-06-19 10:28 (UTC)
@kiven: Is that something that has to be done after each seahub upgrade? If so, I could try to include it in the seahub-preupgrade script.
Pinned Comments