Arch Linux User Repository

To fix the breaking build:

diff --git a/PKGBUILD b/PKGBUILD
index 7628fe5..5b42f21 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -75,6 +75,9 @@ prepare() {

   # Upgrade electron-builder so we do not need fpm installed locally when building on aarch64
   sed -i 's/"electron-builder": "26\.0\.14",/"electron-builder": "26.0.20",/' package.json
+  # dmg-builder 26.0.20 changed vendor/dmgbuild/core.py; the stale macOS-only
+  # background bookmark hunk is not needed for this Linux package.
+  sed -i '/^diff --git a\/vendor\/dmgbuild\/core.py/,$d' patches/dmg-builder.patch

   # Install dependencies for sticker-creator
   pnpm install -C ./sticker-creator/

The breaking change was caused by https://github.com/signalapp/Signal-Desktop/commit/54dd1261f839cb1bfb592dbc50a817ca83e69925 which sets "ignorePatchFailures": false The core.py hunk is not needed for this Linux package. It patches macOS DMG background bookmark code, and dmg-builder@26.0.20 moved that code enough that the old hunk no longer applies.

Also opened a merge request for stable: https://gitlab.archlinux.org/archlinux/packaging/packages/signal-desktop/-/merge_requests/11

I have a problem with the current version (using aarch64):

Done in 2.5s using pnpm v10.18.1
Scope: all 3 workspace projects
 WARN  18 deprecated subdependencies found: @npmcli/move-file@2.0.1, @xmldom/xmldom@0.8.10, boolean@3.2.0, deep-diff@0.3.8, expect-playwright@0.8.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, jest-playwright-preset@4.0.0, jest-process-manager@0.4.0, lodash.isequal@4.5.0, node-domexception@1.0.0, rimraf@2.6.3, rimraf@3.0.2, tar@6.2.1, tar@7.5.2, whatwg-encoding@2.0.0
Packages: +1878
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 2107, reused 1893, downloaded 0, added 1878, done
 ERR_PNPM_PATCH_FAILED  Could not apply patch /home/sushi/tools/signal-desktop-beta/src/Signal-Desktop-8.11.0-beta.1/patches/dmg-builder.patch to /home/sushi/tools/signal-desktop-beta/src/Signal-Desktop-8.11.0-beta.1/node_modules/.pnpm/dmg-builder@26.0.20_patch_hash=7ce1df215d2c4dcbe797485ec0456168d19a4870687b21c489062abd_16c4d23ecd88b27ec5ed7193de2d1f74/node_modules/dmg-builder
==> ERROR: A failure occurred in prepare().
    Aborting...

Is there any workaround for this?

Thanks @Edu4rdSHL!

Hi @mkurz, I have been a bit busy. I will be adding your fix in the next pkgver bump or in the next days, thanks!

Hey @Edu4rdSHL I rebased my branch, see my last comment. If you could merge that that would be really really great for us aarch64 users. Thanks!

Hi @Edu4rdSHL

we no longer need the fpm workaround for aarch64 anymore! All we need to do is to upgrade electron builder from 26.0.14 to 26.0.20 - only a patch release upgrade actually.

See this discussion: https://github.com/signalapp/Signal-Desktop/commit/560dcb91d98ba1177162372a2837919225e3e2c9#commitcomment-168906732 The only reason why the signal team did not upgrade that dependency yet is because there is a problem on macOS with electron-builder version 26.0.18 - but we do not need to care about that.

I pushed a branch here: https://github.com/mkurz/aur/tree/remove-fpm

That branch contains just two commits on top of the signal-desktop-beta branch you maintain: https://github.com/mkurz/aur/commits/remove-fpm/

You can apply that code now easily in your repo with:

git remote add mkurz git@github.com:mkurz/aur.git
git fetch mkurz remove-fpm
git merge mkurz/remove-fpm

Afterwards you could release a new version - please do not forget to bump pkgrel.

What do you think?

Thank you very much!

Thank you very much @Edu4rdSHL, it works!

Hi, @mkurz. Implemented in 7.85.0beta1-2.

@Edu4rdSHL Thanks!

Also I have another request: Lot of chromium/electron based packages offer the possibility to permanently store flags in a dedicated conf file:

For example right now I have following file on my machine:

~/.config/chromium-flags.conf
~/.config/code-flags.conf
~/.config/chrome-flags.conf
~/.config/obsidian/user-flags.conf
~/.config/electron-flags.conf

It would be absolutely great if we could provide the same feature with:

~/.config/signal-desktop-beta-flags.conf

Right now /usr/bin/signal-desktop-beta is a just a symlink to /usr/lib/signal-desktop-beta/signal-desktop-beta. All the packages I mentioned above instead use a bash script in /usr/bin/ which reads the flag file and then executes the binary with the flags from those flags appended.

For example, this is how electron38 does it:

Bash file: https://gitlab.archlinux.org/archlinux/packaging/packages/electron38/-/blob/main/electron-launcher.sh?ref_type=heads Gets installed here (line 629-630): https://gitlab.archlinux.org/archlinux/packaging/packages/electron38/-/blob/main/PKGBUILD?ref_type=heads#L629

Similar for the google chrome package:

Bash file: https://aur.archlinux.org/cgit/aur.git/tree/google-chrome-stable.sh?h=google-chrome

Get's installed here (line 46): https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=google-chrome#n46

They also ship a install file just to print a help message so people are aware of the flags file: https://aur.archlinux.org/cgit/aur.git/tree/google-chrome.install?h=google-chrome

Obsidian:

Bash file: https://gitlab.archlinux.org/archlinux/packaging/packages/obsidian/-/blob/main/obsidian.sh?ref_type=heads

Gets installed here (line 33): https://gitlab.archlinux.org/archlinux/packaging/packages/obsidian/-/blob/main/PKGBUILD?ref_type=heads#L33

Also has an install file: https://gitlab.archlinux.org/archlinux/packaging/packages/obsidian/-/blob/main/obsidian.install?ref_type=heads

Visual Studio code:

Bash file: https://aur.archlinux.org/cgit/aur.git/tree/visual-studio-code-bin.sh?h=visual-studio-code-bin

Gets installed here (line 82): https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=visual-studio-code-bin#n82

Install file: https://aur.archlinux.org/cgit/aur.git/tree/visual-studio-code-bin.install?h=visual-studio-code-bin

chromium

The chromium package does not use a bash file, but compiles a custom wrapper binary which does the same like above bash files:

When you run /usr/bin/chromium --help you will see it's just a launcher. Also see that the binary then just executes /usr/lib/chromium/chromium here:

$ strings /usr/bin/chromium  | grep -i usr
/usr/lib/chromium/chromium

Here is the chromium launcher in the dependencies:

https://gitlab.archlinux.org/archlinux/packaging/packages/chromium/-/blob/main/PKGBUILD?ref_type=heads#L31 -> https://github.com/foutrelis/chromium-launcher/blob/master/launcher.c

So long story short:

I already implemented that feature and tested it (and it works ;) To make things easy for you I pushed the code to a signal-desktop-beta-flags_file branch here: https://github.com/mkurz/aur/tree/signal-desktop-beta-flags_file That branch contains just one commits on top of the signal-desktop-beta branch you maintain: https://github.com/mkurz/aur/commit/893167275b1375a5e5415581de050c321d42da8b

You can apply that code now easily in your repo with:

git remote add mkurz git@github.com:mkurz/aur.git
git fetch mkurz signal-desktop-beta-flags_file
git merge mkurz/signal-desktop-beta-flags_file

Afterwards you could release a new version - please do not forget to bump pkgrel.

What do you think?

Thank you very much!

Hi, @mkurz. Done, thanks for the report. I have been a bit busy on the Christmas holidays; Sorry for the delay :)