Arch Linux User Repository

Hey, this package has some few issues that I think should be fixed.

1. Does not have an SDPX compliant license
2. Does not set the Go flags as discussed here
3. Installs a binary to /usr/share/spicetify-cli/, which is improper, as any executables should either go into /usr/bin or /usr/lib/. /usr/lib should be used here as the binary needs to find other files, which has also been moved to /usr/lib

Here is the patch file for the PKGBUILD:

diff --git a/PKGBUILD b/PKGBUILD
index fdbf88a..dd72b8e 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -5,8 +5,9 @@ pkgrel=1
 pkgdesc='Command-line tool to customize Spotify client'
 arch=('x86_64' 'i686')
 url='https://github.com/spicetify/cli'
-license=('LGPL2.1')
+license=('LGPL-2.1-only')
 makedepends=('go')
+depends=('bash' 'glibc')
 optdepends=('xdg-utils: Allows for opening directories in default file manager')
 source=("cli-$pkgver.tar.gz::$url/archive/v$pkgver.tar.gz")
 sha256sums=('dfaa968ade8359124cc8f59bd39b00be68a551fedbe95e1d7f79543c5141cc25')
@@ -15,6 +16,11 @@ build() {
   cd "cli-$pkgver"
   export GO111MODULE="auto"
   export GOPATH="$srcdir"
+  export CGO_CPPFLAGS="${CPPFLAGS}"
+  export CGO_CFLAGS="${CFLAGS}"
+  export CGO_CXXFLAGS="${CXXFLAGS}"
+  export CGO_LDFLAGS="${LDFLAGS}"
+  export GOFLAGS="-buildmode=pie -trimpath -ldflags=-linkmode=external -mod=readonly -modcacherw"
   go build -ldflags="-X 'main.version=$pkgver'" -o spicetify
 }

@@ -25,12 +31,12 @@ check() {

 package() {
   cd cli-$pkgver
-  install -Dm755 ./spicetify "$pkgdir"/usr/share/$pkgname/spicetify
-  cp -r ./Themes ./Extensions ./CustomApps ./jsHelper ./globals.d.ts ./css-map.json "$pkgdir"/usr/share/$pkgname
+  install -Dm755 ./spicetify "$pkgdir"/usr/lib/$pkgname/spicetify
+  cp -r ./Themes ./Extensions ./CustomApps ./jsHelper ./globals.d.ts ./css-map.json "$pkgdir"/usr/lib/$pkgname

   rm -f ./shortcut
   echo "#!/bin/sh
-/usr/share/$pkgname/spicetify \"\$@\"" >> ./shortcut
+/usr/lib/$pkgname/spicetify \"\$@\"" >> ./shortcut

   install -Dm755 ./shortcut "$pkgdir"/usr/bin/spicetify

Hash should be fixed now. They changed the repo name without telling me in advance lol

Same issue:

==> Validating source files with sha256sums...
    spicetify-cli-2.36.11.tar.gz ... FAILED
==> ERROR: One or more files did not pass the validity check!

seconding hash broken

==> Validating source files with sha256sums...
    spicetify-cli-2.36.11.tar.gz ... FAILED
==> ERROR: One or more files did not pass the validity check!

upgrading to 2.36.11 Hash seems to be incorrect again?

The way you set the version seems to be broken:

$ spicetify -v
Dev

Why gccgoflags and not ldflags?

And shouldn’t your check be something like

check() {
  cd "$pkgname-$pkgver"
  test "v$(./spicetify -v)" = "v$pkgver" || exit 1
}

Only builds if I first export GO111MODULE=auto, would be nice if we could use go modules instead of gopath.

When I try to start it, i get the following error:

bash: /home/MYUSERNAME/.spicetify/spicetify: No such file or directory