Arch Linux User Repository

@dude ah, that makes sense. Thanks!

@HariSeldon You need to rebuild thinkfan after updating its dependencies.

I'm having the same issue as Github user zijian-x:

https://github.com/vmatare/thinkfan/issues/162

@dude, thanks for maintaining this!

Thanks for the patch, it is much appreciated. I will apply it and update the package in the morning.

Some improvements: http://ix.io/2LCC

Dont fail if BUILDDIR in makepkg.conf is not empty.
Installing "$pkgname".service once is enough :)

diff --git a/.SRCINFO b/.SRCINFO
index 4417b42..6c419bc 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
 pkgbase = thinkfan
    pkgdesc = A minimalist fan control program. Supports the sysfs hwmon interface and thinkpad_acpi
    pkgver = 1.2.1
-   pkgrel = 2
+   pkgrel = 3
    url = https://github.com/vmatare/thinkfan
    install = thinkfan.install
    arch = i686
diff --git a/PKGBUILD b/PKGBUILD
index 3c99a7e..17905ea 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -4,7 +4,7 @@

 pkgname=thinkfan
 pkgver=1.2.1
-pkgrel=2
+pkgrel=3
 pkgdesc="A minimalist fan control program. Supports the sysfs hwmon interface and thinkpad_acpi"
 url="https://github.com/vmatare/thinkfan"
 arch=('i686' 'x86_64')
@@ -37,10 +37,9 @@ package() {
   install -D -m644 examples/* "$pkgdir"/usr/share/doc/"$pkgname"/examples
   install -D -m644 src/"$pkgname".1 "$pkgdir"/usr/share/man/man1
   install -D -m644 src/"$pkgname".conf.5 "$pkgdir"/usr/share/man/man5
-  install -D -m644 ../"$pkgname".service rcscripts/systemd/thinkfan-wakeup.service "$pkgdir"/usr/lib/systemd/system
-  install -D -m644 ../"$pkgname".service rcscripts/systemd/thinkfan-sleep.service "$pkgdir"/usr/lib/systemd/system
+  install -D -m644 "$srcdir/$pkgname".service rcscripts/systemd/thinkfan-{sleep,wakeup}.service "$pkgdir"/usr/lib/systemd/system
   install -D -m644 rcscripts/systemd/override.conf "$pkgdir"/etc/systemd/system/thinkfan.service.d
-  install -D -m644 ../thinkpad_acpi.conf "$pkgdir"/usr/lib/modprobe.d
+  install -D -m644 "$srcdir"/thinkpad_acpi.conf "$pkgdir"/usr/lib/modprobe.d
 }

 # vim:set ts=2 sw=2 noet:

@FirstAirBender silentnoodle has added the service file for thinkfan-sleep. Please let me know if there are any other changes you see that need to be made.

@dude all yours

@silentnoodle I can if you don't want to.

@dude do you want to maintain this?

@silentnoodle How are you going to test if the package works without a thinkpad?

Missing important configurations from upstream. Please see thinkfan-git as an example. For example, it is missing the thinkfan-sleep.service file

@BubuIIC Those packages usually aren't included in makedepends because it's assumed that you have the base-devel group installed if you're building packages

This needs a makedepends on make and pkgconf

I'm disowning this package because I don't use Arch as my main distro anymore...anyone who has the time, feel free to adopt it. Thanks

@dude thanks for willing to help. Apparently, it was something with indentation. I've re-checked and corrected all the indents (by space), and now it doesn't complain. I guess yaml-cpp error reporting is meh.

BTW, there's v1.2.1 available.

@post-factum It's hard to tell without seeing your full config file. Email me and I'll see if I can help. My address is in the first line of the PKGBUILD.

I'm puzzled a little bit with this:

čec 28 10:57:18 butterfly thinkfan[162228]: ERROR: /etc/thinkfan.conf:1: Invalid syntax:
                                             sensors:
                                             ^

Why?

I've updated to the new release, 1.2. Thank you to the guy who flagged it as out of date and brought this to my attention.

You can see the changelog here: https://github.com/vmatare/thinkfan/releases/tag/1.2

Most importantly, the old syntax is now deprecated, so you may have to update your config file to the new YAML based syntax.

@dude yep, the examples where great help, thanks!

@SaberJ64 It looks like you have /usr/lib/modprobe.d/thinkpad_acpi.conf mixed up with /etc/thinkfan.conf. For thinkfan.conf, check /usr/share/doc/thinkfan/examples/.

@anthezium I install package in manjaro for my T440p, can't make it work due to a syntax error. I'm a newcomer to linux in general but if someone can point what I did wrong, I'd be more than glad

" options thinkpad_acpi fan_control=1 "

when I make the /etc/thinkfan.conf file it asks for it spits out an error...

thinkfan

ERROR: /etc/thinkfan.conf:1: Invalid syntax: options thinkpad_acpi fan_control=1 ^

thanks @dude, i have no idea how that happened. running arch. installing pkgconf solved it!

@anthezium This is just a guess, but your output says you don't have pkgconfig installed. I'm not sure why, since it's part of core. Are you running Arch or Manjaro? Could pkgconfig be the reason for the build failure? Try installing that and let me know if it fixes the issue. Thanks

Hey, when I try to build this it fails to find yaml-cpp (same for thinkfan-git). Any ideas?

0 theod@beor:~$ yay -S thinkfan
:: There are 2 providers available for thinkfan:
:: Repository AUR
    1) thinkfan 2) thinkfan-git

Enter a number (default=1): 1
:: Checking for conflicts...
:: Checking for inner conflicts...
[Aur: 1]  thinkfan-1.0.2-2

  1 thinkfan                                 (Build Files Exist)
==> Packages to cleanBuild?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> A
:: Deleting (1/1): /home/theod/.cache/yay/thinkfan
:: Downloaded PKGBUILD (1/1): thinkfan
  1 thinkfan                                 (Build Files Exist)
==> Diffs to show?
==> [N]one [A]ll [Ab]ort [I]nstalled [No]tInstalled or (1 2 3, 1-3, ^4)
==> N
:: Parsing SRCINFO (1/1): thinkfan
==> Making package: thinkfan 1.0.2-2 (Thu 02 Apr 2020 04:30:12 PM PDT)
==> Retrieving sources...
  -> Downloading thinkfan-1.0.2.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   123  100   123    0     0    675      0 --:--:-- --:--:-- --:--:--   675
100 77653    0 77653    0     0   157k      0 --:--:-- --:--:-- --:--:--  157k
  -> Found thinkfan.service
  -> Found thinkpad_acpi.conf
==> Validating source files with sha256sums...
    thinkfan-1.0.2.tar.gz ... Passed
    thinkfan.service ... Passed
    thinkpad_acpi.conf ... Passed
==> Making package: thinkfan 1.0.2-2 (Thu 02 Apr 2020 04:30:15 PM PDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
  -> Found thinkfan-1.0.2.tar.gz
  -> Found thinkfan.service
  -> Found thinkpad_acpi.conf
==> Validating source files with sha256sums...
    thinkfan-1.0.2.tar.gz ... Passed
    thinkfan.service ... Passed
    thinkpad_acpi.conf ... Passed
==> Removing existing $srcdir/ directory...
==> Extracting sources...
  -> Extracting thinkfan-1.0.2.tar.gz with bsdtar
==> Sources are ready.
==> Making package: thinkfan 1.0.2-2 (Thu 02 Apr 2020 04:30:19 PM PDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Starting build()...
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
CMake Error at CMakeLists.txt:59 (message):
  USE_YAML enabled but yaml-cpp not found.  Please install yaml-cpp[-devel]!


-- Configuring incomplete, errors occurred!
See also "/home/theod/.cache/yay/thinkfan/src/thinkfan-1.0.2/CMakeFiles/CMakeOutput.log".
==> ERROR: A failure occurred in build().
    Aborting...
Error making: thinkfan
1 theod@beor:~$ sudo pacman -S yaml-cpp
warning: yaml-cpp-0.6.3-2 is up to date -- reinstalling

A full upgrade + reinstalling thinkfan resolved the "undefined symbol" issue. Thanks jodizzle!

got it to work thanks!

Not sure why you are getting that error. If you clone the package repository, you can see thinkfan.install is present. Which directory are you running makepkg from?

Getting the following error:

makepkg -p thinkfan ==> ERROR: install file (thinkfan.install) does not exist or is not a regular file.

To anyone else having problems after a recent update: You may need to recompile. After installing yaml-cpp 0.6.3-1, I was getting this error:

/usr/bin/thinkfan: symbol lookup error: /usr/bin/thinkfan: undefined symbol: _ZN4YAML6detail9node_data12empty_scalarB5cxx11E

Recompiling and reinstalling thinkfan fixed the issue.

Package has been updated to include the fix for the bug discussed below.

With pacman-git, the problem doesn’t occur on my system, so it seems to be fixed on the master branch.

@xiliyi I noticed that. As this package only tracks official releases though, I will wait for the new version. In the meantime, you can help test the fix using the thinkfan-git package, which pulls from the git master branch.

The developer responded to the issue on github.

@helirexi and anyone else having the 100% CPU issue: please see the GitHub issue referenced below and provide the software maintainer with any relevant info in order to help him fix it. I am not involved with the development of this software, I just packaged the latest version that they released.

https://github.com/vmatare/thinkfan/issues/60

I was faced same problem, eat 100% of one core, and rise temp up to 70C. Just downgrade to 0.9.3 version "solved" this issue. my arch all up-to-date. Now just add this package to Ignored in pacman. I have Lenovo Thinkpad T61 if this help.

@xiliyi Thanks for letting me know. The owner of the project has completely rewritten the software and it seems that certain systems are having problems with the new implementation. I don't believe it is a packaging issue, but if you find a problem with the PKGBUILD please let me know and I will fix it ASAP.

@dude I believe I’m facing the same problem as @nfishr. Changing the line and rebuilding as suggested here (https://github.com/vmatare/thinkfan/issues/60) did not resolve the issue, CPU load is still at 100% (although this hits only one core, with or without the changed source).

@nfishr It's very simple, there's only a single line of code that needs to be changed. Check the wiki if you don't know how to build packages manually.

@dude I was able to get rid of the log-warning by adding values to the thinkfan.conf, but the CPU-Load is still 100%. That issue from Github looks interesting, although I'm not sure how I would go about implementing it. Thanks though

@nfishr That Sensor warning looks somewhat suspicious to me. Sounds like it could be a config issue. I would also recommend taking a look at the issues on github, this one in particular:

https://github.com/vmatare/thinkfan/issues/60

@dude unfortunately nothing suspicious in the logs:

Feb 18 23:26:08 host systemd[1]: Starting simple and lightweight fan control program... Feb 18 23:26:08 host thinkfan[642]: Daemon PID: 646 Feb 18 23:26:08 host systemd[1]: Started simple and lightweight fan control program. Feb 18 23:26:08 host thinkfan[646]: WARNING: Sensor /proc/acpi/ibm/thermal has 16 temperatures, but you have 10 correction values for it. Feb 18 23:27:08 host systemd[1]: thinkfan.service: Main process exited, code=killed, status=9/KILL Feb 18 23:27:08 host systemd[1]: thinkfan.service: Failed with result 'signal'.

thinkfan.conf:

tp_fan /proc/acpi/ibm/fan tp_thermal /proc/acpi/ibm/thermal (0, 10, 15, 2, 10, 5, 0, 3, 0, 3)

(0, 0, 50) (1, 47, 55) (2, 50, 61) (3, 52, 63) (4, 56, 65) (5, 59, 66) (7, 63, 32767)

@nfishr I haven't had this issue. Can you post your configuration and recent journald log entries for thinkfan?

just updated via this package to thinkfan 1.0.1 - VERY DANGEROUS: uses 100% CPU-Load when running. Could easily burn your CPU if not saved by BIOS!

I've just adopted this and updated it to v1.0.1. Please let me know if you run into any issues. Thanks

We should update thinkfan.service from

ExecStart=/usr/bin/thinkfan

to

ExecStart=/usr/bin/thinkfan -n

instead. This prevents thinkfan from starting as a deamon and allows us to debug it with journalctl -u thinkfan.