Arch Linux User Repository

Thanks for the work maintaining this very usefull PKGBUILD. If everyone votes for it, maybe one day could be an official Arch package.

Here are some issues that still need to be polished in this PKGBUILD. Some were already mentioned in the previous comments. Please read them and pay attention. If you need help, just ask.

POINT NR.1: unnecessary dependencies

Dependencies (5)
  • bash-completion (bash-completion-git^AUR)

10 depends=('glibc' 'libinih' 'bash-completion' 'lua')

You dont have to and should not force the "bash-completion" official package as a dependency. This was already mentioned earlier.

Sacro commented on 2023-08-06 13:12 (UTC)
Please don't depend on bash-completion, not everyone has or uses bash.
Also no need to depend on glibc, it's part of the base system.

Perhaps you are confusing "bash-completion" the package, that is the tool or machinery, with the location,

/usr/share/bash-completion/completions/

Do

pacman -Qo usr/share/bash-completion/completions/

to see who "owns" it.

And thats the only thing you need to take care. That a folder "/usr/share/bash-completion/completions" exists (which is true in 99.99 %) of all Arch systems. And that you put the file "tio" there.

This is usually a simple copy operation with "install", something like

  install -Dm644 "${_output}/bash" "${pkgdir}/usr/share/bash-completion/completions/XXXXX "

I dont know how "meson" works,

22   cd "$srcdir/$pkgname-$pkgver"
23   meson install -C build --destdir "$pkgdir"

But if you need help, just ask and somebody will help you.

In any case remember that you are not supposed to follow blindly the developers Makefile, or meson, or installation instructions. They are general Linux installation procedures. They are to be adapted to the Archlinux guidelines if and when necessary.

POINT NR. 2 - Readme, NEWS, and examples

This is the only thing that this PKGBUILD currently stuffs in the user system.

$ pacman -Ql tio

tio /usr/bin/tio
tio /usr/share/bash-completion/completions/tio
tio /usr/share/man/man1/tio.1.gz

However,

$ wget https://github.com/tio/tio/releases/download/v2.8/tio-2.8.tar.xz

$ tar tf tio-2.8.tar.xz

......
......
tio-2.8/NEWS
tio-2.8/README.md
tio-2.8/example/
tio-2.8/example/config
tio-2.8/example/control-lines-test.lua
......
......


Those files are usefull to have on the system. That NEWS file is super
important and well written to keep up with things and changes. There is no
reason for them to go to the trash. They should end up in something like,

/usr/share/doc/tio/README.md /usr/share/doc/tio/NEWS /usr/share/doc/tio/example/...

Again a simple copy operation like for ex,

  install -Dm644 "XYZ..." "${pkgdir}/usr/share/doc/tio/XYZ..."

POINT NR3: URL

As already mentioned, it is not,

 Upstream URL:   http://tio.github.io/

It is https://tio.github.io/

Or, in my opinion better, https://github.com/tio/tio since there is nothing to see in the "github.io" page.

Thanks in advance.

Thanks for reporting @ocelotsloth.

GPL-2.0-or-later change from GPL-2.0-only happened on 3f29bce (Apr 24, 2016. First tagged in v1.3)

The license in this package isn't quite correct. It should be the SPDX identifier GPL-2.0-or-later https://github.com/tio/tio/blob/master/LICENSE

Upstream URL:   http://tio.github.io/

Should be corrected. Both 'http' to https' now redirect to 'https://github.com/tio/tio'

Please don't depend on bash-completion, not everyone has or uses bash.

Also no need to depend on glibc, it's part of the base system.

I get the same message as @graysky when building on x86_64 (which builds fine) so that's not an error and cmake isn't required either.

The Meson build system
Version: 0.64.0
Source dir: /build/tio/src/tio-2.3
Build dir: /build/tio/src/tio-2.3/build
Build type: native build
Project name: tio
Project version: 2.3
C compiler for the host machine: cc (gcc 12.2.0 "cc (GCC) 12.2.0")
C linker for the host machine: cc ld.bfd 2.39.0
Host machine cpu family: x86_64
Host machine cpu: x86_64
...
Configuring config.h using configuration
Found pkg-config: /usr/bin/pkg-config (1.8.0)
Run-time dependency inih found: YES 56
Configuring tio using configuration
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency bash-completion found: NO (tried pkgconfig and cmake)
Configuring tio.1 using configuration
Build targets in project: 1

tio 2.3

  User defined options
    buildtype: plain
    prefix   : /usr

Found ninja-1.11.1 at /usr/bin/ninja

@jhenson, cmake would ve wrong as well...

@nickoe, shouldn't bash-completion be listed as as optdepends and/or a makedepends? A hard dependency seems like the wrong approach as not everyone uses bash as their shell.

@graysky, I have resolved the issue and pushed a more appropriate fix.

@nickoe - Not on x86_64 but on aarch64 (Arch ARM):

...
Configuring tio using configuration
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency bash-completion found: NO (tried pkgconfig and cmake)
Configuring tio.1 using configuration
Build targets in project: 1