Arch Linux User Repository

@prurigro could you try to update the PKGBUILD to use the system's electron in the same way as upscayl-rpm-bin? Like @aliu pointed out, you don't need to rebuild the exec since it's already included in the binaries. See https://wiki.archlinux.org/title/Electron_package_guidelines for reference.

Hi @prurigro, how goes the electrons?

Hi @prurigro, how goes the electrons?

@prurigro Sorry for the delay. You can check out upscayl-rpm-bin 's PKGBUILD on native electron. I'd recommend bundling the exec file instead of creating it at run-time though.

@aliu: Sorry for the delay- I was camping and didn't have reception.

You're right, it seems like namcap changed its output and I assumed the warnings were actual dependency issues. I went through and double checked your list and the only thing that seemed like it might be missing is libvips (unless you ruled that out for some reason?). I also noticed that nodejs is in there, but I'm not sure if that's just a build time thing? I've included it for now but let me know if you think it isn't necessary.

I attempted to get the package running with native electron, but it was giving me missing module errors. I suspect it needed the compiled extensions to be rebuilt against the system electron like the wiki article suggests, but this is a binary package so I checked to see what slack-desktop (another binary electron package) does, and it just includes the built-in copy of electron. I'm gonna leave this for now (including the nss dependency).

@bionade24: Hey, great idea- I updated the prepare function with your suggestion and added you to the list of contributors at the top of the PKGBUILD. Thanks!

You can use /usr/bin/unzip upscayl-${pkgver}-linux.zip -x icon_128x128.png -d upscayl to save most commands in the prepare() section.

GTK3 covers at-spi2-core (which covers dbus which covers expat), cairo (which covers libxcb), glib2, libcups, libx11, libxcomposite, libxdamage, libxext, libxfixes, libxkbcommon, libxrandr, mesa (through libglvnd and also covers libdrm and vulkan-icd-loader), pango
nss covers nspr
I don't have unzip installed yet I have 2.8.0-1 installed

I'm not sure what we need bash for and it's included in base
gcc-libs, glibc are also included in base

So in conclusion we only need to include GTK3, openjpeg2, libasound.so and nss (if we don't do electron) as dependencies

Side note: electron requires nss. This is an electron package which is typically ran through native electron and the binaries' resources folder according to Electron package guidelines on the archwiki

Also, thanks for updating so fast!

Hmm, that collection of deps is what namcap suggested, and usually it calls out dependencies that are provided by other dependencies you've included, have you run down the dependency chain to confirm any of those are provided?

Good catch on the missing openjpeg2 dependency- I've added that one.

Thanks! However, I don’t think you need to add all of these dependencies, just adding gtk3 and openjpeg2 (which was not included for some reason) would make pacman automatically get the dependencies; we shouldn’t take care of that. alsa should also be replaced with libasound.so as alsa merely provides it. I’m also not sure about the upscayl-run approach which is essentially a complicated symlink, maybe you could take a look at upscayl-rpm-bin’s approach?

@aliu: Thanks again! I've updated the package and included you in the credits. Everything seems to run correctly for me, but let me know if you see anything amiss.