Package Details: vscodium-bin-marketplace 1.56.0-7

Git Clone URL: https://aur.archlinux.org/vscodium-bin-marketplace.git (read-only, click to copy)
Package Base: vscodium-bin-marketplace
Description: Enable vscode marketplace in vscodium-bin
Upstream URL: https://marketplace.visualstudio.com/vscode
Licenses: unknown
Submitter: sperg512
Maintainer: Icelk
Last Packager: Icelk
Votes: 24
Popularity: 2.23
First Submitted: 2020-12-04 13:48 (UTC)
Last Updated: 2022-05-03 17:05 (UTC)

Dependencies (2)

Required by (0)

Sources (2)

Latest Comments

Icelk commented on 2022-08-02 09:36 (UTC)

This package should not be marked as out of date unless it stops working. If that's the case, proving a diff to get it working is hugely appreciated.

Icelk commented on 2022-05-03 17:06 (UTC)

@70m4c Thanks!

70m4c commented on 2022-05-02 21:01 (UTC)

The packages vscodium-bin and sed are run-time dependencies and not necessary for building. You should consider moving the entire line depends=('vscodium-bin' 'sed') into package() like this:

package() {
  depends=('vscodium-bin' 'sed')
  . . .
}

That would make it possible to build this package without vscodium-bin or sed installed, which is helpful in some situations. Please see the first two sentences in this section of the Arch Wiki: https://wiki.archlinux.org/title/PKGBUILD#depends

Icelk commented on 2022-04-22 10:43 (UTC)

@silvan_rehm I just tried to reproduce, and got no error when installing fresh.

Icelk commented on 2022-04-22 05:36 (UTC)

@silvan_rehm, your issue seems weird. Since we only replace lines with content, and don’t change parentheses, the original package.json sort of has to be bad. I’ll investigate more later.

Icelk commented on 2022-04-22 03:34 (UTC)

Thanks!

sperg512 commented on 2022-04-21 23:59 (UTC)

Yeah I'm generally not available anymore. At FRC worlds rn, and switched to Gentoo. You're a co maintainer, I'll disown now.

Icelk commented on 2022-04-21 16:25 (UTC)

I’d appreciate if you could provide a diff to the patch.sh file. I was added as a maintainer for my auto update script to vscodium-bin. sperg512 seems to be gone. This package should maybe be marked as an orphan?

silvan_rehm commented on 2022-04-21 06:51 (UTC) (edited on 2022-04-21 06:52 (UTC) by silvan_rehm)

after updating got the following error:

vscodium                                                                                                           [1]
node:internal/modules/cjs/loader:1186
    throw err;
    ^
SyntaxError: /opt/vscodium-bin/resources/app/product.json: Unexpected token , in JSON at position 13940

needed to remove two } in the products.json:

diff product.json product.jsonBU                                                                 
137,138c137
<   
<   ,
---
>   },
156c155
<   ,
---
>   },
295c294
< }
---
> }
\ No newline at end of file

Icelk commented on 2022-01-15 11:04 (UTC)

Btw, this package is only updated when vscodium-bin contains breaking changes to the relevant files.

Icelk commented on 2022-01-15 11:03 (UTC)

I just tried to install this and the latest vscodium-bin and it worked.

The checksums worked.

Can you share the details of your problems, and steps on how to reproduce?

silverhikari commented on 2021-12-22 18:42 (UTC) (edited on 2021-12-22 18:43 (UTC) by silverhikari)

i do not know if this is intentional but when installing the newer version this message appears "/tmp/alpm_98q6wT/.INSTALL: line 6: /opt/vscodium-bin/resources/app/patch.sh: No such file or directory" "error: command failed to execute correctly" but it will continue to install the package

devourerOfBits80 commented on 2021-12-22 10:34 (UTC)

You can always install this package directly, skipping the integrity checking... yay -S --mflags --skipinteg vscodium-bin-marketplace.

Regards,

Mek101 commented on 2021-12-22 09:40 (UTC)

Both the patch and the hook fail the md5sum validation in 1.56.0-5

ddd commented on 2021-12-21 18:09 (UTC)

thanks for the usr/share->opt change, but you forgot to change the hook's checksum :)

wooque commented on 2021-12-21 12:17 (UTC)

patch for new vscodium-bin

diff --git a/.SRCINFO b/.SRCINFO
index d368ee8..78a3a11 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -10,8 +10,8 @@ pkgbase = vscodium-bin-marketplace
    depends = sed
    source = vscodium-bin-marketplace.hook
    source = patch.sh
-   md5sums = c021871847b6b57c373285243c155927
-   md5sums = 9953b36f67bee0466c28a07e1faf090e
+   md5sums = db795d7715e861919909e2fd726f6fed
+   md5sums = 5fa388d4430e1767eb9d58930c8ba9c0

 pkgname = vscodium-bin-marketplace

diff --git a/PKGBUILD b/PKGBUILD
index f9af131..028a1fb 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,7 +3,7 @@

 pkgname=vscodium-bin-marketplace
 pkgver=1.56.0
-pkgrel=4
+pkgrel=5
 pkgdesc='Enable vscode marketplace in vscodium-bin'
 arch=('any')
 url='https://marketplace.visualstudio.com/vscode'
@@ -12,10 +12,10 @@ depends=('vscodium-bin' 'sed')
 install="${pkgname}.install"
 source=('vscodium-bin-marketplace.hook'
         'patch.sh')
-md5sums=('c021871847b6b57c373285243c155927'
-         '9953b36f67bee0466c28a07e1faf090e')
+md5sums=('db795d7715e861919909e2fd726f6fed'
+         '5fa388d4430e1767eb9d58930c8ba9c0')
 package() {
   install -Dm 644 "${srcdir}"/vscodium-bin-marketplace.hook "${pkgdir}"/usr/share/libalpm/hooks/vscodium-bin-marketplace.hook
-  install -Dm 755 "${srcdir}"/patch.sh "${pkgdir}"/usr/share/vscodium-bin/resources/app/patch.sh
+  install -Dm 755 "${srcdir}"/patch.sh "${pkgdir}"/opt/vscodium-bin/resources/app/patch.sh
 }

diff --git a/patch.sh b/patch.sh
index 2301516..5b2a14c 100755
--- a/patch.sh
+++ b/patch.sh
@@ -6,12 +6,12 @@ if [ "${1}" = "-R" ]; then
     -e 's/^[[:blank:]]*"itemUrl":.*/    "itemUrl": "https:\/\/open-vsx.org\/vscode\/item"/' \
     -e '/^[[:blank:]]*"linkProtectionTrustedDomains/d' \
     -e '/^[[:blank:]]*"documentationUrl/i\  "linkProtectionTrustedDomains": ["https://open-vsx.org"],' \
-    /usr/share/vscodium-bin/resources/app/product.json
+    /opt/vscodium-bin/resources/app/product.json
 else
   sed -i -e 's/^[[:blank:]]*"serviceUrl":.*/    "serviceUrl": "https:\/\/marketplace.visualstudio.com\/_apis\/public\/gallery",/' \
     -e '/^[[:blank:]]*"cacheUrl/d' \
     -e '/^[[:blank:]]*"serviceUrl/a\    "cacheUrl": "https:\/\/vscode.blob.core.windows.net\/gallery\/index",' \
     -e 's/^[[:blank:]]*"itemUrl":.*/    "itemUrl": "https:\/\/marketplace.visualstudio.com\/items"/' \
     -e '/^[[:blank:]]*"linkProtectionTrustedDomains/d' \
-    /usr/share/vscodium-bin/resources/app/product.json
+    /opt/vscodium-bin/resources/app/product.json
 fi
diff --git a/vscodium-bin-marketplace.hook b/vscodium-bin-marketplace.hook
index bdc7cd9..8171f94 100644
--- a/vscodium-bin-marketplace.hook
+++ b/vscodium-bin-marketplace.hook
@@ -6,5 +6,5 @@ Target = vscodium-bin

 [Action]
 Description = [vscodium-bin-marketplace] Patching product.json...
-Exec = /usr/share/vscodium-bin/resources/app/patch.sh
+Exec = /opt/vscodium-bin/resources/app/patch.sh
 When = PostTransaction
diff --git a/vscodium-bin-marketplace.install b/vscodium-bin-marketplace.install
index 134c4e6..18253c7 100644
--- a/vscodium-bin-marketplace.install
+++ b/vscodium-bin-marketplace.install
@@ -1,15 +1,15 @@
 post_install() {
-  /usr/share/vscodium-bin/resources/app/patch.sh
+  /opt/vscodium-bin/resources/app/patch.sh
 }

 pre_upgrade() {
-  /usr/share/vscodium-bin/resources/app/patch.sh -R
+  /opt/vscodium-bin/resources/app/patch.sh -R
 }

 post_upgrade() {
-  /usr/share/vscodium-bin/resources/app/patch.sh
+  /opt/vscodium-bin/resources/app/patch.sh
 }

 pre_remove() {
-  /usr/share/vscodium-bin/resources/app/patch.sh -R
+  /opt/vscodium-bin/resources/app/patch.sh -R
 }

ZorinArch commented on 2021-12-21 09:22 (UTC)

get this error

sed: can't read /usr/share/vscodium-bin/resources/app/product.json: No such file or directory
error: command failed to execute correctly

sperg512 commented on 2021-05-10 18:01 (UTC)

sorry for spamming releases but I think i've solved the problem where the package doesn't work

doesn't need to be updated with the package anymore as now the hook actually works

@sainnhe I got it working, there's now a vscodium-bin-features package. Not sure if the feature adding works because idk how to test but yeah

sperg512 commented on 2021-05-10 17:18 (UTC)

ok fixed, in the future if this happens just updpkgsums

@GeBo thats what this package has always done, same with code-marketplace.

GeBo commented on 2021-05-10 13:15 (UTC) (edited on 2021-05-10 13:27 (UTC) by GeBo)

I get the same error as ewertoni. md5sum of product.json.patch does not match.

When I open the patch, I see that https://open-vsx.org/ is being replaced by https://marketplace.visualstudio.com/ with a cache to https://vscode.blob.core.windows.net/.

ewertonl commented on 2021-05-10 11:11 (UTC)

I'm getting this when trying to install

==> Validating source files with md5sums...
    vscodium-bin-marketplace.hook ... Passed
    product.json.patch ... FAILED
==> ERROR: One or more files did not pass the validity check!
Failed to build vscodium-bin-marketplace

sperg512 commented on 2021-04-16 14:10 (UTC) (edited on 2021-04-16 14:10 (UTC) by sperg512)

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaAAAAAAAAAAAAA

@macxcool can you try the following:

  • reinstall vscodium-bin

  • get your product.json (/usr/share/vscodium-bin/app/resources/product.json) and save it to another file

  • reinstall vscodium-bin-marketplace

  • attach the error that occurs and the product.json file

thanks

macxcool commented on 2021-04-15 14:36 (UTC)

Still getting:

patching file /usr/share/vscodium-bin/resources/app/product.json
Hunk #1 FAILED at 140.
1 out of 3 hunks FAILED -- saving rejects to file /usr/share/vscodium- 
bin/resources/app/product.json.rej
error: command failed to execute correctly

sperg512 commented on 2021-04-14 18:37 (UTC)

@macxcool fixed

@sainnhe alright, I'll look at that later. Thanks

macxcool commented on 2021-04-12 23:04 (UTC) (edited on 2021-04-12 23:08 (UTC) by macxcool)

I get this on upgrading:

patching file /usr/share/vscodium-bin/resources/app/product.json
Unreversed patch detected!  Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file /usr/share/vscodium- 
bin/resources/app/product.json.rej
error: command failed to execute correctly

If you want to see my product.json, it's here: https://pastebin.com/WM9QvzDG

sainnhe commented on 2021-04-06 09:32 (UTC)

I just tried to get settings sync work on vscodium by git apply this patch to code-features, but unfortunately the sync failed in vscodium (it works nicely in code oss). I'm not sure what happened, you can get it a try.

diff --git a/.SRCINFO b/.SRCINFO
index 6470334..d7d029c 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -14,8 +14,8 @@ pkgbase = code-features
    conflicts = code-features
    source = code-features.hook
    source = patch.sh
-   md5sums = 5d5bd889095a60ffbf1918d5a2a08bdb
-   md5sums = 5af300de3e3efbfd071425b832c83313
+   md5sums = c7060228752c46d4e0126cdd4a68ce01
+   md5sums = 4d53ee04925c53e27922a5f8fdaa524f

 pkgname = code-features

diff --git a/PKGBUILD b/PKGBUILD
index a514419..a886e6c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -14,8 +14,8 @@ conflicts=('code-features')
 install="${pkgname}.install"
 source=("${pkgname}.hook"
         'patch.sh')
-md5sums=('5d5bd889095a60ffbf1918d5a2a08bdb'
-         '5af300de3e3efbfd071425b832c83313')
+md5sums=('c7060228752c46d4e0126cdd4a68ce01'
+         '4d53ee04925c53e27922a5f8fdaa524f')

 package() {
   install -Dm 644 "${srcdir}/${pkgname}.hook" "${pkgdir}/usr/share/libalpm/hooks/${pkgname}.hook"
diff --git a/code-features.hook b/code-features.hook
index cb5e790..ffd1e44 100644
--- a/code-features.hook
+++ b/code-features.hook
@@ -3,6 +3,7 @@ Operation = Install
 Operation = Upgrade
 Type = Path
 Target = usr/lib/code/product.json
+Target = usr/share/vscodium-bin/resources/app/product.json

 [Action]
 Description = [code-features] Patching product.json...
diff --git a/patch.sh b/patch.sh
index 3adeea2..ebb86bc 100755
--- a/patch.sh
+++ b/patch.sh
@@ -1,14 +1,34 @@
 #!/usr/bin/env sh

 if [ "${1}" = "-R" ]; then
-  sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Code - OSS",/' \
-    -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.github-browser", "ms-vscode.github-richnav"],/' \
-    -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
-    /usr/lib/code/product.json
+   if [ -f /usr/lib/code/product.json ]; then
+       sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Code - OSS",/' \
+           -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.github-browser", "ms-vscode.github-richnav"],/' \
+           -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
+           /usr/lib/code/product.json
+   fi
+   if [ -f /usr/share/vscodium-bin/resources/app/product.json ]; then
+       sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "VSCodium",/' \
+           -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.remotehub", "ms-vscode.remotehub-insiders", "ms-vsliveshare.vsliveshare", "ms-vscode-remote.remote-ssh", "ms-vscode.cpptools", "ms-azuretools.vscode-docker", "visualstudioexptteam.vscodeintellicode", "ms-python.python"],/' \
+           -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
+           -e '/^[[:blank:]]*"linkProtectionTrustedDomains/d' \
+           -e '/^[[:blank:]]*"serverDataFolderName/i\\t"linkProtectionTrustedDomains": ["https://open-vsx.org"],' \
+           /usr/share/vscodium-bin/resources/app/product.json
+   fi
 else
-  sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Visual Studio Code",/' \
-    -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["GitHub.codespaces", "GitHub.vscode-pull-request-github-insiders", "GitHub.vscode-pull-request-github", "Microsoft.vscode-nmake-tools", "ms-ai-tools.notebook-renderers", "ms-dotnettools.dotnet-interactive-vscode", "ms-python.gather", "ms-python.python", "ms-toolsai.jupyter", "ms-toolsai.vscode-ai", "ms-toolsai.vscode-ai-remote", "ms-vscode-remote.remote-containers-nightly", "ms-vscode-remote.remote-containers", "ms-vscode-remote.remote-ssh-edit-nightly", "ms-vscode-remote.remote-ssh-edit", "ms-vscode-remote.remote-ssh-nightly", "ms-vscode-remote.remote-ssh", "ms-vscode-remote.remote-wsl-nightly", "ms-vscode-remote.remote-wsl", "ms-vscode-remote.remote-wsl-recommender", "ms-vscode-remote.vscode-remote-extensionpack-nightly", "ms-vscode-remote.vscode-remote-extensionpack", "ms-vscode.azure-account", "ms-vscode.azure-sphere-tools-ui", "ms-vscode.azure-sphere-tools", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.js-debug-nightly", "ms-vscode.js-debug", "ms-vscode.lsif-browser", "ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.vscode-selfhost-test-provider", "ms-vsliveshare.cloudenv-explorer", "ms-vsliveshare.cloudenv", "ms-vsliveshare.vsliveshare", "ms-vsonline.vsonline", "dbaeumer.vscode-eslint"],/' \
-    -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
-    -e '/^[[:blank:]]*"extensionAllowedProposedApi/a\\t"extensionSyncedKeys": { "ritwickdey.liveserver": ["liveServer.setup.version"] }, "linkProtectionTrustedDomains": ["https:\/\/*.visualstudio.com", "https:\/\/*.microsoft.com", "https:\/\/aka.ms", "https:\/\/vscode-auth.github.com", "https:\/\/*.gallerycdn.vsassets.io", "https:\/\/github.com\/microsoft\/", "https:\/\/github.com\/MicrosoftDocs\/", "https:\/\/login.microsoftonline.com"], "auth": { "loginUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/authorize", "tokenUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/token", "redirectUrl": "https:\/\/vscode-redirect.azurewebsites.net\/", "clientId": "aebc6443-996d-45c2-90f0-388ff96faa56" }, "configurationSync.store": { "url": "https:\/\/vscode-sync.trafficmanager.net\/", "stableUrl": "https:\/\/vscode-sync.trafficmanager.net\/", "insidersUrl": "https:\/\/vscode-sync-insiders.trafficmanager.net\/", "canSwitch": false, "authenticationProviders": { "microsoft": { "scopes": ["https:\/\/management.core.windows.net\/.default", "offline_access"] }, "github": { "scopes": ["user:email"] } } },' \
-    /usr/lib/code/product.json
+   if [ -f /usr/lib/code/product.json ]; then
+       sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Visual Studio Code",/' \
+           -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["GitHub.codespaces", "GitHub.vscode-pull-request-github-insiders", "GitHub.vscode-pull-request-github", "Microsoft.vscode-nmake-tools", "ms-ai-tools.notebook-renderers", "ms-dotnettools.dotnet-interactive-vscode", "ms-python.gather", "ms-python.python", "ms-toolsai.jupyter", "ms-toolsai.vscode-ai", "ms-toolsai.vscode-ai-remote", "ms-vscode-remote.remote-containers-nightly", "ms-vscode-remote.remote-containers", "ms-vscode-remote.remote-ssh-edit-nightly", "ms-vscode-remote.remote-ssh-edit", "ms-vscode-remote.remote-ssh-nightly", "ms-vscode-remote.remote-ssh", "ms-vscode-remote.remote-wsl-nightly", "ms-vscode-remote.remote-wsl", "ms-vscode-remote.remote-wsl-recommender", "ms-vscode-remote.vscode-remote-extensionpack-nightly", "ms-vscode-remote.vscode-remote-extensionpack", "ms-vscode.azure-account", "ms-vscode.azure-sphere-tools-ui", "ms-vscode.azure-sphere-tools", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.js-debug-nightly", "ms-vscode.js-debug", "ms-vscode.lsif-browser", "ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.vscode-selfhost-test-provider", "ms-vsliveshare.cloudenv-explorer", "ms-vsliveshare.cloudenv", "ms-vsliveshare.vsliveshare", "ms-vsonline.vsonline", "dbaeumer.vscode-eslint"],/' \
+           -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
+           -e '/^[[:blank:]]*"extensionAllowedProposedApi/a\\t"extensionSyncedKeys": { "ritwickdey.liveserver": ["liveServer.setup.version"] }, "linkProtectionTrustedDomains": ["https:\/\/*.visualstudio.com", "https:\/\/*.microsoft.com", "https:\/\/aka.ms", "https:\/\/vscode-auth.github.com", "https:\/\/*.gallerycdn.vsassets.io", "https:\/\/github.com\/microsoft\/", "https:\/\/github.com\/MicrosoftDocs\/", "https:\/\/login.microsoftonline.com"], "auth": { "loginUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/authorize", "tokenUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/token", "redirectUrl": "https:\/\/vscode-redirect.azurewebsites.net\/", "clientId": "aebc6443-996d-45c2-90f0-388ff96faa56" }, "configurationSync.store": { "url": "https:\/\/vscode-sync.trafficmanager.net\/", "stableUrl": "https:\/\/vscode-sync.trafficmanager.net\/", "insidersUrl": "https:\/\/vscode-sync-insiders.trafficmanager.net\/", "canSwitch": false, "authenticationProviders": { "microsoft": { "scopes": ["https:\/\/management.core.windows.net\/.default", "offline_access"] }, "github": { "scopes": ["user:email"] } } },' \
+           /usr/lib/code/product.json
+   fi
+   if [ -f /usr/share/vscodium-bin/resources/app/product.json ]; then
+       sed -i -e 's/^[[:blank:]]*"nameLong":.*/\t"nameLong": "Visual Studio Code",/' \
+           -e 's/^[[:blank:]]*"extensionAllowedProposedApi":.*/\t"extensionAllowedProposedApi": ["GitHub.codespaces", "GitHub.vscode-pull-request-github-insiders", "GitHub.vscode-pull-request-github", "Microsoft.vscode-nmake-tools", "ms-ai-tools.notebook-renderers", "ms-dotnettools.dotnet-interactive-vscode", "ms-python.gather", "ms-python.python", "ms-toolsai.jupyter", "ms-toolsai.vscode-ai", "ms-toolsai.vscode-ai-remote", "ms-vscode-remote.remote-containers-nightly", "ms-vscode-remote.remote-containers", "ms-vscode-remote.remote-ssh-edit-nightly", "ms-vscode-remote.remote-ssh-edit", "ms-vscode-remote.remote-ssh-nightly", "ms-vscode-remote.remote-ssh", "ms-vscode-remote.remote-wsl-nightly", "ms-vscode-remote.remote-wsl", "ms-vscode-remote.remote-wsl-recommender", "ms-vscode-remote.vscode-remote-extensionpack-nightly", "ms-vscode-remote.vscode-remote-extensionpack", "ms-vscode.azure-account", "ms-vscode.azure-sphere-tools-ui", "ms-vscode.azure-sphere-tools", "ms-vscode.github-browser", "ms-vscode.github-richnav", "ms-vscode.js-debug-nightly", "ms-vscode.js-debug", "ms-vscode.lsif-browser", "ms-vscode.vscode-js-profile-flame", "ms-vscode.vscode-js-profile-table", "ms-vscode.vscode-selfhost-test-provider", "ms-vsliveshare.cloudenv-explorer", "ms-vsliveshare.cloudenv", "ms-vsliveshare.vsliveshare", "ms-vsonline.vsonline", "dbaeumer.vscode-eslint"],/' \
+           -e '/^[[:blank:]]*"extensionSyncedKeys/d' \
+           -e '/^[[:blank:]]*"extensionAllowedProposedApi/a\\t"extensionSyncedKeys": { "ritwickdey.liveserver": ["liveServer.setup.version"] }, "linkProtectionTrustedDomains": ["https:\/\/*.visualstudio.com", "https:\/\/*.microsoft.com", "https:\/\/aka.ms", "https:\/\/vscode-auth.github.com", "https:\/\/*.gallerycdn.vsassets.io", "https:\/\/github.com\/microsoft\/", "https:\/\/github.com\/MicrosoftDocs\/", "https:\/\/login.microsoftonline.com"], "auth": { "loginUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/authorize", "tokenUrl": "https:\/\/login.microsoftonline.com\/common\/oauth2\/token", "redirectUrl": "https:\/\/vscode-redirect.azurewebsites.net\/", "clientId": "aebc6443-996d-45c2-90f0-388ff96faa56" }, "configurationSync.store": { "url": "https:\/\/vscode-sync.trafficmanager.net\/", "stableUrl": "https:\/\/vscode-sync.trafficmanager.net\/", "insidersUrl": "https:\/\/vscode-sync-insiders.trafficmanager.net\/", "canSwitch": false, "authenticationProviders": { "microsoft": { "scopes": ["https:\/\/management.core.windows.net\/.default", "offline_access"] }, "github": { "scopes": ["user:email"] } } },' \
+           -e '/^[[:blank:]]*"linkProtectionTrustedDomains/d' \
+           /usr/share/vscodium-bin/resources/app/product.json
+   fi
 fi

sainnhe commented on 2021-04-06 09:01 (UTC)

Hello, I'm the maintainer of code-marketplace. I recently added support for blocked extensions like remote-ssh and pylance, and also the builtin settings sync. You can consider adding these features to your package, see the pinned comment here.

Since the patch file contains many parts that are changed frequently, I think it might be better to use sed instead of patch to modify product.json. You can consider changing your code, too.

Another thing is that, the support of blocked extensions and settings sync is actually done via tokens like extensionAllowedProposedApi and extensionSyncedKeys which are directly copied from visual-studio-code-bin and visual-studio-code-insiders-bin, but they might be changed frequently, and I can't guarantee to keep them always up to date, so can we maintain these packages together?

Since the newest version of code-marketplace and code-features(-insiders) uses shell script to implement the patching, I think it's possible to support both code oss and vscodium in one package by detecting the installation path, by doing so we can save a lot of work.

sperg512 commented on 2021-02-27 07:48 (UTC)

GOD DAMn it

@CoolGenie can you post your relevant product.json lines? search for extensionsGallery and post a couple (5 or so) lines before and after that line

CoolGenie commented on 2021-02-27 06:29 (UTC)

Hello, Again the patch error appears

patching file /usr/share/vscodium-bin/resources/app/product.json
Unreversed patch detected!  Ignore -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file /usr/share/vscodium-bin/resources/app/product.json.rej
error: command failed to execute correctly
(1/1) reinstalling vscodium-bin-marketplace                                                                                                                        [####################################################################################################] 100%
patching file /usr/share/vscodium-bin/resources/app/product.json
Hunk #1 succeeded at 137 with fuzz 2.
Hunk #2 succeeded at 152 with fuzz 2.

coxackie commented on 2021-02-11 10:07 (UTC)

@sperg512 indeed, now it seems ok. thanks.

sperg512 commented on 2021-02-10 21:18 (UTC)

@coxackie ok i believe i've fixed it, try it now

sperg512 commented on 2021-02-10 12:45 (UTC)

@coxackie actually, I think the product.json changed significantly. I just checked and it's the exact same as yours, though I'm not getting the same errors. Later today I'll get a fix out.

coxackie commented on 2021-02-10 11:13 (UTC)

@sperg512 If this issue happens only to me, feel free to unflag it from being out-of-date. It happened again with the 1.53.1 update. I don't know how it is possible that we get different product.json files...

coxackie commented on 2021-02-09 09:07 (UTC) (edited on 2021-02-09 09:07 (UTC) by coxackie)

My product.json starts with:

{
  "nameShort": "VSCodium",
  "nameLong": "VSCodium",
  "applicationName": "codium",
  "dataFolderName": ".vscode-oss",
  "win32MutexName": "vscodium",
  "licenseName": "MIT",
  "licenseUrl": "https://github.com/microsoft/vscode/blob/master/LICENSE.txt",
  "win32DirName": "VSCodium",
  "win32NameVersion": "VSCodium",

Lines 143-154 are

  "linkProtectionTrustedDomains": ["https://open-vsx.org"],
  "serverDataFolderName": ".vscode-server-oss",
  "commit": "8490d3dde47c57ba65ec40dd192d014fd2113496",
  "date": "2021-02-07T22:11:04.635Z",
  "checksums": {
    "vs/base/parts/sandbox/electron-browser/preload.js": "MUMCvm6iaIqaXHwrKp2iqw",
    "vs/workbench/workbench.desktop.main.js": "PEF0e60OlqpgNhUl8Tp8Mw",
    "vs/workbench/workbench.desktop.main.css": "BJFlGB2Mco0wkZ9J8NuHtg",
    "vs/workbench/services/extensions/node/extensionHostProcess.js": "v0mlOi9e/XiGfrdOxA7mYg",
    "vs/code/electron-browser/workbench/workbench.html": "FA7IN1fg7dReTGbMS997BQ",
    "vs/code/electron-browser/workbench/workbench.js": "i9bcRl/GLU9touwW05IMfA"
  }

I can change everything manually at this point, of course, but I do not understand how there is discrepancy from yours. I even did a complete clean install of vscodium-bin.

sperg512 commented on 2021-02-08 23:18 (UTC)

@coxackie interesting, what's in those lines in your product.json?

coxackie commented on 2021-02-08 23:12 (UTC)

After updating to 1.53.0, I get:

patching file /usr/share/vscodium-bin/resources/app/product.json
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 152 with fuzz 2.
1 out of 2 hunks FAILED -- saving rejects to file /usr/share/vscodium-bin/resources/app/product.json.rej
error: command failed to execute correctly

Here are the contents of /usr/share/vscodium-bin/resources/app/product.json.rej:

*** product.json  2020-12-03 19:59:40.000000000 -0500
--- product_new.json    2020-12-04 08:39:09.547338599 -0500
***************
*** 1,9 ****
  {
    "serverDataFolderName": ".vscode-server-oss",
-   "linkProtectionTrustedDomains": ["https://open-vsx.org"],
    "extensionsGallery": {
!     "itemUrl": "https://open-vsx.org/vscode/item",
!     "serviceUrl": "https://open-vsx.org/vscode/gallery"
    },
    "quality": "stable",
    "keyboardShortcutsUrlWin": "https://go.microsoft.com/fwlink/?linkid=832145",
--- 1,9 ----
  {
    "serverDataFolderName": ".vscode-server-oss",
    "extensionsGallery": {
!     "serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
!     "cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
!     "itemUrl": "https://marketplace.visualstudio.com/items"
    },
    "quality": "stable",
    "keyboardShortcutsUrlWin": "https://go.microsoft.com/fwlink/?linkid=832145",

sperg512 commented on 2021-02-08 21:36 (UTC)

@coxackie how does it fail for you? works for me currently

sperg512 commented on 2020-12-05 17:31 (UTC)

shit was gonna do that last night but forgot, thanks for reminding me

kruzah commented on 2020-12-05 13:53 (UTC)

Package currently depends on code, but should probably depend on vscodium-bin instead.