Package Details: xscreensaver-arch-logo 5.34-1

Git Clone URL: https://aur.archlinux.org/xscreensaver-arch-logo.git (read-only)
Package Base: xscreensaver-arch-logo
Description: Screen saver and locker for the X Window System with Arch Linux branding
Upstream URL: http://www.jwz.org/xscreensaver/
Licenses: BSD
Conflicts: xscreensaver
Provides: xscreensaver
Submitter: Harvie
Maintainer: graysky
Last Packager: graysky
Votes: 212
Popularity: 3.986020
First Submitted: 2009-05-19 16:57
Last Updated: 2015-10-27 17:51

Dependencies (10)

Required by (13)

Sources (7)

Latest Comments

graysky commented on 2015-10-27 17:51

Bump to v5.34-1

Changelog: http://www.jwz.org/xscreensaver/changelog.html

jwhendy commented on 2015-07-22 15:16

Filed (https://bugs.archlinux.org/task/45743), but I'm thinking removing it from the upstream package isn't the solution... If it's removed as a make depend and the user installs gdm, the extra functionality still won't work. I'm half debating deleting that ticket as I write this, as I don't see them ever removing it since the functionality requires to have gdm installed *and* having built with gdm.

This would require upstream to have two versions built with and without gdm. The current behavior is nice. Little impact on binary size, and just install gdm if you want to use the features.

The "true" mimicking of upstream behavior would be to build it with gdm and then uninstall it afterward. That's what the upstream behavior really is:
- post-install, it will spit out a message that gdm is optional, what it's functionality is, and whether or not you have it installed
- if you didn't have have it installed, you still don't have it installed

The AUR behavior installs it for make, but leaves it even if you didn't have it. What about a post_install action to remove gdm if you never had it to begin with? It would still download 31MB of undesired stuff, but at least it would clean up afterward?

jwhendy commented on 2015-07-22 14:58

Oh, and doh! Gotcha... I kept thinking upstream meant to jwz's xscreensaver. It probably *is* required for that functionality. I noticed that building without it will show the button, but clicking it just turns it to greyed out. Sorry for the confusion/miscommunication and I will submit a ticket.

graysky commented on 2015-07-21 08:41

Not upstream, just to our maintainers of the official package. Again, I thought it was in fact required as a makedep to compile in the change user dialog when locked.

jwhendy commented on 2015-07-21 01:59

@graysky: I understand, but what exactly would the ticket be? The complaint is that gdm isn't required as a makedepend, and it already isn't upstream, so I don't see what to request
- Upstream: if you happen to have it installed, xscreensaver will take that into account when running ./configure. If you don't, it won't. So... what's the upstream request?
- AUR package: you have to be aware that gdm isn't *really* a makedepend and manually remove it from the PKGBUILD vs. opting in by adding it.

It would seem that this package actually isn't matching the upstream behavior. I'm happy to submit a ticket, but this is why I checked the behavior myself. I'm glad I did as I would have felt foolish taking your word for the behavior, asking him to remove gdm as a build dependency, and then hearing back that he already doesn't.

Are we on the same page, or do you see things differently?

graysky commented on 2015-07-19 19:40

Bump to v5.33-1

Changelog: http://www.jwz.org/xscreensaver/changelog.html

graysky commented on 2015-07-19 19:38

As stated in the comment from 2014-11-16, please open a ticket against the official package. I try to keep this package as close to the official as possible.

jwhendy commented on 2015-07-19 17:31

I disagree that this is the upstream behavior. I was going to email Jamie per your 2014-11-16 comment but figured I'd verify the actual package first. I started with no intltool and no gdm installed (bc already installed for cups, and libxpm installed for a bunch of stuff). First error from running `./configure`:

-----
./configure: line 7151: intltool-update: command not found
checking for intltool-update... no
checking for intltool-merge... no
checking for intltool-extract... no
configure: error: The intltool scripts were not found. Please install intltool.
-----

Install intltool, then re-run ./configure... no errors, and compiles just fine. Storing the output of ./configure with and without gdm installed results in some slight differences, which tells me configure is simply *checking* if you have gdm, not assuming or forcing you to opt-in, as this AUR package does.

So... I would disagree that this is how the upstream package behaves, as in it fails/forces installation for intltool (a "true" makedepend) but does not for gdm. Thus, I think gdm should be opt-in. Mention it to the user in the package build or elsewhere (like the typical "Optional dependency for xxx: yyy" message when installing via pacman), but do not automatically include it since there's no need for it.

The current behavior, as already noted is unfortunate as it doesn't leave gdm flagged as un-needed. I only stumbled on all of this by accident when seeing a *ton* of gnome-sh*t in my pacman log that I didn't recall ever installing. Traced it to gdm, which I traced here. I could have been more attentive... but I guess I don't really expect optional stuff to come along by default when I'm dealing with Arch, either.

graysky commented on 2014-11-22 08:45

Bump to v5.32-1

Changelog: http://www.jwz.org/xscreensaver/changelog.html

graysky commented on 2014-11-16 13:26

Please read the comments below since this has been discussed ad nauseam in the past.

Summary: my understanding is that gdm is required when building only to enable the 'new login' button on the lock screen. You don't need gdm installed if you want to use the package, just build. If that is not the case, please open a ticket against the official package. I try to keep this package as close to the official as possible.

All comments