Arch Linux User Repository

You can just use the --nocheck option for makepkg.

can you please remove test for alacritty-git? as it is really annoying and resource hungry.

Hey, I've got two patches in https://gist.github.com/abhinav/8d256a97017eeed7e3b67fe1a61dd3be.

One adds libxkbcommon to makedepends. This is necessary to build the package.

The second adds the .png icon to /usr/share/pixmaps so that ChromeOS (with Crostini) renders the correct icon.

FYI, this worked for me on an ARM64 Linux machine after installing libxkbcommon, so the list of architectures can probably include aarch64 as well.

$ uname -a
Linux arch 5.4.119-14945-gafc97d54f809 #1 SMP PREEMPT Thu Aug 19 18:52:27 PDT 2021 aarch64 GNU/Linux

Need to add a makedep on libxkbcommon: https://github.com/alacritty/alacritty/commit/01a7ad946e75ef9ff7847ad73f2fe40e3e5d8a5f#diff-09b140a43ebfdd8dbec31ce72cafffd15164d2860fd390692a030bcb932b54a0

Hi all.

Just tried to build it today and failed with the following. Any ideas on the root cause?

failures:

---- grid::storage::tests::indexing_above_inner_len stdout ----
note: test did not panic as expected

failures:
    grid::storage::tests::indexing_above_inner_len

test result: FAILED. 111 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

error: test failed, to rerun pass '-p alacritty_terminal --lib'
==> ERROR: A failure occurred in check().
    Aborting...

Hello, I noticed some mixed up spaces and tabs in the indentation, so here I provide this humble patch:

https://gist.github.com/shade-of-noon/c73edcf330617d5bb1b65df5afc295f4

Thanks for maintaining this package and have a nice day.

Thanks for getting back to me on this @quininer. It's not entirely clear from your reply what your concern is here, and I hope you could clarify that for me.

The patch I've proposed doesn't require manual action from folks using makepkg, it just means that a cargo home that is separate from the one they use for doing normal cargo builds will be used for building packages. Is there some type of non-packaged & non-tracked configuration in the cargo home that we expect to have applied to the package? Alternately, are we concerned about having dependencies for this package downloaded/built separately from a particular users cargo home?

Generally, it's advisable to build arch packages in ways that don't depend on other items in the user's environment (which is why so often folks talk about using clean chroots for building packages). This type of thing (not depending on other random state) leads me towards the idea that re-using an existing cargo home isn't a great choice here.

I don't think it's a good idea to require package-specific environment modification to enable a package to build when one is using completely normal options (like debug). It's also the case that the current PKGBUILD behavior here (installing files into home dir when debug is enabled) does not appear to be supported by the Arch package guidelines.

If you're still concerned about having a separate cargo home: consider that you may be able to either: 1. find appropriate -ffile-prefix-map options, or 2. work with makepkg itself to improve support for this particular use case.

If you decide you wish to persue either of those, I encourage fixing the package in the mean time by applying the patch I've already proposed.

Finally, if there's a desire not to support debug for some reason, the PKGBUILD should explicitly disable it in it's OPTIONS (OPTIONS += (!debug)) (I don't like that solution, but it's better than generating packages that depend on the building user's home dir and install files into that same building user's home dir).

@codyps If you need debug package, you can add the environment variable before makepkg, instead of requiring everyone to copy a $HOME/.cargo.

This package still doesn't work properly with OPTIONS+=(debug). Please apply the patch I provided in my previous comment.

https://gist.github.com/jmesmon/6ce967c6a9769b39bab842110f84a665 https://aur.archlinux.org/packages/alacritty-git/#comment-760573