Package Details: ascii-draw 0.3.4-1

Git Clone URL: https://aur.archlinux.org/ascii-draw.git (read-only, click to copy)
Package Base: ascii-draw
Description: Draw diagrams and more using ASCII
Upstream URL: https://github.com/Nokse22/ascii-draw
Licenses: GPL-3.0-or-later
Submitter: ogarcia
Maintainer: ogarcia
Last Packager: ogarcia
Votes: 4
Popularity: 1.16
First Submitted: 2023-08-26 11:40 (UTC)
Last Updated: 2024-05-16 06:27 (UTC)

Latest Comments

ogarcia commented on 2024-01-17 07:49 (UTC)

@begin-theadventu Yes, you are right about vala and cmake. It was my copy/paste mistake. Fixed!

As for the appstream-glib, it is true that both the construction and even the check of the package can be done without this dependency (since meson checks if it exists and uses it or not depending on what it finds), I prefer to put it especially in case it becomes mandatory in the future.

begin-theadventu commented on 2024-01-16 19:06 (UTC)

@ogarcia Thanks for the reply!

vala - this project doesn't seem to use it (code search on GitHub or Languages). As well as cmake (I was able to build without it).

appstream-glib – so it doesn't have to be in checkdepends? Example.

ogarcia commented on 2024-01-16 18:38 (UTC)

@mathisbuilder done :-)

@begin-theadventu Your PKGBUILD is not quite correct:

  • The architecture is "any" since the final package does not include binaries that depend on any particular architecture (it is just python code).
  • As source you use git, this adds an unnecessary requirement to create the package (git itself) when you can perfectly download it using https.
  • It is not recommended to use SKIP in the checksum.
  • The idea of checking is fine when it comes to official packages but in AUR it just adds unnecessary overhead. Besides, making a check as you do (so that in case of failure it continues anyway) does not make much sense, the logical thing is that if the check is not passed the package does not continue to be built.
  • You are missing dependencies, both for the execution and for the build of the package.

mathisbuilder commented on 2024-01-16 16:12 (UTC)

python-emoji is missing in the dependencies

begin-theadventu commented on 2023-09-27 12:52 (UTC) (edited on 2024-01-16 18:08 (UTC) by begin-theadventu)

PKGBUILD improvements:

pkgname=ascii-draw
pkgver=0.2.0
pkgrel=1
pkgdesc='Draw diagrams and more using ASCII'
url='https://github.com/Nokse22/ascii-draw'
license=('GPL3')
arch=('aarch64' 'x86_64')
depends=('libadwaita' 'python-emoji' 'python-gobject' 'python-pyfiglet')
makedepends=('git' 'meson')
checkdepends=('appstream-glib')
source=("git+$url.git#tag=v$pkgver")
sha256sums=('SKIP')

build() {
  arch-meson $pkgname build
  meson compile -C build
}

check() {
  meson test -C build --print-errorlogs || :
}

package() {
  meson install -C build --destdir "$pkgdir"
  chmod +x "$pkgdir/usr/bin/$pkgname"
}

(edit: minor changes)

begin-theadventu commented on 2023-09-02 18:30 (UTC) (edited on 2023-09-02 19:27 (UTC) by begin-theadventu)

arch=('aarch64' 'x86_64')
depends=('libadwaita' 'python-emoji' 'python-gobject' 'python-pyfiglet')
makedepends=('git' 'meson')
checkdepends=('appstream-glib')
source=("git+$url.git#tag=v$pkgver")
b2sums=('SKIP')

arch-meson $pkgname build

check() {
  meson test -C build --print-errorlogs || :
}

chmod +x "$pkgdir/usr/bin/$pkgname"