Package Details: libadwaita-git 1.6.rc.r16.g6e98d61-2

Git Clone URL: https://aur.archlinux.org/libadwaita-git.git (read-only, click to copy)
Package Base: libadwaita-git
Description: Building blocks for modern adaptive GNOME applications
Upstream URL: https://gnome.pages.gitlab.gnome.org/libadwaita
Licenses: LGPL-2.1-or-later
Conflicts: libadwaita
Provides: libadwaita, libadwaita-1.so
Submitter: tallero
Maintainer: FabioLolix
Last Packager: FabioLolix
Votes: 9
Popularity: 0.157087
First Submitted: 2021-01-20 02:44 (UTC)
Last Updated: 2024-09-03 21:22 (UTC)

Required by (599)

Sources (1)

Latest Comments

1 2 3 4 5 6 Next › Last »

MarsSeed commented on 2024-08-22 00:22 (UTC)

After the latest update, this now builds fine in clean chroot. Thx for the quick update, @FabioLolix!

MarsSeed commented on 2024-08-21 22:50 (UTC) (edited on 2024-08-21 22:51 (UTC) by MarsSeed)

Btw @amotrak has submitted a patch, and it is needed for this package to build. As since June 2024, Arch packagers have split out the build helper runtimes from glib2 and made the split package glib2-devel.

Without that in makedepends, this is what happens (tested with the current, latest PKGBUILD, in clean chroot):

Program /usr/bin/glib-mkenums found: NO
libadwaita/src/meson.build:63:25: ERROR: Dependency 'glib-2.0' tool variable 'glib_mkenums' contains erroneous value: '/usr/bin/glib-mkenums'

MarsSeed commented on 2024-08-21 22:46 (UTC)

@FabioLolix, thx for the update, and for your feedback! I will try to aim for making and sharing patches when I can push myself to do so.

Though bear in mind that most typically, when I make a packaging feedback, the changes I suggest are not urgent for me personally. So please don't feel pressured on my part. :)

I am most usually a "hit-and-run" tester of many packages that I don't normally use. Like this one. (I use KDE and I actually don't even have gtk4 nor libadwaita installed on my main machine.)

The chance that brought me here was testing an abandoned VCS package, crosswords-git.

FabioLolix commented on 2024-08-21 22:35 (UTC)

I have pushed an initial revision I made some time ago

@MarsSeed you already know I don't have broadband in these days; why don't you make a patch instead of commenting?

This is also hosted here https://github.com/FabioLolix/PKGBUILD-AUR_fix/tree/master/l

MarsSeed commented on 2024-08-21 22:17 (UTC) (edited on 2024-08-21 22:18 (UTC) by MarsSeed)

Also this package should depend on gtk4-git, not gtk4, because it can be frequently the case, as is at the moment, that the stable gtk4 is too old for the requirement defined in the libadwaita main branch:

Dependency gtk4 found: NO. Found 4.14.5 but need: '>= 4.15.2'

MarsSeed commented on 2024-08-21 22:10 (UTC)

Please rename all split packages to have an actual -git suffix in pkgname. Current naming pattern is not proper (libadwaita-git-docs, libadwaita-git-demos).

amotrak commented on 2024-08-04 06:05 (UTC) (edited on 2024-08-04 06:09 (UTC) by amotrak)

New dependencies are required, just applied the changes from the Arch libadwaita PKGBUILD. Also consider removing version restriction on gtk4 package, as it makes it impossible to build against a gtk4-git (which is now a requirement)

diff --git a/PKGBUILD b/PKGBUILD
index 1a4f782..df56b47 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -15,8 +15,8 @@ pkgname=(
   "${pkgbase}"
   "${_pkgname}-git-docs"
   "${_pkgname}-git-demos")
-pkgver=1.3.rc+311+ge810d86b
-pkgrel=2
+pkgver=1.6.beta+1+ga9975582
+pkgrel=1
 pkgdesc="Building blocks for modern adaptive GNOME applications"
 _url="https://gitlab.gnome.org/GNOME/${_pkgname}"
 url="https://gnome.pages.gitlab.gnome.org/${_pkgname}"
@@ -29,7 +29,14 @@ arch=(
   'armv7h')
 license=(LGPL)
 depends=(
-  "gtk4>=4.11")
+  appstream
+  fribidi
+  glib2
+  glibc
+  graphene
+  gtk4
+  pango
+)
 makedepends=(
   cmake
   git
@@ -37,12 +44,11 @@ makedepends=(
   gi-docgen
   sassc
   gobject-introspection
-  vala)
-checkdepends=(
-  appstream
-  weston)
-source=(
-  "${_pkgname}::git+${_url}")
+  vala
+  glib2-devel
+)
+checkdepends=(weston)
+source=("${_pkgname}::git+${_url}")
 sha256sums=(SKIP)

 pkgver() {
@@ -51,6 +57,9 @@ pkgver() {
 }

 build() {
+    local meson_options=(
+      -D gtk_doc=true
+    )
     arch-meson "${_pkgname}" build -Dgtk_doc=true
     meson compile -C build
 }
@@ -134,6 +143,10 @@ package_libadwaita-git-demos() {
   provides=(
     "${_pkgname}-demos=${pkgver}")
   depends=(
+    glib2
+    glibc
+    gtk4
+    hicolor-icon-theme
     "${_pkgname}-git")
   mv \
     demo/* \

Bitals commented on 2023-12-18 19:48 (UTC) (edited on 2023-12-18 19:49 (UTC) by Bitals)

Okay, I found that only encapsulating the whole check() into a bash subshell works as expected:

diff --git a/PKGBUILD b/PKGBUILD
index 1a4f782..2c15238 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -46,7 +46,7 @@ source=(
 sha256sums=(SKIP)

 pkgver() {
-  cd "${_pkgname}"
+  cd "$srcdir/${_pkgname}"
   git describe --tags | sed 's/-/+/g'
 }

@@ -56,6 +56,7 @@ build() {
 }

 check() {
+  bash -c ' \
   export XDG_RUNTIME_DIR="$PWD/runtime-dir" \
          WAYLAND_DISPLAY=wayland-5

@@ -65,12 +66,13 @@ check() {
          --idle-time=0 &
   _w=$!

-  bash trap "kill ${_w}; wait" EXIT
+  trap "kill ${_w}; wait" EXIT

   meson \
     test \
       -C build \
       --print-errorlogs
+  '
 }

 _pick() {

Should also guarantee that ${_w} exist inside that shell, because it's still the same one.

Bitals commented on 2023-12-18 19:20 (UTC) (edited on 2023-12-18 19:20 (UTC) by Bitals)

Disregard my previous comment about trap, that was incorrect. Debugging rn.

1 2 3 4 5 6 Next › Last »