Arch Linux User Repository

Unfortunately I do not have the time to continue maintaining the package, so I have disowned it in case someone else wants to pick it up.

==> Starting prepare()...
error: patch failed: CMakeLists.txt:157
error: CMakeLists.txt: patch does not apply
==> ERROR: A failure occurred in prepare().
    Aborting...
==> ERROR: Build failed, check /var/lib/aurbuild/x86_64/user/build

Seems the patch needs to be removed or updated.

Here's a patch to use the system absl:

--- ./CMakeLists.txt
+++ ./CMakeLists.txt
@@ -50,6 +50,8 @@ else(${PKG_CONFIG_FOUND})
 endif()
 endif()

+find_package(absl)
+
 # Set default build type.
 if(NOT CMAKE_BUILD_TYPE)
   message(STATUS "Setting build type to 'RelWithDebInfo' as none was specified.")
@@ -157,7 +159,6 @@ endif(UNIX)

 include_directories(.)
 include_directories(src)
-include_directories(third_party/abseil-cpp)
 include_directories("${CMAKE_CURRENT_BINARY_DIR}/src")

 # Baseline build flags.
@@ -244,6 +245,13 @@ add_library(libbloaty
     src/util.cc
     src/util.h
     src/webassembly.cc
+)
+
+if (absl_FOUND)
+  target_link_libraries(libbloaty PUBLIC absl::base absl::strings absl::numeric)
+else()
+  include_directories(third_party/abseil-cpp)
+  target_sources(libbloaty
     # Until Abseil has a proper CMake build system
     third_party/abseil-cpp/absl/base/internal/raw_logging.cc # Grrrr...
     third_party/abseil-cpp/absl/base/internal/throw_delegate.cc
@@ -266,7 +274,8 @@ add_library(libbloaty
     third_party/abseil-cpp/absl/types/bad_optional_access.cc
     # One source file, no special build system needed.
     third_party/demumble/third_party/libcxxabi/cxa_demangle.cpp
-    )
+  )
+endif()
 set_property(TARGET libbloaty PROPERTY FOLDER "bloaty")

 if(UNIX OR MINGW)

The issue is actually that bloaty ships its own version of abseil and the system-provided protobuf has to be compatible with that version. A quick solution for bloaty-git to build is to downgrade protobuf to 21.12-2.

Hey if anyone else is running into building the latest HEAD, this appears to be an upstream issue. Bloaty is vendoring in a bunch of abseil headers, which are incompatible with the version of protobuf that Arch is shipping.

I've filed a bug here: https://github.com/google/bloaty/issues/353. That report also includes a patch that just removes these vendored headers from the CMakeLists. Haven't looked at adding it to the PKGBUILD as yet, but that should provide a temporary workaround.

Temporary fix for building with GCC 13 (until https://github.com/google/bloaty/pull/332 is merged):

 PKGBUILD | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git i/PKGBUILD w/PKGBUILD
index fe38bce..1b91df8 100644
--- i/PKGBUILD
+++ w/PKGBUILD
@@ -13,6 +13,9 @@ conflicts=(bloaty)
 source=("${pkgname}::git+${url}")
 sha512sums=(SKIP)

+source+=(https://github.com/google/bloaty/commit/7611debaa6459e66b95e03937a2573316e42b69e.patch)
+sha512sums+=(d1b547edd3151cb9fb93b8355b17ab4b6ecd96dccc3ffc6608e0c3c1b7289f11638568c87edde41b0c5df4138c8700dc18cda703587c98fffe419cb24e684fd9)
+
 pkgver () {
    cd "${pkgname}"
    (
@@ -22,6 +25,11 @@ pkgver () {
    )
 }

+prepare() {
+  cd "${srcdir}/${pkgname}"
+  patch -p1 -i "${srcdir}/7611debaa6459e66b95e03937a2573316e42b69e.patch"
+}
+
 build() {
     rm -rf "${srcdir}/build"
     mkdir "${srcdir}/build"

It tries to download a ton of stuff in its build() function (so it fails to build here in my sandbox).

I assume it's some submodules it tries to download (instead of using normal dependency handling), so might help to do something like this: https://wiki.archlinux.org/title/VCS_package_guidelines#Git_submodules

@flacs: Thanks to the suggestion, I have updated the PKGBUILD to depend on system packages instead.

bloaty has the ability to detect system-wide installations of re2, capstone, and protobuf-c, so it would probably make sense to add them as dependencies.

@bertptrs: Thanks for the suggestion, I have updated the PKGBUILD accordingly. Also, tweaked pkgver() to take the tags into account.