Package Details: cado-nfs-git 20241219.cb69f536e-1

Git Clone URL: https://aur.archlinux.org/cado-nfs-git.git (read-only, click to copy)
Package Base: cado-nfs-git
Description: Implementation of the Number Field Sieve (NFS) algorithm for factoring integers
Upstream URL: http://cado-nfs.gforge.inria.fr/
Licenses: LGPL2
Conflicts: cado-nfs
Provides: cado-nfs
Submitter: jdetrey
Maintainer: AquilaIrreale
Last Packager: AquilaIrreale
Votes: 4
Popularity: 0.000062
First Submitted: 2015-12-07 12:57 (UTC)
Last Updated: 2024-12-29 22:33 (UTC)

Dependencies (14)

Required by (0)

Sources (2)

Latest Comments

1 2 3 4 Next › Last »

nkeck72 commented on 2025-05-17 04:40 (UTC)

@AquilaIrreale doing a clean build did indeed fix it. Thanks! In general, do PKGBIULDs based off CMake projects need occasional clean building like this to refresh what I assume is stale CMakeCache files?

AquilaIrreale commented on 2025-05-10 14:45 (UTC)

@nkeck72 you may be building with stale sources, cmake_minimum_required version was updated to 3.18 by upstream Oct 9 2024, merged Oct 20 into the master branch used by PKGBUILD. Have you tried doing a clean build? (makepkg -C)

nkeck72 commented on 2025-04-25 20:35 (UTC) (edited on 2025-04-25 20:36 (UTC) by nkeck72)

It appears that this package is set to a compatibility level in CMakeLists.txt that cmake no longer supports:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

Unless CMakeLists.txt is written with explicit behavior that is only supported below version 3.5, it might be a good idea to patch the cmake_minimum_required line to report 3.5 or higher. I realize this is an upstream problem but it's easily patched in the meantime until they get their sources fixed.

AquilaIrreale commented on 2024-12-29 22:36 (UTC)

@ccorn Thank you, fixed.

ccorn commented on 2024-12-29 21:20 (UTC)

The current CADO-NFS git snapshot needs depends+=(python-flask python-requests).

AquilaIrreale commented on 2024-04-04 17:42 (UTC)

@Robin_Jadoul patch wiggled, thank you for your report

Robin_Jadoul commented on 2024-03-29 14:01 (UTC)

fmt.patch doesn't apply anymore. Regenerating it by manually commenting out the line and saving the resulting git diff seems to make everything work fine again.

AquilaIrreale commented on 2022-10-06 18:21 (UTC) (edited on 2022-10-06 18:22 (UTC) by AquilaIrreale)

@gilcu3 the [ was not extra (it is a special character to be escaped) but apparently, depending on the sed implementation, when present inside a character class it has to be at the very end of it; fixed.

Regarding the strip option, if that's the case then we'll have to keep the sed and -ffile-prefix-map in as you proposed.

gilcu3 commented on 2022-10-05 07:17 (UTC) (edited on 2022-10-05 07:18 (UTC) by gilcu3)

@AquilaIrreale in the last version there is an extra character in the sed command line 70 (one extra '[') which breaks the packaging.

Regarding fixing the commit hash, yes I only had it because at some point building was not working in the last commit, must have been fixed already.

Regarding the strip option, yes I get ==> WARNING: Package contains reference to $srcdir even with the option on.

AquilaIrreale commented on 2022-10-04 22:36 (UTC) (edited on 2024-12-29 22:38 (UTC) by AquilaIrreale)

@gilcu3 thank you for your suggestions, I adopted some of them, with a couple modifications (mainly making sed sturdier against strange characters in the build path, although it's probably futile anyways, since I could not think of a way to protect -ffile-prefix-map=old=new against spaces during the expansion of the $FLAGS variables, and I'm not sure how it behaves in the presence of embedded equal signs (=) in the old and new patterns).

I am not going to hardcode the commit hash, this being a -git package it should always build the most recent version available on master, and I removed the strip option, that one should be set in makepkg.conf on a per-user basis, even if not having it has the chance to leave additional references to $srcdir in the built binaries (which is expected behavior).

P.s. come to think of it, in my builds it never put references to the $srcdir in my binaries (I always had strip on by default). Are you sure we need all the header file sed'ing and -ffile-prefix-map at all and it's not just the strip option that's fixing it for you?

@ccorn yeah, I left out a cd when I moved the generation of local.sh from build() to prepare() and it somehow still appeared to work fine. Teach me to double check, really, smh :/

1 2 3 4 Next › Last »