Package Details: can-utils 2018.02.0-3

Git Clone URL: https://aur.archlinux.org/can-utils.git (read-only)
Package Base: can-utils
Description: Linux-CAN / SocketCAN user space applications
Upstream URL: https://github.com/linux-can/can-utils
Keywords: can canbus Linux-CAN SocketCAN
Licenses: GPLv2
Conflicts: can-utils-git
Submitter: GPereira
Maintainer: markzz
Last Packager: GPereira
Votes: 2
Popularity: 0.058652
First Submitted: 2018-02-15 12:05
Last Updated: 2018-03-03 16:13

Dependencies (0)

Required by (4)

Sources (1)

Latest Comments

pschichtel commented on 2019-01-03 16:30

Can confirm etskinner's comment.

etskinner commented on 2018-12-22 05:37

This builds successfully and appears to work fine on armv7h. Could you add that to the arch list?

GPereira commented on 2018-03-03 16:13

@torkelatgenet added, thanks!

torkelatgenet commented on 2018-03-02 14:42

Could you add 'armv6h' to arch, i've tested and it works.

GPereira commented on 2018-02-15 23:35

@Eschwartz Thanks for the review, Hope it is all ok now

eschwartz commented on 2018-02-15 16:21

arch=('any') is wrong, as the resulting package includes compiled binaries.

Running tar yourself is wrong, since makepkg already extracts tarballs from source, and running pwd is ugly and pointless.

The package should not provide conflict or replace anything, as it is the job of the -git package to do so (which it does), and in any event packages do not "provide" themselves, they are themselves already.

The source will conflict with any other packages having the same version, see the warning at https://wiki.archlinux.org/index.php/PKGBUILD#source

Instead, use

source=("${pkgname}-${pkgver}.tar..gz::${url}/archive/v${pkgver}.tar.gz")

The _pkgname variable is totally pointless, just use cd "${srcdir}/${pkgname}-${pkgver}" like every other package in the AUR.

Skipping the sha256sums is wrong, as download integrity checks are important unless you use git which already handles this. You likely copied this from the git PKGBUILD and did not update it when you switched from git to a tarball.

libtool is part of base-devel and should be removed from the makedepends.