Package Details: dosbox-x 2024.03.01-1

Git Clone URL: https://aur.archlinux.org/dosbox-x.git (read-only, click to copy)
Package Base: dosbox-x
Description: x86 emulator with builtin DOS, with patches with more features
Upstream URL: http://dosbox-x.com
Keywords: emulation
Licenses: GPL
Conflicts: dosbox-x-git
Submitter: mike.cuche
Maintainer: mike.cuche
Last Packager: mike.cuche
Votes: 23
Popularity: 0.97
First Submitted: 2019-04-11 18:41 (UTC)
Last Updated: 2024-03-02 08:05 (UTC)

Latest Comments

1 2 3 4 5 Next › Last »

sardaukar commented on 2024-06-01 12:16 (UTC)

Can't get this to compile. Getting

/home/sardaukar/.cache/yay/dosbox-x/src/dosbox-x-dosbox-x-v2024.03.01/vs/sdl/src/video/x11/SDL_x11video.c:2050:75: error: passing argument 5 of ‘XRegisterIMInstantiateCallback’ from incompatible pointer type [-Wincompatible-pointer-types]
 2050 |         if (XRegisterIMInstantiateCallback(SDL_Display, NULL, NULL, NULL, (XIMProc)im_callback, NULL) != True) {
      |                                                                           ^~~~~~~~~~~~~~~~~~~~
      |                                                                           |
      |                                                                           void (*)(struct _XIM *, char *, char *)
In file included from /home/sardaukar/.cache/yay/dosbox-x/src/dosbox-x-dosbox-x-v2024.03.01/vs/sdl/src/video/x11/SDL_x11video.h:27,
                 from /home/sardaukar/.cache/yay/dosbox-x/src/dosbox-x-dosbox-x-v2024.03.01/vs/sdl/src/video/x11/SDL_x11video.c:46:
/usr/include/X11/Xlib.h:3946:5: note: expected ‘XIDProc’ {aka ‘void (*)(Display *, char *, char *)’} but argument is of type ‘void (*)(struct _XIM *, char *, char *)’
 3946 |     XIDProc                     /* callback */,
      |     ^~~~~~~
make: *** [build-deps:1404: build/SDL_x11video.lo] Error 1

sethkush commented on 2024-03-13 15:42 (UTC)

I tried removing just -march=x86_64 and it was still broken, so I dropped it all. My patch as-is should treat all other architectures the same as before (it only changes the PKGBUILD for aarch64). Other architectures must have already been broken.

lunasophia commented on 2024-03-13 13:20 (UTC) (edited on 2024-03-13 13:21 (UTC) by lunasophia)

I don't have an aarch64 Arch machine to test on, but you should be able to keep everything but the -march=x86_64. Have you tested that these other flags (in particular -O2) break the build on aarch64? Also, your patch as-is breaks on everything that is not (aarch64 || x86_64). Really, the correct approach is to probably get the architecture with uname -r and use that as the argument to -march.

sethkush commented on 2024-03-13 01:37 (UTC)

The CFLAGS workaround seems to break the build on aarch64. The following fixes it:

diff --git a/PKGBUILD b/PKGBUILD
index 6dc8274..dc47547 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -17,11 +17,12 @@ sha256sums=('2a89d3196ddc15361f6dc7e6ab142bfe95945d93d527cfd6bacca1f7a401a513')

 build() {
   cd $srcdir/dosbox-x-dosbox-x-v${pkgver}
-  
-  #Workaround: https://github.com/joncampbell123/dosbox-x/issues/4436
-  export CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
-    -Wp,-D_FORTIFY_SOURCE=2 -Wformat \
-    -fstack-clash-protection -fcf-protection"
+  if [ $CARCH -ne 'aarch64' ]; then
+    #Workaround: https://github.com/joncampbell123/dosbox-x/issues/4436
+    export CFLAGS="-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions \
+      -Wp,-D_FORTIFY_SOURCE=2 -Wformat \
+      -fstack-clash-protection -fcf-protection"
+  fi
   export CXXFLAGS="$CFLAGS -Wp,-D_GLIBCXX_ASSERTIONS"

   sed -i -e 's/-j3/-j$(nproc)/g' build

markboston commented on 2023-09-05 21:43 (UTC)

the package fails to build on my system. below is the error i get. its not telling me whats failing to build.

libtool: compile: clang -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -fstack-clash-protection -fcf-protection -Iinclude -I/home/mark/.cache/yay/dosbox-x/src/dosbox-x-dosbox-x-v2023.09.01/vs/sdl/include -D_GNU_SOURCE=1 -fvisibility=hidden -D_REENTRANT -DXTHREADS -D_REENTRANT -DHAVE_LINUX_VERSION_H -Wall -c /home/mark/.cache/yay/dosbox-x/src/dosbox-x-dosbox-x-v2023.09.01/vs/sdl/src/video/x11/SDL_x11yuv.c -o build/SDL_x11yuv.o make: *** [build-deps:1404: build/SDL_x11video.lo] Error 1 make: *** Waiting for unfinished jobs....

mike.cuche commented on 2023-09-02 08:39 (UTC)

@markboston Hello, I prefer not doing it, as the PKGBUILD guidelines states you should include the dependencies for building all optional features of a package in "depends"

You are still free to manually download the PKGBUILD and edit it as you wish

markboston commented on 2023-09-01 18:10 (UTC)

can fluidsynth please be removed as a required dependency?

Switch123456789 commented on 2023-07-23 10:37 (UTC)

@mike.cuche Ohhh, thank you for the info, I did not know that. I installed tons of AUR packages (and updates) successfully in the past 6 months without even knowing about base-devel. Dosbox-x & other dosbox-packages are the first packages that are complaining. Really confusing...

@kq6up You seem to have the exact same problem as I do, since you get the same error as I did.

mike.cuche commented on 2023-07-23 05:13 (UTC)

@Switch123456789 if you are building an AUR package, you need to have base-devel installed:

https://wiki.archlinux.org/title/Arch_User_Repository#Getting_started

Switch123456789 commented on 2023-07-22 20:47 (UTC)

It seems like this package depends on autoconf & automake but I had to install it manually. I am new to arch, is this expected?