Arch Linux User Repository

Hello anish

I get build errors like this when I build this:

ais_charset.c:3:24: error: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (65 chars into 64 available) [-Werror=unterminated-string-initialization]
    3 | char ais_charset[64] = "@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_ !\"#$%&'()*+,-./0123456789:;<=>?";
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  SoapySDR support: yes
cc1: all warnings being treated as errors

any reason not to use the same start script as debian? https://github.com/flightaware/dump1090/blob/master/debian/start-dump1090-fa I think it doesn't pick up my location because of it (we don't source /var/cache/piaware/location.env)

after latest git dev merge seems like the patch is failing -

==> Starting prepare()...
patching file adaptive.c
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file adaptive.c.rej
patching file net_io.c
Reversed (or previously applied) patch detected!  Assume -R? [n] y
==> ERROR: A failure occurred in prepare()

The patch is no longer needed

It looks like they are using a starting script for the dump1090.service to handle the options. Right now it is hard coded in the ExecStart so creating the file alone would have no effect. We can do what dump978-fa-git does and put the current options in ExecStart to the default file. This should have minimal impact.

I'll take a look at adding soapy and the default dump0190 config. I'm not sure how disruptive changing the defaults can be. I'm not inclined to make lighttpd optional since that is also the default for piaware https://github.com/flightaware/dump1090/blob/master/debian/control#L20

Please also include the default configuration since piaware-config is not going to create it.

soapysdr can be added to the dependency to enable other sdr backends.

I have tested that lighttpd is not needed for buiding the package. Please consider making lighttpd an optional dependency so users have options for other http servers.

With regards to the previous, a fix has already been merged upstream to the dev branch. This package could either be switched to point to the dev branch, or else the changes from the PR could be added as a patch, rather than disabling GCC errors entirely.

The package currently does not build due to gcc giving a warning during compilation, and the Makefile has -Werror specified. This warning/error is generated: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]

To build it, run makepkg {your args} on the PKGBUILD, allow it to fail the compilation, then edit the src/dump1090/Makefile file, and change the DUMP1090_CFLAGS line to remove the -Werror flag.

Then you can run makepkg {your args} with the additional argument -e, i.e. makepkg {your args} -e to have gcc ignore the warnings.