Arch Linux User Repository

done, thanks for the heads-up!

The upstream of this package is being maintained again. Please bump version to 0.6 and update the release tarball: https://github.com/mvdan/fdroidcl/archive/refs/tags/v0.6.0.tar.gz

I'll update the pkgbuild soon. E: updated.

I don't actively maintain upstream anymore (https://github.com/mvdan/fdroidcl/issues/56), so I'm happy to also hand over maintenance of this package.

Hello, go packaging guidelines changed a bit since last comment, could you update? https://wiki.archlinux.org/title/Go_package_guidelines

Apologies, I completely missed your comment. I'll fix both issues, thanks.

Note that Go 1.13 only requires -trimpath to properly produce reproducible binaries, in theory. There's a minor bug with that, but it's already fixed in 1.13.2, which should come out in a few days. So I won't add the rest of the all= flags as they won't be necessary soon enough.

Would you mind striping the binaries to avoid warning like this: ==> WARNING: Package contains reference to $srcdir usr/bin/fdroidcl

also installing zsh completion from contrib.

here;s a patch from https://wiki.archlinux.org/index.php/Go_package_guidelines

Thanks.

diff --git a/PKGBUILD b/PKGBUILD
index 54b9866..8eaed2c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -21,11 +21,16 @@ prepare() {

 build() {
    cd "${srcdir}/src/mvdan.cc/${_name}"
-   GOPATH="${srcdir}" go build -ldflags='-s -w'
+    GOPATH="${srcdir}" go build \
+    -gcflags "all=-trimpath=${PWD}" \
+    -asmflags "all=-trimpath=${PWD}" \
+    -ldflags "-s -w -extldflags ${LDFLAGS}" \
+    .
 }

 package() {
    cd "${srcdir}/src/mvdan.cc/${_name}"
    install -Dm755 "${_name}" "${pkgdir}/usr/bin/${_name}"
    install -Dm644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
+    install -Dm644 contrib/completion/zsh/_fdroidcl "${pkgdir}/usr/share/zsh/vendor-completions/_fdroidcl"
 }

Line 19 of the PKGBUILD needs to be changed to

Did you encounter an error, or is this just about correctness? Both forms seem fine to me, and the current PKGBUILD works.

And it depends to go>=1.11, so e.g. the current gcc-go does not work, you have to have go installed.

Won't that be too restrictive? Future gcc-go versions will support the Go 1.11 language and standard library, so I don't want to forbid those.

And it depends to go>=1.11, so e.g. the current gcc-go does not work, you have to have go installed.

Line 19 of the PKGBUILD needs to be changed to

mv "${_name}" "src/mvdan.cc/"