Arch Linux User Repository

Thank you. All good here, now.

Yeah, I see now. Added a patch.

consistantly fails... I'm afraid. here is a list of what's installed on most machines in my network. hts tries to update to latest... but alas fails.

paru -Ss kodi | grep -i inst aur/kodi-addon-pvr-hts 21.2.6-1 [+33 ~0.57] [Installed: 21.2.5-1] extra/p8-platform 2.1.0.1-5 [0 B 271.65 KiB] [Installed] extra/kodi-platform 20190726.809c5e9-56 [0 B 26.79 KiB] [Installed] extra/kodi-dev 21.2-10 [0 B 1.88 MiB] [Installed] extra/kodi 21.2-10 [0 B 85.27 MiB] [Installed]

Can't reproduce that issue.

Same failure here. However, the previous version is still working.

It fails to compile /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:37:5: error: class ‘tvheadend::HTSPVFS’ does not have any field named ‘m_fileId’ 37 | m_fileId(0), | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘void tvheadend::HTSPVFS::RebuildState()’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:53:7: error: ‘m_fileId’ was not declared in this scope 53 | if (m_fileId != 0) | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘void tvheadend::HTSPVFS::Close()’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:90:7: error: ‘m_fileId’ was not declared in this scope 90 | if (m_fileId != 0) | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:94:3: error: ‘m_fileId’ was not declared in this scope 94 | m_fileId = 0; | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘int64_t tvheadend::HTSPVFS::Read(unsigned char, unsigned int, bool)’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:105:8: error: ‘m_fileId’ was not declared in this scope 105 | if (!m_fileId) | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘long long int tvheadend::HTSPVFS::Seek(long long int, int, bool)’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:130:7: error: ‘m_fileId’ was not declared in this scope 130 | if (m_fileId == 0) | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘long long int tvheadend::HTSPVFS::Size()’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:170:27: error: ‘m_fileId’ was not declared in this scope 170 | htsmsg_add_u32(m, "id", m_fileId); | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘bool tvheadend::HTSPVFS::SendFileOpen(bool)’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:248:32: error: ‘m_fileId’ was not declared in this scope 248 | if (htsmsg_get_u32(m, "id", &m_fileId)) | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:257:10: error: ‘m_fileId’ was not declared in this scope 257 | return m_fileId > 0; | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘void tvheadend::HTSPVFS::SendFileClose()’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:264:27: error: ‘m_fileId’ was not declared in this scope 264 | htsmsg_add_u32(m, "id", m_fileId); | ^~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘long long int tvheadend::HTSPVFS::SendFileSeek(int64_t, int, bool)’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:290:27: error: ‘m_fileId’ was not declared in this scope 290 | htsmsg_add_u32(m, "id", m_fileId); | ^~~~ /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘int64_t tvheadend::HTSPVFS::SendFileRead(unsigned char, unsigned int)’: /home/user/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:340:27: error: ‘m_fileId’ was not declared in this scope 340 | htsmsg_add_u32(m, "id", m_fileId); | ^~~~ [ 44%] Building CXX object CMakeFiles/pvr.hts.dir/src/tvheadend/utilities/TCPSocket.cpp.o [ 46%] Building CXX object CMakeFiles/pvr.hts.dir/src/tvheadend/utilities/SettingsMigration.cpp.o make[2]: *** [CMakeFiles/pvr.hts.dir/build.make:345: CMakeFiles/pvr.hts.dir/src/tvheadend/HTSPVFS.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [CMakeFiles/Makefile2:142: CMakeFiles/pvr.hts.dir/all] Error 2 make: *** [Makefile:156: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting...

fails to compile. I am on garuda mokka

/home/ben/.cache/paru/clone/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘long long int tvheadend::HTSPVFS::SendFileSeek(int64_t, int, bool)’: /home/ben/.cache/paru/clone/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:290:27: error: ‘m_fileId’ was not declared in this scope 290 | htsmsg_add_u32(m, "id", m_fileId); | ^~ /home/ben/.cache/paru/clone/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp: In member function ‘int64_t tvheadend::HTSPVFS::SendFileRead(unsigned char*, unsigned int)’: /home/ben/.cache/paru/clone/kodi-addon-pvr-hts/src/pvr.hts/src/tvheadend/HTSPVFS.cpp:340:27: error: ‘m_fileId’ was not declared in this scope 340 | htsmsg_add_u32(m, "id", m_fileId); | ^~ make[2]: *** [CMakeFiles/pvr.hts.dir/build.make:345: CMakeFiles/pvr.hts.dir/src/tvheadend/HTSPVFS.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:142: CMakeFiles/pvr.hts.dir/all] Error 2 make: *** [Makefile:156: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... error: failed to build 'kodi-addon-pvr-hts-21.2.5-1': error: packages failed to build: kodi-addon-pvr-hts-21.2.5-1

Applied, thx.

Unfortunately, the package unconditionally assumes (Unix) Makefiles CMake generator which causes the following error every time I update:

-- Configuring done (3.5s)
-- Generating done (0.0s)
-- Build files have been written to: /home/<user>/.cache/yay/kodi-addon-pvr-hts/src/pvr.hts/build
make: *** No targets specified and no makefile found.  Stop.
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: kodi-addon-pvr-hts-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
kodi-addon-pvr-hts - exit status 4

because I have CMAKE_GENERATOR=Ninja defined in my ~/.bashrc.

Resolving this issue requires replacing all make calls either by cmake --build or cmake --install to be generator agnostic. I suggest the following changes:

diff --git a/PKGBUILD b/PKGBUILD
index 3d44752..9e493da 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -21,19 +21,15 @@ md5sums=('SKIP')
 _prefix='/usr'

 build() {
-  msg "Starting make..."
+  msg "Starting build..."

   cd "$srcdir/$_gitname"
-  mkdir -p build && pushd build
-  cmake \
+  cmake -S . -B build/ \
     -DCMAKE_INSTALL_PREFIX=$_prefix \
-    -DCMAKE_BUILD_TYPE=Release \
-    ..
-  make
-  popd
+    -DCMAKE_BUILD_TYPE=Release
+  cmake --build build/
 }

 package() {
-  cd "$srcdir/$_gitname/build"
-  make DESTDIR="$pkgdir" install
+  DESTDIR="$pkgdir" cmake --install "$srcdir/$_gitname/build"
 }