Package Details: ledger-live 2.92.1-1

Git Clone URL: https://aur.archlinux.org/ledger-live.git (read-only, click to copy)
Package Base: ledger-live
Description: Maintain your Ledger devices
Upstream URL: https://www.ledger.com/ledger-live
Keywords: bitcoin cryptocurrency wallet
Licenses: MIT
Submitter: meriadec
Maintainer: phnx47
Last Packager: phnx47
Votes: 21
Popularity: 0.112018
First Submitted: 2018-07-19 09:01 (UTC)
Last Updated: 2024-11-22 01:13 (UTC)

Latest Comments

« First ‹ Previous 1 .. 3 4 5 6 7 8 9 10 11 12 13 .. 15 Next › Last »

sudoforge commented on 2022-11-13 06:54 (UTC)

i don't think i've actually updated that package since adopting it; it's wildly out of date and needs to be dramatically improved. thanks for reminding me about that!

i think my brain is fried from a long day; you're absolutely right that dist isn't relevant. anyway, glad you were able to get the invalid symlink / erroneous copy fixed!

phnx47 commented on 2022-11-13 06:38 (UTC) (edited on 2022-11-13 06:38 (UTC) by phnx47)

@sudoforge You are also use copy instead of move in your packages. What is your point? https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=google-appengine-go#n53

phnx47 commented on 2022-11-13 06:33 (UTC)

@sudoforge It is no difference for package size. Only pkgdir uses. I never see anyone moves files from srcdir to pkgdir, only copy.

srcdir This points to the directory where makepkg extracts or symlinks all files in the source array.

pkgdir This points to the directory where makepkg bundles the installed package, which becomes the root directory of your built package.

sudoforge commented on 2022-11-13 06:21 (UTC)

All of the files that you're copying from linux-unpacked. Because you're copying instead of moving, you're duplicating the entire contents of that directory.

phnx47 commented on 2022-11-13 06:12 (UTC)

@sudoforge What exactly aren't necessary?

sudoforge commented on 2022-11-13 06:00 (UTC)

Faux pas on my end; it's not empty; it's an extraneous directory with duplicate contents in it, that aren't necessary, and serve no purpose other than increasing the size of the package.

phnx47 commented on 2022-11-13 05:58 (UTC)

@sudoforge What do you mean about empty directory? Which directory is empty?

phnx47 commented on 2022-11-13 05:52 (UTC) (edited on 2022-11-13 05:53 (UTC) by phnx47)

@sudoforge src/ledger-live-2.49.2-git/apps/ledger-live-desktop/dist/linux-unpackedcontains what I need to run App. I copy them to pkg/opt/ledger-live-desktop. I found this way in many arch packages, for example Discord: https://github.com/archlinux/svntogit-community/blob/00545d92d7c1b963b1e34d722928e5df3f8ec46e/trunk/PKGBUILD#L32

sudoforge commented on 2022-11-13 05:47 (UTC) (edited on 2022-11-13 05:58 (UTC) by sudoforge)

Odd, I must have been looking at a cached page of the PKGBUILD. But why copy the contents out, anyway? Now you're leaving an useless directory and files around, increasing the size of the package.

phnx47 commented on 2022-11-13 05:35 (UTC) (edited on 2022-11-13 05:39 (UTC) by phnx47)

@sudoforge Copy linux-unpacked fixed already https://aur.archlinux.org/cgit/aur.git/commit/?h=ledger-live&id=36a3b8998036927f48a15b0b342cfd95a1bb8971