Arch Linux User Repository

@sudoforge You are also use copy instead of move in your packages. What is your point? https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=google-appengine-go#n53

@sudoforge It is no difference for package size. Only pkgdir uses. I never see anyone moves files from srcdir to pkgdir, only copy.

srcdir This points to the directory where makepkg extracts or symlinks all files in the source array.

pkgdir This points to the directory where makepkg bundles the installed package, which becomes the root directory of your built package.

All of the files that you're copying from linux-unpacked. Because you're copying instead of moving, you're duplicating the entire contents of that directory.

@sudoforge What exactly aren't necessary?

Faux pas on my end; it's not empty; it's an extraneous directory with duplicate contents in it, that aren't necessary, and serve no purpose other than increasing the size of the package.

@sudoforge What do you mean about empty directory? Which directory is empty?

@sudoforge src/ledger-live-2.49.2-git/apps/ledger-live-desktop/dist/linux-unpackedcontains what I need to run App. I copy them to pkg/opt/ledger-live-desktop. I found this way in many arch packages, for example Discord: https://github.com/archlinux/svntogit-community/blob/00545d92d7c1b963b1e34d722928e5df3f8ec46e/trunk/PKGBUILD#L32

Odd, I must have been looking at a cached page of the PKGBUILD. But why copy the contents out, anyway? Now you're leaving an useless directory and files around, increasing the size of the package.

@sudoforge Copy linux-unpacked fixed already https://aur.archlinux.org/cgit/aur.git/commit/?h=ledger-live&id=36a3b8998036927f48a15b0b342cfd95a1bb8971

This also needs a patch, because this line:

cp -r "dist/linux-unpacked" "${pkgdir}/opt/${_pkgbin}"

copies the linux-unpacked directory itself to /opt/ledger-live-desktop/linux-unpacked, not the contents within, making your /usr/bin/ledger-live-desktop symlink point to a nonexistent file.