Package Details: libsonic-git 0.2.0_53+r182.20180706.71c5119-1

Git Clone URL: https://aur.archlinux.org/libsonic-git.git (read-only)
Package Base: libsonic-git
Description: Simple library to speed up or slow down speech
Upstream URL: https://github.com/waywardgeek/sonic
Licenses: Apache
Conflicts: libsonic
Provides: libsonic=0.2.0_53+r182.20180706.71c5119
Submitter: stormdragon2976
Maintainer: stormdragon2976
Last Packager: stormdragon2976
Votes: 1
Popularity: 0.000000
First Submitted: 2016-01-20 21:05
Last Updated: 2019-05-02 12:35

Latest Comments

dreieck commented on 2019-05-02 11:32

License: namcap gives me

libsonic-git E: Apache 2.0 is not a common license (it's not in /usr/share/licenses/common/)

The license needs to be called Apache, not Apache 2.0.

Please fix.

dreieck commented on 2019-05-02 11:31

You specified arch=('any'), but it contains ELF binaries. Please specify all supported architectures (e.g. arch=('i686' 'x86_64') and maybe ARMs).

dreieck commented on 2019-05-02 11:29

Some cosmetic comments:

  • The blank line between the } of pkgver(), and build(), does contain an extraneous whitespace. Consider removing it.

  • Indentation of build() and package() is broken. Consider to pretty-indent it, and to make intendation style consistend among the whole PKGBUILD.

dreieck commented on 2019-05-02 11:27

I have reworked the pkgver()-function such that it reports back libary's version:

pkgver()
{
  cd "${srcdir}/${_pkgname}"

  _ver="$(git describe --tags | sed -E 's|[a-zA-Z]+\-||g' | sed -E 's|[\-]g[0-9a-fa-f]+||g' | sed 's|^v||' | tr '-' '_')"
  _rev="$(git rev-list --count HEAD)"
  _hash="$(git rev-parse --short HEAD)"
  _date="$(git log -n 1 --format=tformat:%ci | awk '{print $1}' | tr -d '-')"

  if [ -n "${_ver}" ]; then
    printf %s "${_ver}+r${_rev}.${_date}.${_hash}"
  fi
}

(This one also adds information like commit count, date of last commit, and git hash, they could be removed.)

I suggest to incorporate in your pkgver() at least the _ver-part of my pkgver().

dreieck commented on 2019-05-02 11:14

Can you add

provides=("libsonic=${pkgver}")
conflicts=('libsonic')

to the PKGBUILD?

stormdragon2976 commented on 2018-07-03 17:55

@applebloom: thanks, I removed the prepare function.

applebloom commented on 2018-07-03 17:34

@stormdragon2976 My PR was merged into master (https://github.com/waywardgeek/sonic/pull/14) so the prepare thing is not needed anymore.

stormdragon2976 commented on 2018-04-21 22:22

@applebloom: thanks for your work, I added the prepare section to the PKGBUILD and will remove it when the patch is accepted.

applebloom commented on 2018-04-21 22:05

There's a small issue with the Makefile in thsi project (FFTW is not linked-in). This causes the configure script for another package, espeak-ng, to fail to detect this library. I've made a PR for sonic with a fix for this (https://github.com/waywardgeek/sonic/pull/14). Before it's (hopefully) merged, you could add this to PKGBUILD to hotfix: http://ix.io/18ov