Arch Linux User Repository

Ahoj,

please add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 as a workaround to the cmake call until upstream has fixed ↗ this issue, breaking cmake run with CMake version 4:

CMake Error at CMakeLists.txt:23 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

Regards and thanks for the package!

Thanks applied.

Hi,

Here are two patches: 0001-Make-the-package-architecture-dependent-to-enable-sh.patch:

From f24be40f31fae22014f3ff65cf711170ff4afd80 Mon Sep 17 00:00:00 2001
From: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org
Date: Sat, 6 Jul 2019 03:23:10 +0200
Subject: [PATCH 1/2] Make the package architecture dependent to enable
 shipping it.

While this works in AUR, because users are building the PKGBUILD,
distributions wanting to use this PKGBUILD as-is and ship packages
produced with it will have an issue as the package built will be
installable on any architecture, but the binaries in the packages
are not architecture independant.
Signed-off-by: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org
PKGBUILD | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PKGBUILD b/PKGBUILD
index 33b5046..238566b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -4,7 +4,7 @@ _gitname=libxtrxdsp
 pkgver=r10.614f52694ac0
 pkgrel=2
 pkgdesc="DSP specific function for SDR in general and XTRX in specific"
-arch=('any')
+arch=('armv7h' 'i686' 'x86_64')
 url="https://github.com/xtrx-sdr/libxtrxdsp"
 license=('LGPL')
 makedepends=('git' 'cmake')
-- 
2.22.0

0002-Fix-building-on-i686.patch:

From cd864f48f102b2a707e4f6cc5f0330df15089d80 Mon Sep 17 00:00:00 2001
From: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org
Date: Sat, 6 Jul 2019 03:58:47 +0200
Subject: [PATCH 2/2] Fix building on i686

Without that, on i686 we have:
  /usr/bin/ld: ../libxtrxdsp.so.0.0.1: undefined reference to xtrxdsp_iq16_ic16i_avx'
  /usr/bin/ld: ../libxtrxdsp.so.0.0.1: undefined reference toxtrxdsp_iq16_ic16i_sse2'
  /usr/bin/ld: ../libxtrxdsp.so.0.0.1: undefined reference to `xtrxdsp_iq16_conv64_sse2'
Signed-off-by: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org
PKGBUILD | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/PKGBUILD b/PKGBUILD
index 238566b..d0f9aac 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -22,8 +22,12 @@ build() {
   cd "$srcdir/$_gitname"
   mkdir -p build
   cd build
+  if [ "$CARCH" = 'i686' ]; then
+    FORCE_ARCH="-DFORCE_ARCH=x86"
+  fi
cmake .. \
+    ${FORCE_ARCH} \
     -DBUILD_SHARED_LIBS=ON \
     -DCMAKE_INSTALL_PREFIX=/usr \
     -DCMAKE_BUILD_TYPE=Release
-- 
2.22.0