Arch Linux User Repository

The below patch doesn't apply anymore. Here's one that does:

diff --git a/cmake/LIEFCompilerFlags.cmake b/cmake/LIEFCompilerFlags.cmake
index 28128496..47004ca5 100644
--- a/cmake/LIEFCompilerFlags.cmake
+++ b/cmake/LIEFCompilerFlags.cmake
@@ -64,8 +64,8 @@ if (NOT MSVC)
   ADD_FLAG_IF_SUPPORTED("-Werror=return-type" ERR_RET_TYPE)


-  ADD_FLAG_IF_SUPPORTED("-fdiagnostics-color=always" DIAGNOSTICS_COLOR)
-  ADD_FLAG_IF_SUPPORTED("-fcolor-diagnostics"        COLOR_DIAGNOSTICS)
+  #ADD_FLAG_IF_SUPPORTED("-fdiagnostics-color=always" DIAGNOSTICS_COLOR)
+  #ADD_FLAG_IF_SUPPORTED("-fcolor-diagnostics"        COLOR_DIAGNOSTICS)
 endif()

 #ADD_FLAG_IF_SUPPORTED("-Wduplicated-cond"         HAS_DUPLICATED_COND)

I'm seeing build failures. It seems that it's passing "-fcolor-diagnostics" to GCC, but only CLANG supports that option. The simple fix was to remove those flags (I assume it only affects build logs). Here's a patch:

diff --git a/cmake/LIEFCompilerFlags.cmake b/cmake/LIEFCompilerFlags.cmake
index 88fbf5f0..a4d35ac7 100644
--- a/cmake/LIEFCompilerFlags.cmake
+++ b/cmake/LIEFCompilerFlags.cmake
@@ -64,9 +64,6 @@ if (NOT MSVC)
   ADD_FLAG_IF_SUPPORTED("-fvisibility=hidden"       VISIBILITY)
   ADD_FLAG_IF_SUPPORTED("-Wno-expansion-to-defined" NO_EXPANSION_TO_DEFINED)

-  ADD_FLAG_IF_SUPPORTED("-fdiagnostics-color=always" DIAGNOSTICS_COLOR)
-  ADD_FLAG_IF_SUPPORTED("-fcolor-diagnostics"        COLOR_DIAGNOSTICS)
-

 endif()
 #ADD_FLAG_IF_SUPPORTED("-Wduplicated-cond"         HAS_DUPLICATED_COND)

Something is strange with this package, it's only building on one core instead all 8 like my makepkg.cfg says. I've been here for an hour now.

2 Questions:
1. What does the *-git mean in AUR packages? I'm new here so that's why I'm asking.
2. Could you please update line 4 to 0.11.5? That's the newest release of LIEF.
Thanks in advance!

Sorry for the late update. Thanks for the suggestions @yuyichao. Shared library should be built properly now.

I've looked at the headers code and json.hpp library is included in "LIEF/json.hpp", so I've left it unchanged. You're right that it should be reported upstream.

This still doesn't seem to provide libLIEF.so, rather the static library libLIEF.a. -DBUILD_SHARED_LIBS=1 is needed for the shared library. (shared library build also needs https://github.com/lief-project/LIEF/pull/365)

The compiled package also contains a extremely generic /usr/lib/json.hpp and it should probably be fixed upstream...

Thanks for reporting, should be fixed in pkgrel 2.

Adding the following to the package function is sufficient to bring the C API back (but I don't think this is necessarily the best solution).

make -C build install DESTDIR="${pkgdir}" install

In particular https://aur.archlinux.org/packages/ddisasm-git/ requires the C API.

This is no longer installing the C headers or /usr/lib/libLIEF.so. It looks like after the change in February to invoke CMake via setup.py the CMake configuration has been changed to not install support for the C API.

edit: typo

It is possible to build the newest version 0.10.1. The following changes work for me, could they be applied?

@@ -1,7 +1,7 @@
 # Maintainer: Dobroslaw Kijowski [dobo] <dobo90_at_gmail.com>

 pkgname=lief
-pkgver=0.9.0
+pkgver=0.10.1
 pkgrel=1
 pkgdesc='Library to instrument executable formats'
 arch=(i686  x86_64)
@@ -15,20 +15,14 @@ md5sums=(SKIP)
 build() {
   cd "${srcdir}/LIEF"

-  mkdir build
+  mkdir -p build
   cd build

   cmake -DCMAKE_BUILD_TYPE=Release ..
   make
-
-  cd "${srcdir}/LIEF/build/api/python"
-  python setup.py build
 }

 package() {
   cd "${srcdir}/LIEF/build"
   make DESTDIR="${pkgdir}" install
-
-  cd "${srcdir}/LIEF/build/api/python"
-  python setup.py install --root="${pkgdir}" --optimize=1
 }