Arch Linux User Repository

Hey! I have found some aspects of your PKGBUILD can be improved as follows:

NOTE: It seems like that GCC 16 produces a slower binary for both the OpenGL renderers. See https://aur.archlinux.org/packages/melonds-git#comment-1071858

• GCC 16 now successfully compiles melonDS, there is no need for using Clang anymore. SEE note above ^

• Consider using -G Ninja and -Wno-dev build options in build() to speed up build times, this is done in melonds-git.

• Add libarchive in depends as suggested by namcap. Also maybe check about qt6-svg usage? Namcap says it might be redundant, though I am not sure.

• Add libslirp in depends and add -DUSE_SYSTEM_LIBSLIRP, an option to use it is present in melonds wifi settings. This is also done in melonds-git.

• Consider using "Source code (tar.gz)" instead of pure git+, this prevents bandwidth wastage and both have the same source code aside from the git and github related files.

Here is a gist with all the above changes incorporated: https://gist.github.com/asyync1024/b854ef71e4b806bd9486184f5b401cb3 Thanks! Please consider incorporating these changes in your PKGBUILD!

1.1-1 won't compile:

-- Checking for module 'faad2'
--   Package 'faad2' not found
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:1093 (message):
  The following required packages were not found:

   - faad2

Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPkgConfig.cmake:1166 (_pkg_check_modules_internal)
  src/frontend/qt_sdl/CMakeLists.txt:88 (pkg_check_modules)


-- Configuring incomplete, errors occurred!
==> ERROR: A failure occurred in build().
    Aborting...
error: failed to build 'melonds-1.1-1':

Installing faad2 solves the issue.

Building the package in a clean chroot reveals that the qt6-svg dependency is missing. Here's the relevant patch (which will hopefully render properly, first time contributing here).

diff --git a/PKGBUILD b/PKGBUILD
index 7f1e8d4..e57cc15 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -10,7 +10,7 @@ arch=("x86_64" "i686" "pentium4" "armv7h" "aarch64")
 url="http://melonds.kuribo64.net/"
 license=("GPL-3.0-or-later")
 makedepends=("wayland" "git" "cmake" "pkg-config" "extra-cmake-modules" "clang")
-depends=("qt6-base" "qt6-multimedia" "sdl2" "enet" "libx11" "libglvnd" "hicolor-icon-theme")
+depends=("qt6-base" "qt6-multimedia" "qt6-svg" "sdl2" "enet" "libx11" "libglvnd" "hicolor-icon-theme")
 source=("$pkgname::git+https://github.com/melonDS-emu/melonDS.git#tag=${pkgver}")
 sha256sums=('414b376e14a66d8e095605b83a6b7711c04330be159b2649c87213fe8af0c9c6')

diff --git a/.SRCINFO b/.SRCINFO
index 900847b..50fa461 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -17,6 +17,7 @@ pkgbase = melonds
    makedepends = clang
    depends = qt6-base
    depends = qt6-multimedia
+   depends = qt6-svg
    depends = sdl2
    depends = enet
    depends = libx11

@d-air1 On the contrary, since this release appears to be labeled as a full new release both on the main page and GitHub, I would argue that the package actually should be updated to 1.0 RC, even though by definition release candidates should be considered pre-releases.

@hcorion What do you think? Also, I don't actively use Arch right now so I wouldn't be able to update the package with proper testing.

I see that both melonds and melonds-bin have been flagged out of date because of the release candidate. A release candidate is not a stable release and if someone wants to use those versions then a separate package should be made. This should be unflagged.

Hello, I have the following patch:

1. Update to 1.0rc
2. Remove arm and armv6h as they are not ARCHs for PKGBUILDs
3. Change the license() to be SDPX compliant
4. Add wayland as a makedepends() as CMake looks for it during the configuration process.
5. Add libarchive, enet, gcc-libs, libx11, libglvnd, zstd, and hicolor-icon-theme to depends()
6. Remove libepoxy and libslrip as it appears melonDS no longer requires it
7. Make the build() and install() more compliant to the CMake guidelines. This means using -B to avoid having to use mkdir, and setting -DCMAKE_BUILD_TYPE to NONE.
8. Clone the git repo with the name $pkgname so no need to create an extra variable.

diff --git a/PKGBUILD b/PKGBUILD
index f5b0e2e..df2fa7c 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -3,38 +3,34 @@
 # Maintainer: Harrison <htv04rules at gmail dot com>

 pkgname=melonds
-pkgver=0.9.5
-pkgrel=6
+pkgver=1.0rc
+pkgrel=1
 pkgdesc="DS emulator, sorta"
-arch=("x86_64" "i686" "pentium4" "arm" "armv6h" "armv7h" "aarch64")
+arch=("x86_64" "i686" "pentium4" "armv7h" "aarch64")
 url="http://melonds.kuribo64.net/"
-license=("GPL3")
-makedepends=("git" "cmake" "pkg-config" "extra-cmake-modules")
-depends=("libepoxy" "libslirp" "qt6-base" "qt6-multimedia" "sdl2")
-source=("git+https://github.com/melonDS-emu/melonDS.git#tag=${pkgver}"
-        "dont-fix-libslirp-interface.patch")
-sha256sums=("SKIP"
-            "1c157d21f89a750140727b2906abbd340a7e21257dd7eaeebdc60cf71ed82770")
+license=("GPL-3.0-or-later")
+makedepends=("wayland" "git" "cmake" "pkg-config" "extra-cmake-modules")
+depends=("qt6-base" "qt6-multimedia" "sdl2" "libarchive" "enet" "gcc-libs" "glibc" "libx11" "libglvnd" "zstd" "hicolor-icon-theme")
+source=("$pkgname::git+https://github.com/melonDS-emu/melonDS.git#tag=${pkgver}")
+sha256sums=('cacc8af180b3d64a6d447afe5d5305ec4de7b7b95e28614d4037b0944b5bad51')

 prepare() {
-  cd melonDS
-  git cherry-pick -n e63e29ca91ba5fc1630634fbb9f064b9cce6cc1f # Fix build with GCC 14
-  patch -p1 -i ../dont-fix-libslirp-interface.patch
+  cd $pkgname
 }

 build() {
-  mkdir -p build
-  cd build
-  
-  cmake ../melonDS \
-    -DCMAKE_BUILD_TYPE=Release \
-    -DCMAKE_INSTALL_PREFIX="/usr" \
-    -DUSE_QT6=ON
-  cmake --build .
+  cd "$srcdir"
+
+  cmake -B build -S $pkgname \
+  -DCMAKE_BUILD_TYPE=None \
+  -DCMAKE_INSTALL_PREFIX=/usr \
+  -DUSE_QT6=ON
+
+  cmake --build build
 }

 package() {
-  cd build
-  
-  DESTDIR="${pkgdir}" cmake --install .
+  cd "$srcdir"
+
+  DESTDIR="$pkgdir" cmake --install build
 }
diff --git a/dont-fix-libslirp-interface.patch b/dont-fix-libslirp-interface.patch
deleted file mode 100644
index 326c2ba..0000000
--- a/dont-fix-libslirp-interface.patch
+++ /dev/null
@@ -1,13 +0,0 @@
-diff --git a/src/frontend/qt_sdl/CMakeLists.txt b/src/frontend/qt_sdl/CMakeLists.txt
-index 6b964f33..cd907f05 100644
---- a/src/frontend/qt_sdl/CMakeLists.txt
-+++ b/src/frontend/qt_sdl/CMakeLists.txt
-@@ -88,7 +88,7 @@ pkg_check_modules(SDL2 REQUIRED IMPORTED_TARGET sdl2)
- pkg_check_modules(Slirp REQUIRED IMPORTED_TARGET slirp)
- pkg_check_modules(LibArchive REQUIRED IMPORTED_TARGET libarchive)
- 
--fix_interface_includes(PkgConfig::SDL2 PkgConfig::Slirp PkgConfig::LibArchive)
-+fix_interface_includes(PkgConfig::SDL2 PkgConfig::LibArchive)
- 
- add_compile_definitions(ARCHIVE_SUPPORT_ENABLED)
- 

@dansecob fix applied!

@mifori libslirp is used for online play.

This PKGBUILD relies on make as the CMake backend, so it fails on any system that configures CMake with ninja as the backend. This patch replaces make calls with CMake calls, to be backend agnostic.

@@ -25,11 +25,11 @@ build() {
   cmake ../melonDS \
     -DCMAKE_BUILD_TYPE=Release \
     -DCMAKE_INSTALL_PREFIX="/usr"
-  make VERBOSE=ON
+  cmake --build .
 }

 package() {
   cd build

-  make DESTDIR="${pkgdir}" install
+  DESTDIR="${pkgdir}" cmake --install .
 }

Why does this depend on libslirp?

git url is now https://github.com/melonDS-emu/melonDS