Package Details: mkosi-git 9.r1.g9fc158c-1

Git Clone URL: https://aur.archlinux.org/mkosi-git.git (read-only, click to copy)
Package Base: mkosi-git
Description: Build Legacy-Free OS Images
Upstream URL: https://github.com/systemd/mkosi
Licenses: LGPL2.1
Conflicts: mkosi
Provides: mkosi
Submitter: falconindy
Maintainer: lucaswerkmeister
Last Packager: lucaswerkmeister
Votes: 4
Popularity: 0.001594
First Submitted: 2016-07-16 02:20
Last Updated: 2021-01-05 07:56

Dependencies (24)

Required by (0)

Sources (1)

Latest Comments

1 2 Next › Last »

lucaswerkmeister commented on 2020-12-13 14:01

TOCTOU stands for “time-of-check to time-of-use” – it’s theoretically possible (though admittedly not likely) that the pandoc command becomes available or unavailable between the check (command -v pandoc) and the use (pandoc …). It’s better to try running pandoc directly, and handle a “command not found” error after it happens, than trying to predict whether it will be found or not (which does not guarantee that it will still be found when we try to actually run it).

willemw commented on 2020-12-13 13:58

@lucaswerkmeister: Can you explain that? I like to know why that is.

lucaswerkmeister commented on 2020-12-13 13:46

@willemw: No, that’s a TOCTOU race condition.

willemw commented on 2020-12-13 13:33

@lucaswerkmeister: Instead of the "# try to build the manpage ..." section, you could do:

command -v pandoc > /dev/null && pandoc -s -f markdown -t man mkosi.md -o mkosi.1

willemw commented on 2020-12-13 13:20

@lucaswerkmeister: or remove 'pandoc' from 'makedepends' and add a comment or a (colored) build message that it is an optional autodetected make dependency. Then we can run 'make -si' or an AUR helper as usual and are not forced to run 'makepkg --nodeps' separately (which could break the build).

lucaswerkmeister commented on 2020-12-08 23:16

@jshap I’ve updated the build script so it handles missing pandoc without failing. There’s no way to mark the dependency as optional as far as I’m aware, but you should be able to build a manpage-less version of the package with makepkg -d now.

lucaswerkmeister commented on 2019-01-29 23:38

@jshap70 I’m really not a fan of separate documentation packages – I find them very annoying in Debian, and I have the impression they’re much less widespread in Arch.

Making it optional in the build sounds more acceptable to me – declare pandoc as an optional dependency and change the build script so it doesn’t fail if the manpage can’t be built. Still not convinced it’s necessary, though, to be honest.

jshap commented on 2019-01-29 02:42

can we talk about maybe removing that manpage? or making it optional in the build? In all, pandoc and it's haskell-deps is 417.21 MiB of extra requirements, which pretty annoying for something which by definition is just "a fancy wrapper around... pacstrap".

Maybe we can split it out into a mkosi-docs-git package?

lucaswerkmeister commented on 2019-01-10 21:43

@S13ntist great, thanks a lot for the patch! I’ve taken the liberty to split it into several commits (keeping you as the author), I hope you don’t mind.

S13ntist commented on 2019-01-10 20:03

Hi, since https://github.com/systemd/mkosi/pull/308 mkosi now includes a man page. The bad news is that you need to generate it yourself, via pandoc.

Can you please include the patch here: https://gist.github.com/brunnre8/4bb37277082dca2b5c826f55338474de