Arch Linux User Repository

Test the GTK4 version:

NICOTINE_GTK_VERSION=4 nicotine

Test the Gtk 4 version with Libadwaita:

NICOTINE_GTK_VERSION=4 NICOTINE_LIBADWAITA=1 nicotine

Desktop files are now included for both.

nicotine-plus-git 3.3.0.dev4.r8629.897858496-1 build fails with "AttributeError: 'PathDistribution' object has no attribute 'key'". Full output here: https://pastebin.com/vwUm7kXd

@duvel71: Fixed.

Those two added files break the installation:

==> Retrieving sources...
  -> Updating nicotine-plus git repo...
  -> Found org.nicotine_plus.Nicotine-gtk4.desktop
  -> Found org.nicotine_plus.Nicotine-libadwaita.desktop
==> Validating source files with sha256sums...
    nicotine-plus ... Skipped
    org.nicotine_plus.Nicotine-gtk4.desktop ... FAILED
    org.nicotine_plus.Nicotine-libadwaita.desktop ... FAILED
==> ERROR: One or more files did not pass the validity check!

Edit: This problem is now fixed on a clean build, thanks.

==> Starting pkgver()...
==> ERROR: pkgver is not allowed to contain colons, forward slashes, hyphens or whitespace.
==> ERROR: pkgver() generated an invalid version: po/nb_NO.po:7: warning: header field 'Project-Id-Version' still has the initial default value
po/tr.po:7: warning: header field 'Project-Id-Version' still has the initial default value
3.2.0.dev1.r5888.5f79d641

Maybe just stick to a normal pkgver?

https://wiki.archlinux.org/title/VCS_package_guidelines#The_pkgver()_function

katt@main ~ » git -C /mnt/jupiter/etc/makepkg/sources/nicotine-plus describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
3.1.1.r516.g5f79d641

Test the GTK4 version:

NICOTINE_GTK_VERSION=4 nicotine

Test the Gtk 4 version with Libadwaita:

NICOTINE_GTK_VERSION=4 NICOTINE_LIBADWAITA=1 nicotine

Desktop files are now included for both.

@BachoSeven: I can't reproduce that in a clean chroot. Make sure you're doing a clean build.

@yochananmarqos Shares unit test is failing with:

================================================= FAILURES ==================================================
_____________________________________________ test_shares_scan ______________________________________________

    def test_shares_scan():
        """ Test a full shares scan """

        config = Config("temp_config", DB_DIR)
        config.sections["transfers"]["shared"] = [("Shares", SHARES_DIR)]

        shares = Shares(None, config, queue.Queue(0))
        shares.rescan_shares()

        # Verify that modification time was saved for shares folder
>       assert SHARES_DIR in list(config.sections["transfers"]["sharedmtimes"])
E       AssertionError: assert '/home/fra/.cache/paru/clone/nicotine-plus-git/src/nicotine-plus/test/unit/shares/sharedfiles' in []
E        +  where [] = list(<shelve.Shelf object at 0x7f953f355ee0>)

test/unit/shares/test_shares.py:49: AssertionError
------------------------------------------- Captured stdout call --------------------------------------------
[2021-01-27 19:35:53] Can't create directory '', reported error: [Errno 2] No such file or directory: ''
_______________________________________ test_hidden_file_folder_scan ________________________________________

    def test_hidden_file_folder_scan():
        """ Test that hidden files and folders are excluded """

        config = Config("temp_config", DB_DIR)
        config.sections["transfers"]["shared"] = [("Shares", SHARES_DIR)]

        shares = Shares(None, config, queue.Queue(0))
>       shares.rescan_shares()

test/unit/shares/test_shares.py:88:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
pynicotine/shares.py:283: in rescan_shares
    self._rescan_shares("normal", rebuild)
pynicotine/shares.py:322: in _rescan_shares
    self.rescan_dirs(
pynicotine/shares.py:401: in rescan_dirs
    self.get_files_index(sharestype, newsharedfiles)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <pynicotine.shares.Shares object at 0x7f953f37c640>, sharestype = 'normal', sharedfiles = {}

    def get_files_index(self, sharestype, sharedfiles):
        """ Update Search index with new files """

        """ We dump data directly into the file index shelf to save memory """
        if sharestype == "normal":
            section = target = "fileindex"
        else:
            section = "bfileindex"
            target = "buddyfileindex"

>       self.config.sections["transfers"][section].close()
E       AttributeError: 'dict' object has no attribute 'close'

pynicotine/shares.py:720: AttributeError

@rwd2: I've disabled the test for now.

Build fails with:

running build_scripts
creating build/scripts-3.9
copying and adjusting nicotine -> build/scripts-3.9
changing mode of build/scripts-3.9/nicotine from 644 to 755
==> Starting check()...
Traceback (most recent call last):
  File "/home/user1/documents/aur/nicotine-plus-git/src/nicotine-plus/./nicotine", line 279, in <module>
    run()
  File "/home/user1/documents/aur/nicotine-plus-git/src/nicotine-plus/./nicotine", line 240, in run
    version()
  File "/home/user1/documents/aur/nicotine-plus-git/src/nicotine-plus/./nicotine", line 101, in version
    print(_("Nicotine+ version %s") % pynicotine.utils.version)
NameError: name '_' is not defined
==> ERROR: A failure occurred in check().
    Aborting...