Arch Linux User Repository

This needs an update! It has a bug in it which has been fixed in master.. I reported it and they said it needs fixing here, it's already been fixed and this is out of date

unable to build since a few commits,

================================================================================================================== FAILURES ===================================================================================================================
________________________________________________________________________________________________________ StartupTest.test_gui_startup _________________________________________________________________________________________________________

self = <pynicotine.tests.integration.test_startup.StartupTest testMethod=test_gui_startup>

    def test_gui_startup(self):
        """Verify that regular GUI startup works."""

        command = [sys.executable, "-m", "pynicotine", f"--config={CONFIG_FILE}", f"--user-data={DATA_FOLDER_PATH}",
                   "--ci-mode"]
        broadway_display = ":1000"
        broadway_process = None
        is_success = False

        if sys.platform not in {"darwin", "win32"}:
            # Display server is required, use GDK's Broadway backend if available.
            # If not available, leave it up to the user to run the tests with e.g. xvfb-run.

            # pylint: disable=consider-using-with
            try:
                broadway_process = subprocess.Popen(["gtk4-broadwayd", broadway_display])

            except Exception:
                try:
                    broadway_process = subprocess.Popen(["broadwayd", broadway_display])

                except Exception:
                    pass

        if broadway_process is not None:
            os.environ["GDK_BACKEND"] = "broadway"
            os.environ["BROADWAY_DISPLAY"] = broadway_display

        with subprocess.Popen(command) as process:
            try:
                process.wait(timeout=5)

            except subprocess.TimeoutExpired:
                is_success = True
                process.terminate()

        if broadway_process is not None:
            broadway_process.terminate()
            broadway_process.wait()

>       self.assertTrue(is_success)
E       AssertionError: False is not true

pynicotine/tests/integration/test_startup.py:76: AssertionError
------------------------------------------------------------------------------------------------------------ Captured stdout call -------------------------------------------------------------------------------------------------------------
Listening on /run/user/1000/broadway1001.socket
[04/27/24 20:52:18] Loading Python 3.12.3
[04/27/24 20:52:18] Loading Nicotine+ 3.3.3rc2
[04/27/2024 08:52:18 PM] Loading GTK 3.24.41
------------------------------------------------------------------------------------------------------------ Captured stderr call -------------------------------------------------------------------------------------------------------------

(org.nicotine_plus.Nicotine:3440661): Gtk-WARNING **: 20:52:18.438: cannot open display: :1
=========================================================================================================== short test summary info ===========================================================================================================
FAILED pynicotine/tests/integration/test_startup.py::StartupTest::test_gui_startup - AssertionError: False is not true
======================================================================================================== 1 failed, 61 passed in 16.22s ========================================================================================================
==> ERROR: A failure occurred in check().
    Aborting...
 -> error making: nicotine-plus-git-exit status 4
 -> Failed to install the following packages. Manual intervention is required:
nicotine-plus-git - exit status 4

Launching Nicotine on wayland gives out the following critical error: Nicotine+ Version: 3.3.0rc3 GTK Version: 4.12.5 Python Version: 3.11.6 (linux)

Type: <class 'BufferError'> Value: Existing exports of data: object cannot be re-sized Traceback: File "/usr/lib/python3.11/site-packages/pynicotine/gtkgui/application.py", line 848, in _raise_exception raise exc_value File "/usr/lib/python3.11/threading.py", line 1045, in _bootstrap_inner self.run() File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 2685, in run self._process_ready_sockets(current_time) File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 2456, in _process_ready_sockets self._process_ready_input_socket(sock, current_time) File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 2411, in _process_ready_input_socket self._process_conn_incoming_messages(conn_obj_established) File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 2467, in _process_conn_incoming_messages self._process_server_input(conn_obj) File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 1307, in _process_server_input self._send_message_to_server(ServerDisconnect()) File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 1518, in _send_message_to_server self._process_outgoing_message(message) File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 2539, in _process_outgoing_message process_func(msg_obj) File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 2301, in _process_internal_messages self._server_disconnect() File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 1479, in _server_disconnect self._close_connection(self._conns, sock) File "/usr/lib/python3.11/site-packages/pynicotine/slskproto.py", line 937, in _close_connection conn_obj.ibuf.clear()

Current build of nicotine-plus-git-3.3.0.dev5.r9733.7283cea53 crashes for me couple seconds after launch. Went back to the nicotine+ package which seems to work.

Gtk:ERROR:../gtk/gtk/deprecated/gtktreeview.c:12838:gtk_tree_view_is_blank_at_pos: code should not be reached
Bail out! Gtk:ERROR:../gtk/gtk/deprecated/gtktreeview.c:12838:gtk_tree_view_is_blank_at_pos: code should not be reached

nicotine-plus-git 3.3.0.dev4.r8629.897858496-1 build fails with "AttributeError: 'PathDistribution' object has no attribute 'key'". Full output here: https://pastebin.com/vwUm7kXd

@duvel71: Fixed.

Those two added files break the installation:

==> Retrieving sources...
  -> Updating nicotine-plus git repo...
  -> Found org.nicotine_plus.Nicotine-gtk4.desktop
  -> Found org.nicotine_plus.Nicotine-libadwaita.desktop
==> Validating source files with sha256sums...
    nicotine-plus ... Skipped
    org.nicotine_plus.Nicotine-gtk4.desktop ... FAILED
    org.nicotine_plus.Nicotine-libadwaita.desktop ... FAILED
==> ERROR: One or more files did not pass the validity check!

Edit: This problem is now fixed on a clean build, thanks.

==> Starting pkgver()...
==> ERROR: pkgver is not allowed to contain colons, forward slashes, hyphens or whitespace.
==> ERROR: pkgver() generated an invalid version: po/nb_NO.po:7: warning: header field 'Project-Id-Version' still has the initial default value
po/tr.po:7: warning: header field 'Project-Id-Version' still has the initial default value
3.2.0.dev1.r5888.5f79d641

Maybe just stick to a normal pkgver?

https://wiki.archlinux.org/title/VCS_package_guidelines#The_pkgver()_function

katt@main ~ » git -C /mnt/jupiter/etc/makepkg/sources/nicotine-plus describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
3.1.1.r516.g5f79d641

Test the GTK4 version:

NICOTINE_GTK_VERSION=4 nicotine

Test the Gtk 4 version with Libadwaita:

NICOTINE_GTK_VERSION=4 NICOTINE_LIBADWAITA=1 nicotine

Desktop files are now included for both.

@BachoSeven: I can't reproduce that in a clean chroot. Make sure you're doing a clean build.