Arch Linux User Repository

Thanks @pmattern that makes sense. nomacs stopped working on all my systems and needed to be re-built, so just sharing it if anyone else needs it.

I was already tracking that PR.
But I'd expect it to land in master soon, so if the patch was included in PKGBUILD now, it probably had to be ditched again in just a couple of days. Also, I guess some people may want to stick with master itself only and use one of the workarounds.
So I'd rather still leave the package as is but stay tuned as explained in my previous comment.

There is a pull request upstream that fixes the bug. I tested and builds fine. You can apply it by modifying this PKGBUILD with this or something similar.

@ PKGBUILD:17 @ optdepends=('qt6-imageformats: read ICNS, MNG, TGA, TIFF, WBMP, WEBP'
 makedepends=('git' 'cmake' 'qt6-tools')
 provides=("$_pkgname")
 conflicts=("$_pkgname")
-source=("git+https://github.com/$_pkgname/$_pkgname.git")
-sha256sums=("SKIP")
+source=("git+https://github.com/$_pkgname/$_pkgname.git"
+        "opencv5.patch::https://github.com/nomacs/nomacs/pull/1622.patch")
+sha256sums=('SKIP'
+            'f509419f3ae78223ac83da4e582e3eb44620dd39bbbcee65028fdf29a992da92')

 export GIT_LFS_SKIP_SMUDGE=1

@ PKGBUILD:29 @ pkgver() {
   git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
 }

+prepare() {
+  cd "$_pkgname"
+  patch -Np1 -i "${srcdir}/opencv5.patch"
+}
+
 build() {
   rm -Rf build && mkdir build
   cd build

The package currently fails to build as the upstream code is incompatible with OpenCV 5.x. The problem is already acknowledged as a bug.

Possible workarounds are (i) disable OpenCV by adding a CMake option -DENABLE_OPENCV=OFF (ii) build against OpenCV 4.x by using the package from archive.archlinux.org or establishing the package within the AUR.

All in all I believe for the time being it's best to leave the package as-is and have users make their choice. If the upstream bug shouldn't be dealt with in a reasonable time, we can still adapt the package one way or another.

/tmp/makepkg/nomacs-git/src/nomacs/ImageLounge/src/DkGui/DkDialog.cpp:95:10: fatal error: opencv2/imgproc/imgproc_c.h: No such file or directory
   95 | #include "opencv2/imgproc/imgproc_c.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Hello pmattern

git-lfs need to be added to makedepends, otherwise it will give command not found

==> Extracting sources...
  -> Creating working copy of nomacs git repo...
Cloning into 'nomacs'...
done.
git-lfs filter-process: line 1: git-lfs: command not found

For pkgver() please use --long --tags instead of --always, for my personal VCS pkgbuild I'm using git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g' copied from archwiki

It will give 3.17.2287.r0.g9eedbb1c 3.17.2287 is the current tag, your give 3.2.0

About the python error I got it in the recent past, you need to launch the build from nomacs directory, see:

• https://github.com/FabioLolix/PKGBUILD-AUR_fix/blob/master/n/nomacs-git/PKGBUILD
• https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=nomacs

FabioLolix
Adding python to makedepends is only triggering a bunch of error messages here. Doesn't seem to make sense right now.

fenugrec
When you posted your comment nomacs couldn't be built without plugins. I can reproduce your error message trying to compile the then current commit right now. In recent commits, including the plugins is no longer a must, though.
Basically, a VCS package should provide stuff like those plugins. Given that their official repo is postponed for quite a while I'm not sure these particular plugins are really desirable here, though.

Hello, this builds with devtools but fail with makepkg

  -> Creating working copy of nomacs git repo...
Cloning into 'nomacs'...
done.
Downloading ImageLounge/3rdparty/win-binaries/qjp2.dll (581 KB)
Error downloading object: ImageLounge/3rdparty/win-binaries/qjp2.dll (8252a8e): Smudge error: Error downloading ImageLounge/3rdparty/win-binaries/qjp2.dll (8252a8e8056ca3842db7cc6de437a7330e302cab508390b8738f13275ad95d50): error transferring "8252a8e8056ca3842db7cc6de437a7330e302cab508390b8738f13275ad95d50": [0] remote missing object 8252a8e8056ca3842db7cc6de437a7330e302cab508390b8738f13275ad95d50

Errors logged to '/home/fabio/Dev/pkg_make/TOBUILD/nomacs-git/nomacs-git/src/nomacs/.git/lfs/logs/20230513T135741.271889392.log'.
Use `git lfs logs last` to view the log.
error: external filter 'git-lfs filter-process' failed
fatal: ImageLounge/3rdparty/win-binaries/qjp2.dll: smudge filter lfs failed
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

==> ERROR: Failure while creating working copy of nomacs git repo

python could be added as makedepends

-- QUAZIP: QuaZip-1 for Qt5 found
CMake Warning at CMakeLists.txt:208 (message):
  Python not found: the version number will be incorrect!

Consider adding export GIT_LFS_SKIP_SMUDGE=1 to the pkgbuild (not in function) because upstream uses LFS and fails during sources extraction stage.