Arch Linux User Repository

You're right. Maybe also remove git as an optdepend.

1. fair enough
2. I thought themes and plugins are updated with this package, not separately. At least bundled ones, users should handle their themes/plugins on their own.

1. Python is actually used in certain bundled plugins. Ruby isn't.
2. Themes, plugins and ohmyzsh usually distribute their plugins' updates through git.

1. It should be consistent - either remove python as well or let ruby stay.
2. What does "most updates are distributed through git" mean?

I've just tried removing ruby, none of my plugins broke. Here's a patch file for changing the optdepends: (no new pkgrel needed as it changes nothing)

--- a/PKGBUILD
+++ b/PKGBUILD
@@ -14,11 +14,9 @@
 license=('MIT')
 depends=('zsh')
 makedepends=('git')
-optdepends=('ruby: for some plugin functionality'
-            'python: for some plugin functionality'
-            'zsh-theme-powerlevel10k: great theme'
-            'bullet-train-oh-my-zsh-theme-git: better powerline theme'
-            'git: most themes use git (highly recommended but still optional)')
+optdepends=('python: for some plugin functionality'
+            'zsh-theme-powerlevel10k-bin-git: great theme'
+            'git: most updates are distributed through git')
 install=${pkgname}.install
 source=("${pkgname}::git+https://github.com/ohmyzsh/ohmyzsh.git"
         '0001-zshrc.patch')

Yes I'm on aur-general so I'll follow the thread if anything pops up.

By give it a shot I meant to locally remove ruby from dependencies and see if anything breaks, but as I said I think it is informative only. Same goes for powerline - migrate it to powerlevel10k and share a patch with us.

Hmm, that makes more sense. What do you mean by "feel free to give it a shot", though? Only the package's maintainer has access to changing the files.

Rein Fernhout's is the only reply I've gotten from aur-general so far.

Also, doesn’t getting stuff from the AUR already require git? We don’t need to include that either, do we

You cannot assume someone has git. You might want to build packages on a different system an distribute them.

As for the other (ruby, python) idk. I don't use powerline nor ruby, feel free to give it a shot. I think it is informative - "ruby as optdepend: hey it looks like it's got some tasty ruby plugins".

Let's see what "[aur-general]" has to say about this issue, thanks for posting there. As I said this package shall follow the will of the people using it if only it's valid.

Just one thing I wanted to clarify. Using upstream's install.sh in /bin would be a disaster as bad as curl|bash. I meant to put there the same stuff you want to put in the post-install script, but it could actually allow copying the template zshrc.

I think a message in the postinstall script is the right way to go here, as many other packages do.

However I could've also missed that message, as it is a bit overshadowed by the optional dependencies displayed right after. Why not also echo a couple of newlines and maybe some ##### bars to draw the attention?

—Rein Fernhout

Speaking of which, shouldn’t the powerline themes be replaced with the actually maintained powerlevel10k? And I don’t think ruby should be included, anything that uses Ruby can include it as their own dependent. Also, doesn’t getting stuff from the AUR already require git? We don’t need to include that either, do we?

Thanks for responding!

I would give more weight to your arguments regarding the postinstall message if there wasn't one already. The current one is VERY suspicious, and I suggest to either remove it or clarify it. postinstall is also where post-install echos go (I've asked that on aur-general before), and many packages have used this place for additional instructions.

I get the impression that install.sh is the official install script. I don't think we should symlink that to oh-my-zsh-something. At most, it should echo the instructions.

Plus, I think this is a worse solution than simply putting a message in the postinstall on both merits and practicality. No matter how much people try it, there will be less people who try to tab-complete than those who read the postinstall messages, and nowhere in "know your system" do I see "blindly try tab-completions"; not to mention this package's name is oh-my-zsh-git, not ohmyzsh-git. Yes, ohmyzsh is the official name, but I don't expect users to know that. We cannot rely on users having hyphen completions enabled.

Anyways, I've send a copy of this to aur-general with you two as Cc's. Cheers!