Package Details: onlyoffice-bin 8.0.0-2

Git Clone URL: https://aur.archlinux.org/onlyoffice-bin.git (read-only, click to copy)
Package Base: onlyoffice-bin
Description: An office suite that combines text, spreadsheet and presentation editors
Upstream URL: https://www.onlyoffice.com/
Licenses: AGPL-3.0-only
Conflicts: onlyoffice
Provides: onlyoffice
Submitter: mikalair
Maintainer: dbermond (Antiz)
Last Packager: dbermond
Votes: 196
Popularity: 6.02
First Submitted: 2016-11-17 12:33 (UTC)
Last Updated: 2024-02-17 15:36 (UTC)

Latest Comments

1 2 3 4 5 6 .. 13 Next › Last »

Antiz commented on 2024-02-17 15:37 (UTC) (edited on 2024-02-17 15:50 (UTC) by Antiz)

It was initially done this way to avoid the need of extracting the archive in a buffer directory first and then move the content in $pkgdir when we could just extract it directly in $pkgdir.
Anyway, the package was reworked to allow the patching of the desktop file ;)

However, I'd still like to say that this is an upstream issue that is not specific to this particular AUR package but common to every only-office packages there is (including the official Flatpak one).
The proper way to have this issue fixed once and for all would be to have it addressed on upstream side, which would be beneficial to every only-office downstream packages there is (not only this particular AUR one).

So regardless of this AUR package being now patched, I'd still encourage one to submit this patch to upstream in a pull request or through the upstream issue currently opened on that matter. That would be a helpful step toward a proper fix for that issue :)

bobi commented on 2024-02-17 11:18 (UTC) (edited on 2024-02-17 11:19 (UTC) by bobi)

Maybe you should rather remove the noextract so that makepkg inflates the whole deb content for you and you can focus only on preparing (e.g., patching some files from the deb) then packaging, instead of chaining two bsdtar calls in prepare() then package() to actually extract the content in the first place.

But perhaps there’s a good reason that I’m missing here for not relying on makepkg default extract feature.

Antiz commented on 2024-02-17 08:58 (UTC) (edited on 2024-02-17 09:01 (UTC) by Antiz)

@bobi The desktop file is contained within an archive (itself contained within the deb archive).
The said archive is extracted as part of the package function, and patching files should be done during the prepare function instead.

Once again, since this is a precompiled (-bin) package taken from the .deb archive, we do not have access to sources in prepare() and thus cannot patch anything.
This should be fixed upstream, please submit the patch there instead of here :)

bobi commented on 2024-02-17 08:19 (UTC) (edited on 2024-02-17 08:33 (UTC) by bobi)

@begin-theadventu: Yes, something along that should def be part of the PKGBUILD. That or using a patch file.

That definitely can be integrated in the PKGBUILD since the desktop file exists as-is in the deb archive (expectedly at ./usr/share/applications/onlyoffice-desktopeditors.desktop)

begin-theadventu commented on 2024-02-17 00:30 (UTC)

@bobi sed -i -E "s|Exec=/usr/bin/onlyoffice-desktopeditors %U|Exec=/usr/bin/onlyoffice-desktopeditors %F|g" onlyoffice-desktopeditors.desktop

bobi commented on 2024-02-16 14:47 (UTC) (edited on 2024-02-17 08:45 (UTC) by bobi)

Alternatively a decent way around would be to patch the .desktop file.

Basically:

9c9
< Exec=/usr/bin/onlyoffice-desktopeditors %U
---
> Exec=/usr/bin/onlyoffice-desktopeditors %F

Confirmed working there: https://forum.endeavouros.com/t/pcmanfm-open-and-save-files-with-onlyoffice/36490

Edit: realized this was also already addressed by @Freed below. This patch is definitely possible here, since desktop files are part of the post-compile files.

dbermond commented on 2023-11-26 01:12 (UTC)

@Freed We cannot patch anything from https://github.com/ONLYOFFICE/desktop-apps/ since this is a pre-compiled (-bin) package. This should be fixed by upstream.

Freed commented on 2023-11-25 08:23 (UTC) (edited on 2023-11-25 08:28 (UTC) by Freed)

How about add a patch like https://github.com/ONLYOFFICE/DesktopEditors/issues/872#issuecomment-1826252473 to fix #872?

And

diff --git a/onlyoffice-desktopeditors.desktop b/onlyoffice-desktopeditors.desktop
index cd71aad..96c6d4a 100644
--- a/onlyoffice-desktopeditors.desktop
+++ b/onlyoffice-desktopeditors.desktop
@@ -6,7 +6,7 @@ GenericName[ru]=Редактор документов
 Comment=Edit office documents
 Comment[ru]=Редактировать офисные документы
 Type=Application
-Exec=/usr/bin/onlyoffice-desktopeditors %U
+Exec=/usr/bin/onlyoffice-desktopeditors %F
 Terminal=false
 Icon=onlyoffice-desktopeditors
 Keywords=Text;Document;OpenDocument Text;Microsoft Word;Microsoft Works;odt;doc;docx;rtf;

Because onlyoffice-desktopeditores only support full path.

Antiz commented on 2023-11-01 10:50 (UTC)

The latest 7.5.1 upstream release does not contain any other assets than the macos' dmg files at the moment, meaning that the deb file/archive used as a source for the onlyoffice AUR package is not (yet) available.

I opened an upstream issue here. The version 7.5.1 can only be packaged and released once upstream adds the deb artifact to the release.
Thanks for your patience! :)

dbermond commented on 2023-10-19 18:11 (UTC)

@Krator The new upstream version was released just a few hours, so there is no need for all this rush. The package is updated when the maintainer have time to do so. Please notice that package maintainers also have a life, a work, a family and a lot of other tasks in real life, so please be patient while the maintainer takes the time for updating. That being said, I'm pushing the update now.