Arch Linux User Repository

Same here, changing to Exec=openfortigui in /usr/share/applications/openfortigui.desktop fixes the non-working desktop shortcut bug.

I agree with aborigines but:

If I use Exec=/usr/bin/openfortigui it does not work but if I only use Exec=openfortigui it works...

hi macfly

in user-env.patch this line is wrong

Exec=/usr/bin/sudo /usr/bin/openfortigui

should be

Exec=/usr/bin/openfortigui

ps. after update can't start openfortigui with the menu

Sorry, I'd upgraded my Arch and haven't reboot, after a reboot it got fixed, one of these packages broke the compilation.

upgraded systemd-libs (245.6-7 -> 245.6-8)
upgraded lib32-libelf (0.179-1 -> 0.180-1)
upgraded rsync (3.2.0-1 -> 3.2.1-1)
upgraded systemd (245.6-7 -> 245.6-8)
upgraded systemd-sysvcompat (245.6-7 -> 245.6-8)

I just want to say thanks. Upgraded to new version with no issues. No problem with compilation.

And these:

proc/vpnworker.cpp: In function ‘int pppd_run(tunnel*)’:
<command-line>: error: expected primary-expression before ‘/’ token
proc/vpnworker.cpp:173:36: note: in expansion of macro ‘PPP_PATH’
  173 |     static const char ppp_path[] = PPP_PATH;
      |                                    ^~~~~~~~
<command-line>: error: ‘usr’ was not declared in this scope
proc/vpnworker.cpp:173:36: note: in expansion of macro ‘PPP_PATH’
  173 |     static const char ppp_path[] = PPP_PATH;
      |                                    ^~~~~~~~
<command-line>: error: ‘sbin’ was not declared in this scope
proc/vpnworker.cpp:173:36: note: in expansion of macro ‘PPP_PATH’
  173 |     static const char ppp_path[] = PPP_PATH;
      |                                    ^~~~~~~~
<command-line>: error: ‘pppd’ was not declared in this scope
proc/vpnworker.cpp:173:36: note: in expansion of macro ‘PPP_PATH’
  173 |     static const char ppp_path[] = PPP_PATH;
      |                                    ^~~~~~~~

Thanks on updating!

Although it gives me these errors:

openfortivpn/src/userinput.c: In function ‘read_password’:
openfortivpn/src/userinput.c:322:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  322 |  for (i = 0; i < len; i++) {
      |                ^
openfortivpn/src/tunnel.c: In function ‘pppd_run’:
<command-line>: error: expected expression before ‘/’ token

make: *** [Makefile:47: sub-openfortigui-make_first] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

Add in version 0.9.0-2 suggestion from @aminvakil (remove -j option in make, fix sudoers.d permission, update desktop file) and @aborigines (Update sudo group to be wheel).

Just a couple of things I thought can be used to improve this package, if I'm wrong on any of them, please excuse me:

1) Hard-coding number of threads in make isn't something useful, I think it should either be make or make -j$(nproc), the first one leaves to the user if he has changed all its make to use another number of threads or not and the second one just uses all threads to build the package, either way make -j4 isn't useful.

2) By default /etc/sudoers.d permissions is 640 and if you change its permission after mkdir its folder, it would prevent warning saying:

"warning: directory permissions differ on /etc/sudoers.d/ filesystem: 750 package: 755".

3) As it doesn't work without adding a line from patch to /etc/sudoers.d and it should be run from terminal using sudo, having a file in /usr/share/applications which doesn't work is useless, so I suggest changing Exec line from:

Exec=/usr/bin/openfortigui

to

Exec=/usr/bin/sudo /usr/bin/openfortigui

in /usr/share/applications/openfortigui.desktop.