Package Details: pi-hole-server 5.18.2-1

Git Clone URL: https://aur.archlinux.org/pi-hole-server.git (read-only, click to copy)
Package Base: pi-hole-server
Description: The Pi-hole is an advertising-aware DNS/Web server. Arch adaptation for lan wide DNS server.
Upstream URL: https://github.com/pi-hole/pi-hole
Keywords: ad block pi-hole
Licenses: EUPL-1.2
Conflicts: pi-hole-standalone
Submitter: max.bra
Maintainer: max.bra (graysky)
Last Packager: max.bra
Votes: 112
Popularity: 1.92
First Submitted: 2016-01-13 12:50 (UTC)
Last Updated: 2024-04-01 18:11 (UTC)

Dependencies (18)

Required by (2)

Sources (15)

Pinned Comments

max.bra commented on 2018-02-09 16:45 (UTC) (edited on 2019-10-18 23:14 (UTC) by max.bra)

ArchLinux Pi-hole is not officially supported by Pi-hole project. In case of bugs and malfunctions please DO NOT file a report upstream.

First of all check if the wiki (https://wiki.archlinux.org/index.php/Pi-hole) can help then ask here for assistance and tips.
When it will be excluded that the problem does not depend on ArchLinux we will file a bug upstream.

Latest Comments

« First ‹ Previous 1 2 3 4 5 6 7 8 .. 80 Next › Last »

2-d commented on 2023-10-10 19:15 (UTC)

@max.bra

Thanks for the update - this worked for me. I also had to change the wwwpkgname from AdminLTE to web.

_wwwpkgname=web

max.bra commented on 2023-10-09 16:15 (UTC) (edited on 2023-10-09 16:18 (UTC) by max.bra)

@grappas hi and thanks for reporting.
the developers have deeply modified the latest version of the web admin without changing the numbering (and there are sed errors). very strange, a mistake on their part is possible, I don't think it was intentional. let's see what happens in the next few hours... in the meantime, modifying the PKGBUILD, use version 5.19 of the web-admin.

 _wwwpkgver=5.19
 ...
 "https://raw.githubusercontent.com/max72bra/pi-hole-server-archlinux-customization/master/arch-server-admin-$_wwwpkgver-1.patch"

of course, resum everything...

grappas commented on 2023-10-09 15:49 (UTC) (edited on 2023-10-09 15:51 (UTC) by grappas) 

==> Validating source files with sha256sums...
    pi-hole-server-core-5.17.1.tar.gz ... Passed
    pi-hole-server-admin-5.20.1.tar.gz ... FAILED
    arch-server-core-5.17.1-3.patch ... Passed
    arch-server-admin-5.20.1-3.patch ... Passed
    dnsmasq.include ... Passed
    lighttpd.pi-hole.conf ... Passed
    nginx.pi-hole.conf ... Passed
    pi-hole.tmpfile ... Passed
    pi-hole-gravity.service ... Passed
    pi-hole-gravity.timer ... Passed
    pi-hole-logtruncate.service ... Passed
    pi-hole-logtruncate.timer ... Passed
    mimic_setupVars.conf.sh ... Passed
    mimic_basic-install.sh ... Passed
    piholeDebug.sh ... Passed
==> ERROR: One or more files did not pass the validity check!

I cannot proceed with installation.

max.bra commented on 2023-09-22 19:11 (UTC)

@deemon i don't know how to help you, we have no control over that...

deemon commented on 2023-09-22 18:59 (UTC)

sudo pihole -g

  [i] Target: https://mirror1.malwaredomains.com/files/justdomains
  [✗] Status: Not found
  [✗] List download failed: using previously cached list
  [✓] Parsed 26854 exact domains and 0 ABP-style domains (ignored 0 non-domain entries)

max.bra commented on 2023-08-21 17:07 (UTC)

@daniel back home and see a missed new function 'get_remote_hash', fixed w/o release bump. thanks for reporting.

daniel_shub commented on 2023-08-21 15:23 (UTC)

I can get the git issue during runtime with pihole updatechecker. I am not sure how useful running that command is and if it is fully documented/supported. I also get the git issue during installation. I think there are two questions/issues:

1) Can you (or anyone) reproduce my "bug report" with errors regarding git and the missing pihole user when installing into a clean chroot.

2) If my bug report is reproducible, is it worth fixing the PKGBUILD.

I am not familiar enough with sysuser files to know if the missing user issue can be solved by simply restarting systemd-sysusers. If that is the case, I am not sure if it should be restarted in this package or the ftl package.

Adding git as a runtime dependency will protect against any runtime code pathways that depend on git. If it is really only obscure uses, adding it as a optional dependency seems warranted. That said, the package install script is not an obscure usage. In fact, it is essentially a mandatory usage. Adding git as a runtime dependency would only partially deal with the issue of running updatecheck.sh in the package install script; there is a chicken and egg loop since updatecheck.sh needs external internet access to setup a DNS, but external internet access requires a configured DNS. While not explicitly mentioned in the packaging guidelines, I think packages should support offline installation. I am not sure why updatecheck.sh is even run in the install script.

max.bra commented on 2023-08-21 14:22 (UTC) (edited on 2023-08-21 14:22 (UTC) by max.bra)

at runtime you never get there... and, don't read upstream source, read AUR modified source

daniel_shub commented on 2023-08-21 14:17 (UTC)

@max.bra I am not sure what I am double checking for, but updatecheck.sh (https://github.com/pi-hole/pi-hole/blob/v5.17.1/advanced/Scripts/updatecheck.sh) calls git on line 33 just like the error I get says:


function get_remote_hash(){
    git ls-remote "https://github.com/pi-hole/${1}" --tags "${2}" | awk '{print substr($0, 0,8);}' || return 1
}

and get_remote_hash is called on line 83


GITHUB_CORE_HASH="$(get_remote_hash pi-hole "${CORE_BRANCH}")"

It looks like the git dependencies were added in this commit https://github.com/pi-hole/pi-hole/commit/888e44e53d81f505f958322f411cfcc96269f4b8

Can you build the package in a clean chroot and then install it in another clean chroot?

max.bra commented on 2023-08-21 13:59 (UTC)

please, double check updatecheck.sh

« First ‹ Previous 1 2 3 4 5 6 7 8 .. 80 Next › Last »